-
Notifications
You must be signed in to change notification settings - Fork 319
Cleanup classpath for modules with dependency on Groovy and Spock #10069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup classpath for modules with dependency on Groovy and Spock #10069
Conversation
| addTestSuiteForDir('latestDepTest', 'test') | ||
|
|
||
| dependencies { | ||
| testImplementation(libs.javaparser) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just wondering -- do you know why this previously didn't need to be included?
I see that you also included libs.javaparser with your changes in gradle/libs.versions.toml, but if I understand correctly, this library wasn't a part of groovy-all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it is from groovy-all:
./gradlew :dd-java-agent:instrumentation:java:java-lang:java-lang-15.0:dependencies
Part of the tree:
org.codehaus.groovy:groovy-all:3.0.24
| +--- org.codehaus.groovy:groovy-groovydoc:3.0.24
| | +--- org.codehaus.groovy:groovy:3.0.24
| | \--- com.github.javaparser:javaparser-core:3.25.6
And there usage in tests:
import com.github.javaparser.utils.StringEscapeUtils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR make that obvious, that we NEVER used groovydoc, but its transitive dependency :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhh cool okay, thanks!
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~cc8f8dde47, baseline=1.57.0-SNAPSHOT~f4c301affe
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1086271
Total [baseline] (10.917 s) : 0, 10916719
Agent [candidate] (1.083 s) : 0, 1082808
Total [candidate] (10.856 s) : 0, 10855906
section appsec
Agent [baseline] (1.276 s) : 0, 1276202
Total [baseline] (10.955 s) : 0, 10954714
Agent [candidate] (1.268 s) : 0, 1267669
Total [candidate] (11.005 s) : 0, 11005499
section iast
Agent [baseline] (1.232 s) : 0, 1232379
Total [baseline] (11.28 s) : 0, 11279886
Agent [candidate] (1.226 s) : 0, 1225820
Total [candidate] (11.308 s) : 0, 11307933
section profiling
Agent [baseline] (1.207 s) : 0, 1206953
Total [baseline] (11.046 s) : 0, 11045587
Agent [candidate] (1.204 s) : 0, 1203827
Total [candidate] (10.941 s) : 0, 10941484
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~cc8f8dde47, baseline=1.57.0-SNAPSHOT~f4c301affe
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (651.617 ms) : 0, 651617
BytebuddyAgent [candidate] (649.635 ms) : 0, 649635
GlobalTracer [baseline] (283.367 ms) : 0, 283367
GlobalTracer [candidate] (281.925 ms) : 0, 281925
AppSec [baseline] (32.632 ms) : 0, 32632
AppSec [candidate] (32.364 ms) : 0, 32364
Debugger [baseline] (68.353 ms) : 0, 68353
Debugger [candidate] (68.53 ms) : 0, 68530
Remote Config [baseline] (648.626 µs) : 0, 649
Remote Config [candidate] (655.33 µs) : 0, 655
Telemetry [baseline] (9.126 ms) : 0, 9126
Telemetry [candidate] (9.086 ms) : 0, 9086
Flare Poller [baseline] (3.753 ms) : 0, 3753
Flare Poller [candidate] (3.798 ms) : 0, 3798
section appsec
crashtracking [baseline] (1.236 ms) : 0, 1236
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (696.338 ms) : 0, 696338
BytebuddyAgent [candidate] (691.233 ms) : 0, 691233
GlobalTracer [baseline] (260.536 ms) : 0, 260536
GlobalTracer [candidate] (259.151 ms) : 0, 259151
IAST [baseline] (24.841 ms) : 0, 24841
IAST [candidate] (24.625 ms) : 0, 24625
AppSec [baseline] (175.715 ms) : 0, 175715
AppSec [candidate] (175.76 ms) : 0, 175760
Debugger [baseline] (67.895 ms) : 0, 67895
Debugger [candidate] (66.577 ms) : 0, 66577
Remote Config [baseline] (737.392 µs) : 0, 737
Remote Config [candidate] (710.948 µs) : 0, 711
Telemetry [baseline] (9.129 ms) : 0, 9129
Telemetry [candidate] (8.959 ms) : 0, 8959
Flare Poller [baseline] (3.914 ms) : 0, 3914
Flare Poller [candidate] (3.883 ms) : 0, 3883
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (797.019 ms) : 0, 797019
BytebuddyAgent [candidate] (793.496 ms) : 0, 793496
GlobalTracer [baseline] (257.714 ms) : 0, 257714
GlobalTracer [candidate] (255.898 ms) : 0, 255898
IAST [baseline] (27.431 ms) : 0, 27431
IAST [candidate] (26.803 ms) : 0, 26803
AppSec [baseline] (34.787 ms) : 0, 34787
AppSec [candidate] (34.987 ms) : 0, 34987
Debugger [baseline] (66.126 ms) : 0, 66126
Debugger [candidate] (65.402 ms) : 0, 65402
Remote Config [baseline] (555.575 µs) : 0, 556
Remote Config [candidate] (548.232 µs) : 0, 548
Telemetry [baseline] (8.46 ms) : 0, 8460
Telemetry [candidate] (8.401 ms) : 0, 8401
Flare Poller [baseline] (3.464 ms) : 0, 3464
Flare Poller [candidate] (3.452 ms) : 0, 3452
section profiling
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (702.791 ms) : 0, 702791
BytebuddyAgent [candidate] (701.228 ms) : 0, 701228
GlobalTracer [baseline] (221.283 ms) : 0, 221283
GlobalTracer [candidate] (220.815 ms) : 0, 220815
AppSec [baseline] (32.115 ms) : 0, 32115
AppSec [candidate] (31.92 ms) : 0, 31920
Debugger [baseline] (68.593 ms) : 0, 68593
Debugger [candidate] (68.49 ms) : 0, 68490
Remote Config [baseline] (645.583 µs) : 0, 646
Remote Config [candidate] (611.395 µs) : 0, 611
Telemetry [baseline] (9.178 ms) : 0, 9178
Telemetry [candidate] (9.039 ms) : 0, 9039
Flare Poller [baseline] (3.796 ms) : 0, 3796
Flare Poller [candidate] (3.747 ms) : 0, 3747
ProfilingAgent [baseline] (97.351 ms) : 0, 97351
ProfilingAgent [candidate] (96.902 ms) : 0, 96902
Profiling [baseline] (97.927 ms) : 0, 97927
Profiling [candidate] (97.485 ms) : 0, 97485
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~cc8f8dde47, baseline=1.57.0-SNAPSHOT~f4c301affe
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081129
Total [baseline] (8.73 s) : 0, 8730063
Agent [candidate] (1.082 s) : 0, 1082113
Total [candidate] (8.758 s) : 0, 8757530
section iast
Agent [baseline] (1.229 s) : 0, 1229132
Total [baseline] (9.407 s) : 0, 9406533
Agent [candidate] (1.234 s) : 0, 1234042
Total [candidate] (9.435 s) : 0, 9434966
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~cc8f8dde47, baseline=1.57.0-SNAPSHOT~f4c301affe
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (648.69 ms) : 0, 648690
BytebuddyAgent [candidate] (649.386 ms) : 0, 649386
GlobalTracer [baseline] (281.569 ms) : 0, 281569
GlobalTracer [candidate] (282.436 ms) : 0, 282436
AppSec [baseline] (32.453 ms) : 0, 32453
AppSec [candidate] (32.395 ms) : 0, 32395
Debugger [baseline] (68.187 ms) : 0, 68187
Debugger [candidate] (67.631 ms) : 0, 67631
Remote Config [baseline] (624.354 µs) : 0, 624
Remote Config [candidate] (662.182 µs) : 0, 662
Telemetry [baseline] (9.029 ms) : 0, 9029
Telemetry [candidate] (9.057 ms) : 0, 9057
Flare Poller [baseline] (3.8 ms) : 0, 3800
Flare Poller [candidate] (3.753 ms) : 0, 3753
section iast
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.217 ms) : 0, 1217
BytebuddyAgent [baseline] (795.904 ms) : 0, 795904
BytebuddyAgent [candidate] (798.827 ms) : 0, 798827
GlobalTracer [baseline] (257.118 ms) : 0, 257118
GlobalTracer [candidate] (257.893 ms) : 0, 257893
IAST [baseline] (27.212 ms) : 0, 27212
IAST [candidate] (27.361 ms) : 0, 27361
AppSec [baseline] (33.732 ms) : 0, 33732
AppSec [candidate] (35.586 ms) : 0, 35586
Debugger [baseline] (65.933 ms) : 0, 65933
Debugger [candidate] (64.805 ms) : 0, 64805
Remote Config [baseline] (522.092 µs) : 0, 522
Remote Config [candidate] (551.502 µs) : 0, 552
Telemetry [baseline] (8.416 ms) : 0, 8416
Telemetry [candidate] (8.492 ms) : 0, 8492
Flare Poller [baseline] (3.479 ms) : 0, 3479
Flare Poller [candidate] (3.538 ms) : 0, 3538
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~cc8f8dde47, baseline=1.57.0-SNAPSHOT~f4c301affe
dateFormat X
axisFormat %s
section baseline
no_agent (19.134 ms) : 18941, 19327
. : milestone, 19134,
appsec (18.564 ms) : 18374, 18753
. : milestone, 18564,
code_origins (18.03 ms) : 17849, 18212
. : milestone, 18030,
iast (17.635 ms) : 17456, 17815
. : milestone, 17635,
profiling (18.606 ms) : 18420, 18791
. : milestone, 18606,
tracing (17.85 ms) : 17669, 18030
. : milestone, 17850,
section candidate
no_agent (17.3 ms) : 17128, 17473
. : milestone, 17300,
appsec (18.668 ms) : 18483, 18853
. : milestone, 18668,
code_origins (17.905 ms) : 17726, 18084
. : milestone, 17905,
iast (17.791 ms) : 17612, 17970
. : milestone, 17791,
profiling (18.719 ms) : 18531, 18907
. : milestone, 18719,
tracing (18.79 ms) : 18599, 18981
. : milestone, 18790,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~cc8f8dde47, baseline=1.57.0-SNAPSHOT~f4c301affe
dateFormat X
axisFormat %s
section baseline
no_agent (1.217 ms) : 1205, 1229
. : milestone, 1217,
iast (3.2 ms) : 3158, 3242
. : milestone, 3200,
iast_FULL (5.654 ms) : 5599, 5709
. : milestone, 5654,
iast_GLOBAL (3.633 ms) : 3579, 3688
. : milestone, 3633,
profiling (2.248 ms) : 2226, 2270
. : milestone, 2248,
tracing (1.808 ms) : 1793, 1823
. : milestone, 1808,
section candidate
no_agent (1.221 ms) : 1208, 1233
. : milestone, 1221,
iast (3.313 ms) : 3264, 3363
. : milestone, 3313,
iast_FULL (5.64 ms) : 5583, 5696
. : milestone, 5640,
iast_GLOBAL (3.74 ms) : 3678, 3802
. : milestone, 3740,
profiling (2.11 ms) : 2092, 2129
. : milestone, 2110,
tracing (1.79 ms) : 1775, 1805
. : milestone, 1790,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~cc8f8dde47, baseline=1.57.0-SNAPSHOT~f4c301affe
dateFormat X
axisFormat %s
section baseline
no_agent (14.862 s) : 14862000, 14862000
. : milestone, 14862000,
appsec (14.559 s) : 14559000, 14559000
. : milestone, 14559000,
iast (18.073 s) : 18073000, 18073000
. : milestone, 18073000,
iast_GLOBAL (17.964 s) : 17964000, 17964000
. : milestone, 17964000,
profiling (14.917 s) : 14917000, 14917000
. : milestone, 14917000,
tracing (14.68 s) : 14680000, 14680000
. : milestone, 14680000,
section candidate
no_agent (15.016 s) : 15016000, 15016000
. : milestone, 15016000,
appsec (14.734 s) : 14734000, 14734000
. : milestone, 14734000,
iast (18.402 s) : 18402000, 18402000
. : milestone, 18402000,
iast_GLOBAL (17.897 s) : 17897000, 17897000
. : milestone, 17897000,
profiling (14.622 s) : 14622000, 14622000
. : milestone, 14622000,
tracing (14.696 s) : 14696000, 14696000
. : milestone, 14696000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~cc8f8dde47, baseline=1.57.0-SNAPSHOT~f4c301affe
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (2.515 ms) : 2460, 2570
. : milestone, 2515,
iast (2.214 ms) : 2150, 2279
. : milestone, 2214,
iast_GLOBAL (2.251 ms) : 2186, 2315
. : milestone, 2251,
profiling (2.061 ms) : 2009, 2113
. : milestone, 2061,
tracing (2.051 ms) : 2000, 2102
. : milestone, 2051,
section candidate
no_agent (1.48 ms) : 1468, 1492
. : milestone, 1480,
appsec (3.661 ms) : 3446, 3875
. : milestone, 3661,
iast (2.218 ms) : 2153, 2283
. : milestone, 2218,
iast_GLOBAL (2.248 ms) : 2183, 2313
. : milestone, 2248,
profiling (2.094 ms) : 2040, 2148
. : milestone, 2094,
tracing (2.048 ms) : 1997, 2099
. : milestone, 2048,
|
What Does This Do
groovy-alldependency with individualgroovy-*modules.GroovyandSpockdependencies so they are used only within the test scope.Motivation
Using the bundled
groovy-allartifact introduces a large set of transitive dependencies into the classpath, many of which are unnecessary. Splitting it into specificgroovy-*modules helps reduce classpath footprint and improves build hygiene.Additionally, several modules previously declared
GroovyandSpockasapidependencies, even when they were only required for testing. This PR corrects that by limiting their usage to the appropriate scope.Additional Notes
Approximately 95% of modules already use
GroovyandSpockviatestImplementation. The remaining modules have been adjusted manually to prevent unneeded classpath pollution.