-
Notifications
You must be signed in to change notification settings - Fork 319
Migrate metadata/supported-configurations.json from V1 to V2 Format.
#10078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~7fbf74ec88, baseline=1.57.0-SNAPSHOT~f2a8d05e73
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1083735
Total [baseline] (8.761 s) : 0, 8761070
Agent [candidate] (1.089 s) : 0, 1088639
Total [candidate] (8.768 s) : 0, 8768418
section iast
Agent [baseline] (1.223 s) : 0, 1223382
Total [baseline] (9.453 s) : 0, 9453038
Agent [candidate] (1.222 s) : 0, 1221712
Total [candidate] (9.345 s) : 0, 9344639
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~7fbf74ec88, baseline=1.57.0-SNAPSHOT~f2a8d05e73
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (651.283 ms) : 0, 651283
BytebuddyAgent [candidate] (653.901 ms) : 0, 653901
GlobalTracer [baseline] (282.084 ms) : 0, 282084
GlobalTracer [candidate] (283.997 ms) : 0, 283997
AppSec [baseline] (32.469 ms) : 0, 32469
AppSec [candidate] (32.758 ms) : 0, 32758
Debugger [baseline] (67.653 ms) : 0, 67653
Debugger [candidate] (67.735 ms) : 0, 67735
Remote Config [baseline] (637.352 µs) : 0, 637
Remote Config [candidate] (639.416 µs) : 0, 639
Telemetry [baseline] (9.023 ms) : 0, 9023
Telemetry [candidate] (8.972 ms) : 0, 8972
Flare Poller [baseline] (3.792 ms) : 0, 3792
Flare Poller [candidate] (3.747 ms) : 0, 3747
section iast
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (791.822 ms) : 0, 791822
BytebuddyAgent [candidate] (791.151 ms) : 0, 791151
GlobalTracer [baseline] (255.85 ms) : 0, 255850
GlobalTracer [candidate] (255.877 ms) : 0, 255877
AppSec [baseline] (35.173 ms) : 0, 35173
AppSec [candidate] (33.659 ms) : 0, 33659
Debugger [baseline] (64.445 ms) : 0, 64445
Debugger [candidate] (65.328 ms) : 0, 65328
Remote Config [baseline] (535.055 µs) : 0, 535
Remote Config [candidate] (548.167 µs) : 0, 548
Telemetry [baseline] (8.457 ms) : 0, 8457
Telemetry [candidate] (8.336 ms) : 0, 8336
Flare Poller [baseline] (3.403 ms) : 0, 3403
Flare Poller [candidate] (3.454 ms) : 0, 3454
IAST [baseline] (27.035 ms) : 0, 27035
IAST [candidate] (26.749 ms) : 0, 26749
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~7fbf74ec88, baseline=1.57.0-SNAPSHOT~f2a8d05e73
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1078994
Total [baseline] (10.91 s) : 0, 10909984
Agent [candidate] (1.081 s) : 0, 1081121
Total [candidate] (10.803 s) : 0, 10802771
section appsec
Agent [baseline] (1.262 s) : 0, 1262333
Total [baseline] (11.057 s) : 0, 11057223
Agent [candidate] (1.26 s) : 0, 1260372
Total [candidate] (10.905 s) : 0, 10904599
section iast
Agent [baseline] (1.224 s) : 0, 1224343
Total [baseline] (11.124 s) : 0, 11123695
Agent [candidate] (1.22 s) : 0, 1220239
Total [candidate] (11.227 s) : 0, 11227170
section profiling
Agent [baseline] (1.206 s) : 0, 1205670
Total [baseline] (11.058 s) : 0, 11058300
Agent [candidate] (1.204 s) : 0, 1204186
Total [candidate] (10.928 s) : 0, 10927524
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~7fbf74ec88, baseline=1.57.0-SNAPSHOT~f2a8d05e73
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (647.188 ms) : 0, 647188
BytebuddyAgent [candidate] (649.006 ms) : 0, 649006
GlobalTracer [baseline] (281.3 ms) : 0, 281300
GlobalTracer [candidate] (281.512 ms) : 0, 281512
AppSec [baseline] (32.271 ms) : 0, 32271
AppSec [candidate] (32.425 ms) : 0, 32425
Debugger [baseline] (68.179 ms) : 0, 68179
Debugger [candidate] (68.104 ms) : 0, 68104
Remote Config [baseline] (644.968 µs) : 0, 645
Remote Config [candidate] (656.597 µs) : 0, 657
Telemetry [baseline] (9.088 ms) : 0, 9088
Telemetry [candidate] (9.073 ms) : 0, 9073
Flare Poller [baseline] (3.762 ms) : 0, 3762
Flare Poller [candidate] (3.778 ms) : 0, 3778
section appsec
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.173 ms) : 0, 1173
BytebuddyAgent [baseline] (688.052 ms) : 0, 688052
BytebuddyAgent [candidate] (687.432 ms) : 0, 687432
GlobalTracer [baseline] (258.887 ms) : 0, 258887
GlobalTracer [candidate] (257.902 ms) : 0, 257902
AppSec [baseline] (174.499 ms) : 0, 174499
AppSec [candidate] (174.115 ms) : 0, 174115
Debugger [baseline] (66.221 ms) : 0, 66221
Debugger [candidate] (66.246 ms) : 0, 66246
Remote Config [baseline] (715.856 µs) : 0, 716
Remote Config [candidate] (704.846 µs) : 0, 705
Telemetry [baseline] (8.936 ms) : 0, 8936
Telemetry [candidate] (8.969 ms) : 0, 8969
Flare Poller [baseline] (3.877 ms) : 0, 3877
Flare Poller [candidate] (3.853 ms) : 0, 3853
IAST [baseline] (24.457 ms) : 0, 24457
IAST [candidate] (24.622 ms) : 0, 24622
section iast
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (791.027 ms) : 0, 791027
BytebuddyAgent [candidate] (788.684 ms) : 0, 788684
GlobalTracer [baseline] (256.112 ms) : 0, 256112
GlobalTracer [candidate] (255.512 ms) : 0, 255512
AppSec [baseline] (35.127 ms) : 0, 35127
AppSec [candidate] (33.315 ms) : 0, 33315
Debugger [baseline] (66.068 ms) : 0, 66068
Debugger [candidate] (67.124 ms) : 0, 67124
Remote Config [baseline] (544.402 µs) : 0, 544
Remote Config [candidate] (543.524 µs) : 0, 544
Telemetry [baseline] (8.469 ms) : 0, 8469
Telemetry [candidate] (8.333 ms) : 0, 8333
Flare Poller [baseline] (3.516 ms) : 0, 3516
Flare Poller [candidate] (3.49 ms) : 0, 3490
IAST [baseline] (26.957 ms) : 0, 26957
IAST [candidate] (26.814 ms) : 0, 26814
section profiling
ProfilingAgent [baseline] (97.964 ms) : 0, 97964
ProfilingAgent [candidate] (97.422 ms) : 0, 97422
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (702.876 ms) : 0, 702876
BytebuddyAgent [candidate] (701.412 ms) : 0, 701412
GlobalTracer [baseline] (220.18 ms) : 0, 220180
GlobalTracer [candidate] (220.695 ms) : 0, 220695
AppSec [baseline] (32.234 ms) : 0, 32234
AppSec [candidate] (32.068 ms) : 0, 32068
Debugger [baseline] (67.855 ms) : 0, 67855
Debugger [candidate] (68.238 ms) : 0, 68238
Remote Config [baseline] (657.721 µs) : 0, 658
Remote Config [candidate] (638.168 µs) : 0, 638
Telemetry [baseline] (9.117 ms) : 0, 9117
Telemetry [candidate] (9.061 ms) : 0, 9061
Flare Poller [baseline] (3.77 ms) : 0, 3770
Flare Poller [candidate] (3.752 ms) : 0, 3752
Profiling [baseline] (98.552 ms) : 0, 98552
Profiling [candidate] (97.998 ms) : 0, 97998
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 16 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~7fbf74ec88, baseline=1.57.0-SNAPSHOT~f2a8d05e73
dateFormat X
axisFormat %s
section baseline
no_agent (18.133 ms) : 17946, 18319
. : milestone, 18133,
appsec (18.711 ms) : 18524, 18899
. : milestone, 18711,
code_origins (17.871 ms) : 17692, 18050
. : milestone, 17871,
iast (17.382 ms) : 17209, 17554
. : milestone, 17382,
profiling (18.856 ms) : 18664, 19048
. : milestone, 18856,
tracing (17.483 ms) : 17309, 17658
. : milestone, 17483,
section candidate
no_agent (18.035 ms) : 17848, 18222
. : milestone, 18035,
appsec (18.541 ms) : 18353, 18729
. : milestone, 18541,
code_origins (17.658 ms) : 17483, 17833
. : milestone, 17658,
iast (18.519 ms) : 18337, 18701
. : milestone, 18519,
profiling (19.543 ms) : 19348, 19737
. : milestone, 19543,
tracing (17.912 ms) : 17732, 18092
. : milestone, 17912,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~7fbf74ec88, baseline=1.57.0-SNAPSHOT~f2a8d05e73
dateFormat X
axisFormat %s
section baseline
no_agent (1.196 ms) : 1186, 1207
. : milestone, 1196,
iast (3.274 ms) : 3232, 3315
. : milestone, 3274,
iast_FULL (6.025 ms) : 5964, 6087
. : milestone, 6025,
iast_GLOBAL (3.637 ms) : 3577, 3697
. : milestone, 3637,
profiling (1.983 ms) : 1966, 2000
. : milestone, 1983,
tracing (1.81 ms) : 1795, 1825
. : milestone, 1810,
section candidate
no_agent (1.199 ms) : 1187, 1211
. : milestone, 1199,
iast (3.2 ms) : 3162, 3238
. : milestone, 3200,
iast_FULL (5.681 ms) : 5625, 5737
. : milestone, 5681,
iast_GLOBAL (3.556 ms) : 3504, 3608
. : milestone, 3556,
profiling (2.096 ms) : 2077, 2115
. : milestone, 2096,
tracing (1.808 ms) : 1793, 1822
. : milestone, 1808,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~7fbf74ec88, baseline=1.57.0-SNAPSHOT~f2a8d05e73
dateFormat X
axisFormat %s
section baseline
no_agent (15.415 s) : 15415000, 15415000
. : milestone, 15415000,
appsec (14.76 s) : 14760000, 14760000
. : milestone, 14760000,
iast (18.165 s) : 18165000, 18165000
. : milestone, 18165000,
iast_GLOBAL (17.937 s) : 17937000, 17937000
. : milestone, 17937000,
profiling (14.602 s) : 14602000, 14602000
. : milestone, 14602000,
tracing (14.738 s) : 14738000, 14738000
. : milestone, 14738000,
section candidate
no_agent (15.621 s) : 15621000, 15621000
. : milestone, 15621000,
appsec (14.786 s) : 14786000, 14786000
. : milestone, 14786000,
iast (18.114 s) : 18114000, 18114000
. : milestone, 18114000,
iast_GLOBAL (18.121 s) : 18121000, 18121000
. : milestone, 18121000,
profiling (14.729 s) : 14729000, 14729000
. : milestone, 14729000,
tracing (14.575 s) : 14575000, 14575000
. : milestone, 14575000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~7fbf74ec88, baseline=1.57.0-SNAPSHOT~f2a8d05e73
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1472, 1495
. : milestone, 1483,
appsec (3.725 ms) : 3504, 3947
. : milestone, 3725,
iast (2.228 ms) : 2163, 2292
. : milestone, 2228,
iast_GLOBAL (2.26 ms) : 2195, 2325
. : milestone, 2260,
profiling (2.105 ms) : 2051, 2159
. : milestone, 2105,
tracing (2.06 ms) : 2009, 2111
. : milestone, 2060,
section candidate
no_agent (1.488 ms) : 1476, 1499
. : milestone, 1488,
appsec (3.718 ms) : 3498, 3938
. : milestone, 3718,
iast (2.227 ms) : 2162, 2291
. : milestone, 2227,
iast_GLOBAL (2.271 ms) : 2207, 2336
. : milestone, 2271,
profiling (2.087 ms) : 2033, 2140
. : milestone, 2087,
tracing (2.047 ms) : 1997, 2098
. : milestone, 2047,
|
ebce085 to
93029a1
Compare
ba0ea25 to
a1594bf
Compare
metadata/supported-configurations.json from V1 to V2 Format.
53b787b to
a1594bf
Compare
buildSrc/src/main/kotlin/datadog/gradle/plugin/config/ParseV2SupportedConfigurationsTask.kt
Show resolved
Hide resolved
AlexeyKuznetsov-DD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but if it possible to cover this with some tests?
P.S. To run tests for :buildSrc you will need to provide a special flag: ./gradlew :buildSrc:test -PrunBuildSrcTests=true
|
@AlexeyKuznetsov-DD I added tests in |
| /** | ||
| * @return Mapping from propertyKey to configuration | ||
| */ | ||
| public String envFromTelemetryKey(String telemetryKey) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this method will be used in the future ? (or maybe I'm missing its usage here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep exactly!
What Does This Do
This PR migrates the
metadata/supported-configurations.jsonfile from V1 to V2 format and activates theParseV2SupportedConfigurationsTaskto properly parse the V2 format to generate theGeneratedSupportedConfigurations.javafile at build-time. TheParseV2SupportedConfigurationsTaskwas also refactored to use functions to write the file instead of the logic all belonging in thestaticsection of the class to appease the compiler.Additionally, the
SupportedConfigurationclass was added to the Native runtime build.Note: The script to migrate to a V2 format can be found here.
The V2 format is defined here.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]