-
Notifications
You must be signed in to change notification settings - Fork 319
Added missing configuration of Spotless to buildSrc module.
#10085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
AlexeyKuznetsov-DD
wants to merge
7
commits into
master
Choose a base branch
from
alexeyk/spotless-for-build-src
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~54d94e072d, baseline=1.57.0-SNAPSHOT~8299bb0879
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1079436
Total [baseline] (8.74 s) : 0, 8739972
Agent [candidate] (1.081 s) : 0, 1080654
Total [candidate] (8.724 s) : 0, 8723660
section iast
Agent [baseline] (1.227 s) : 0, 1227498
Total [baseline] (9.529 s) : 0, 9528918
Agent [candidate] (1.232 s) : 0, 1232382
Total [candidate] (9.469 s) : 0, 9469232
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~54d94e072d, baseline=1.57.0-SNAPSHOT~8299bb0879
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (648.779 ms) : 0, 648779
BytebuddyAgent [candidate] (648.686 ms) : 0, 648686
GlobalTracer [baseline] (281.414 ms) : 0, 281414
GlobalTracer [candidate] (281.615 ms) : 0, 281615
AppSec [baseline] (32.297 ms) : 0, 32297
AppSec [candidate] (32.53 ms) : 0, 32530
Debugger [baseline] (66.895 ms) : 0, 66895
Debugger [candidate] (67.462 ms) : 0, 67462
Remote Config [baseline] (651.082 µs) : 0, 651
Remote Config [candidate] (650.834 µs) : 0, 651
Telemetry [baseline] (9.01 ms) : 0, 9010
Telemetry [candidate] (9.017 ms) : 0, 9017
Flare Poller [baseline] (3.737 ms) : 0, 3737
Flare Poller [candidate] (3.763 ms) : 0, 3763
section iast
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (793.386 ms) : 0, 793386
BytebuddyAgent [candidate] (798.799 ms) : 0, 798799
GlobalTracer [baseline] (257.149 ms) : 0, 257149
GlobalTracer [candidate] (257.056 ms) : 0, 257056
IAST [baseline] (27.136 ms) : 0, 27136
IAST [candidate] (27.023 ms) : 0, 27023
AppSec [baseline] (35.475 ms) : 0, 35475
AppSec [candidate] (35.654 ms) : 0, 35654
Debugger [baseline] (65.068 ms) : 0, 65068
Debugger [candidate] (64.511 ms) : 0, 64511
Remote Config [baseline] (570.339 µs) : 0, 570
Remote Config [candidate] (554.94 µs) : 0, 555
Telemetry [baseline] (8.573 ms) : 0, 8573
Telemetry [candidate] (8.437 ms) : 0, 8437
Flare Poller [baseline] (3.56 ms) : 0, 3560
Flare Poller [candidate] (3.481 ms) : 0, 3481
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~54d94e072d, baseline=1.57.0-SNAPSHOT~8299bb0879
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081058
Total [baseline] (10.792 s) : 0, 10791888
Agent [candidate] (1.084 s) : 0, 1083591
Total [candidate] (10.829 s) : 0, 10828822
section appsec
Agent [baseline] (1.271 s) : 0, 1271159
Total [baseline] (11.076 s) : 0, 11075921
Agent [candidate] (1.271 s) : 0, 1271464
Total [candidate] (11.052 s) : 0, 11052239
section iast
Agent [baseline] (1.229 s) : 0, 1228588
Total [baseline] (11.17 s) : 0, 11170203
Agent [candidate] (1.222 s) : 0, 1221861
Total [candidate] (11.203 s) : 0, 11202570
section profiling
Agent [baseline] (1.206 s) : 0, 1205607
Total [baseline] (11.044 s) : 0, 11044468
Agent [candidate] (1.213 s) : 0, 1213280
Total [candidate] (11.099 s) : 0, 11098795
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~54d94e072d, baseline=1.57.0-SNAPSHOT~8299bb0879
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (648.767 ms) : 0, 648767
BytebuddyAgent [candidate] (650.952 ms) : 0, 650952
GlobalTracer [baseline] (281.873 ms) : 0, 281873
GlobalTracer [candidate] (282.06 ms) : 0, 282060
AppSec [baseline] (32.193 ms) : 0, 32193
AppSec [candidate] (32.23 ms) : 0, 32230
Debugger [baseline] (68.231 ms) : 0, 68231
Debugger [candidate] (68.144 ms) : 0, 68144
Remote Config [baseline] (651.563 µs) : 0, 652
Remote Config [candidate] (638.502 µs) : 0, 639
Telemetry [baseline] (8.941 ms) : 0, 8941
Telemetry [candidate] (8.926 ms) : 0, 8926
Flare Poller [baseline] (3.746 ms) : 0, 3746
Flare Poller [candidate] (3.727 ms) : 0, 3727
section appsec
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (692.415 ms) : 0, 692415
BytebuddyAgent [candidate] (693.569 ms) : 0, 693569
GlobalTracer [baseline] (261.212 ms) : 0, 261212
GlobalTracer [candidate] (260.309 ms) : 0, 260309
IAST [baseline] (24.901 ms) : 0, 24901
IAST [candidate] (24.834 ms) : 0, 24834
AppSec [baseline] (175.251 ms) : 0, 175251
AppSec [candidate] (175.709 ms) : 0, 175709
Debugger [baseline] (66.978 ms) : 0, 66978
Debugger [candidate] (66.511 ms) : 0, 66511
Remote Config [baseline] (701.313 µs) : 0, 701
Remote Config [candidate] (690.509 µs) : 0, 691
Telemetry [baseline] (9.027 ms) : 0, 9027
Telemetry [candidate] (9.084 ms) : 0, 9084
Flare Poller [baseline] (3.879 ms) : 0, 3879
Flare Poller [candidate] (3.996 ms) : 0, 3996
section iast
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (793.421 ms) : 0, 793421
BytebuddyAgent [candidate] (789.486 ms) : 0, 789486
GlobalTracer [baseline] (257.463 ms) : 0, 257463
GlobalTracer [candidate] (255.358 ms) : 0, 255358
IAST [baseline] (27.271 ms) : 0, 27271
IAST [candidate] (26.911 ms) : 0, 26911
AppSec [baseline] (35.517 ms) : 0, 35517
AppSec [candidate] (35.324 ms) : 0, 35324
Debugger [baseline] (65.806 ms) : 0, 65806
Debugger [candidate] (65.804 ms) : 0, 65804
Remote Config [baseline] (556.786 µs) : 0, 557
Remote Config [candidate] (543.334 µs) : 0, 543
Telemetry [baseline] (8.455 ms) : 0, 8455
Telemetry [candidate] (8.437 ms) : 0, 8437
Flare Poller [baseline] (3.457 ms) : 0, 3457
Flare Poller [candidate] (3.453 ms) : 0, 3453
section profiling
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (701.61 ms) : 0, 701610
BytebuddyAgent [candidate] (706.709 ms) : 0, 706709
GlobalTracer [baseline] (220.628 ms) : 0, 220628
GlobalTracer [candidate] (222.624 ms) : 0, 222624
AppSec [baseline] (32.35 ms) : 0, 32350
AppSec [candidate] (32.552 ms) : 0, 32552
Debugger [baseline] (68.28 ms) : 0, 68280
Debugger [candidate] (68.229 ms) : 0, 68229
Remote Config [baseline] (614.904 µs) : 0, 615
Remote Config [candidate] (616.177 µs) : 0, 616
Telemetry [baseline] (9.063 ms) : 0, 9063
Telemetry [candidate] (9.033 ms) : 0, 9033
Flare Poller [baseline] (3.757 ms) : 0, 3757
Flare Poller [candidate] (3.87 ms) : 0, 3870
ProfilingAgent [baseline] (98.404 ms) : 0, 98404
ProfilingAgent [candidate] (98.395 ms) : 0, 98395
Profiling [baseline] (98.993 ms) : 0, 98993
Profiling [candidate] (98.984 ms) : 0, 98984
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~54d94e072d, baseline=1.57.0-SNAPSHOT~8299bb0879
dateFormat X
axisFormat %s
section baseline
no_agent (19.038 ms) : 18843, 19234
. : milestone, 19038,
appsec (18.536 ms) : 18347, 18724
. : milestone, 18536,
code_origins (17.689 ms) : 17510, 17868
. : milestone, 17689,
iast (17.699 ms) : 17520, 17878
. : milestone, 17699,
profiling (18.367 ms) : 18184, 18550
. : milestone, 18367,
tracing (17.547 ms) : 17372, 17723
. : milestone, 17547,
section candidate
no_agent (18.393 ms) : 18199, 18586
. : milestone, 18393,
appsec (18.776 ms) : 18584, 18967
. : milestone, 18776,
code_origins (17.834 ms) : 17658, 18010
. : milestone, 17834,
iast (18.562 ms) : 18374, 18751
. : milestone, 18562,
profiling (18.943 ms) : 18752, 19135
. : milestone, 18943,
tracing (17.585 ms) : 17410, 17760
. : milestone, 17585,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~54d94e072d, baseline=1.57.0-SNAPSHOT~8299bb0879
dateFormat X
axisFormat %s
section baseline
no_agent (1.19 ms) : 1179, 1202
. : milestone, 1190,
iast (3.183 ms) : 3142, 3225
. : milestone, 3183,
iast_FULL (5.877 ms) : 5819, 5935
. : milestone, 5877,
iast_GLOBAL (3.623 ms) : 3572, 3674
. : milestone, 3623,
profiling (2.069 ms) : 2050, 2088
. : milestone, 2069,
tracing (1.837 ms) : 1821, 1852
. : milestone, 1837,
section candidate
no_agent (1.186 ms) : 1175, 1197
. : milestone, 1186,
iast (3.204 ms) : 3163, 3246
. : milestone, 3204,
iast_FULL (5.733 ms) : 5676, 5791
. : milestone, 5733,
iast_GLOBAL (3.731 ms) : 3675, 3787
. : milestone, 3731,
profiling (2.013 ms) : 1996, 2030
. : milestone, 2013,
tracing (1.86 ms) : 1844, 1876
. : milestone, 1860,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~54d94e072d, baseline=1.57.0-SNAPSHOT~8299bb0879
dateFormat X
axisFormat %s
section baseline
no_agent (15.569 s) : 15569000, 15569000
. : milestone, 15569000,
appsec (14.439 s) : 14439000, 14439000
. : milestone, 14439000,
iast (18.229 s) : 18229000, 18229000
. : milestone, 18229000,
iast_GLOBAL (17.686 s) : 17686000, 17686000
. : milestone, 17686000,
profiling (14.445 s) : 14445000, 14445000
. : milestone, 14445000,
tracing (14.766 s) : 14766000, 14766000
. : milestone, 14766000,
section candidate
no_agent (15.656 s) : 15656000, 15656000
. : milestone, 15656000,
appsec (14.485 s) : 14485000, 14485000
. : milestone, 14485000,
iast (17.98 s) : 17980000, 17980000
. : milestone, 17980000,
iast_GLOBAL (17.888 s) : 17888000, 17888000
. : milestone, 17888000,
profiling (15.03 s) : 15030000, 15030000
. : milestone, 15030000,
tracing (14.675 s) : 14675000, 14675000
. : milestone, 14675000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~54d94e072d, baseline=1.57.0-SNAPSHOT~8299bb0879
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.723 ms) : 3504, 3943
. : milestone, 3723,
iast (2.207 ms) : 2142, 2271
. : milestone, 2207,
iast_GLOBAL (2.251 ms) : 2186, 2316
. : milestone, 2251,
profiling (2.099 ms) : 2044, 2154
. : milestone, 2099,
tracing (2.037 ms) : 1986, 2087
. : milestone, 2037,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.711 ms) : 3492, 3931
. : milestone, 3711,
iast (2.201 ms) : 2136, 2265
. : milestone, 2201,
iast_GLOBAL (2.244 ms) : 2179, 2308
. : milestone, 2244,
profiling (2.056 ms) : 2004, 2108
. : milestone, 2056,
tracing (2.038 ms) : 1988, 2089
. : milestone, 2038,
|
sarahchen6
approved these changes
Dec 4, 2025
bric3
approved these changes
Dec 8, 2025
# Conflicts: # buildSrc/src/main/kotlin/datadog/gradle/plugin/config/ConfigInversionLinter.kt # buildSrc/src/main/kotlin/datadog/gradle/plugin/muzzle/MuzzlePlugin.kt # buildSrc/src/main/kotlin/datadog/gradle/plugin/muzzle/tasks/MuzzleTask.kt # buildSrc/src/main/kotlin/dd-trace-java.configure-tests.gradle.kts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: tooling
Build & Tooling
tag: do not merge
Do not merge changes
tag: no release notes
Changes to exclude from release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Added missing configuration and applied
spotlessto:buildSrcmodule.Motivation
Clean code.
Additional Notes
Spotlessplugin was present before, but as we migrating toKotlinit should be configured.