-
Notifications
You must be signed in to change notification settings - Fork 319
Backfilling V2 metadata/supported-configurations.json with Type, Default, and Aliases fields
#10107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~3523893773, baseline=1.57.0-SNAPSHOT~2a81ef5549
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.087 s) : 0, 1087281
Total [baseline] (10.903 s) : 0, 10902744
Agent [candidate] (1.101 s) : 0, 1101232
Total [candidate] (10.938 s) : 0, 10938307
section appsec
Agent [baseline] (1.274 s) : 0, 1274160
Total [baseline] (11.012 s) : 0, 11011800
Agent [candidate] (1.267 s) : 0, 1266746
Total [candidate] (11.0 s) : 0, 10999797
section iast
Agent [baseline] (1.233 s) : 0, 1232507
Total [baseline] (11.274 s) : 0, 11274408
Agent [candidate] (1.225 s) : 0, 1224825
Total [candidate] (11.228 s) : 0, 11228087
section profiling
Agent [baseline] (1.214 s) : 0, 1213583
Total [baseline] (11.025 s) : 0, 11025194
Agent [candidate] (1.207 s) : 0, 1207467
Total [candidate] (11.003 s) : 0, 11002695
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~3523893773, baseline=1.57.0-SNAPSHOT~2a81ef5549
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (652.714 ms) : 0, 652714
BytebuddyAgent [candidate] (660.991 ms) : 0, 660991
GlobalTracer [baseline] (282.954 ms) : 0, 282954
GlobalTracer [candidate] (286.771 ms) : 0, 286771
AppSec [baseline] (32.529 ms) : 0, 32529
AppSec [candidate] (33.185 ms) : 0, 33185
Debugger [baseline] (68.634 ms) : 0, 68634
Debugger [candidate] (69.605 ms) : 0, 69605
Remote Config [baseline] (647.557 µs) : 0, 648
Remote Config [candidate] (642.411 µs) : 0, 642
Telemetry [baseline] (9.169 ms) : 0, 9169
Telemetry [candidate] (9.148 ms) : 0, 9148
Flare Poller [baseline] (3.797 ms) : 0, 3797
Flare Poller [candidate] (3.825 ms) : 0, 3825
section appsec
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (694.037 ms) : 0, 694037
BytebuddyAgent [candidate] (690.514 ms) : 0, 690514
GlobalTracer [baseline] (260.885 ms) : 0, 260885
GlobalTracer [candidate] (259.107 ms) : 0, 259107
AppSec [baseline] (175.743 ms) : 0, 175743
AppSec [candidate] (174.154 ms) : 0, 174154
Debugger [baseline] (67.604 ms) : 0, 67604
Debugger [candidate] (68.064 ms) : 0, 68064
Remote Config [baseline] (706.366 µs) : 0, 706
Remote Config [candidate] (660.506 µs) : 0, 661
Telemetry [baseline] (9.358 ms) : 0, 9358
Telemetry [candidate] (9.013 ms) : 0, 9013
Flare Poller [baseline] (4.048 ms) : 0, 4048
Flare Poller [candidate] (3.876 ms) : 0, 3876
IAST [baseline] (24.792 ms) : 0, 24792
IAST [candidate] (24.538 ms) : 0, 24538
section iast
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (797.706 ms) : 0, 797706
BytebuddyAgent [candidate] (792.25 ms) : 0, 792250
GlobalTracer [baseline] (257.565 ms) : 0, 257565
GlobalTracer [candidate] (256.78 ms) : 0, 256780
AppSec [baseline] (34.438 ms) : 0, 34438
AppSec [candidate] (35.16 ms) : 0, 35160
Debugger [baseline] (66.466 ms) : 0, 66466
Debugger [candidate] (64.514 ms) : 0, 64514
Remote Config [baseline] (561.272 µs) : 0, 561
Remote Config [candidate] (545.219 µs) : 0, 545
Telemetry [baseline] (8.479 ms) : 0, 8479
Telemetry [candidate] (8.439 ms) : 0, 8439
Flare Poller [baseline] (3.458 ms) : 0, 3458
Flare Poller [candidate] (3.458 ms) : 0, 3458
IAST [baseline] (27.107 ms) : 0, 27107
IAST [candidate] (26.959 ms) : 0, 26959
section profiling
ProfilingAgent [baseline] (97.759 ms) : 0, 97759
ProfilingAgent [candidate] (97.567 ms) : 0, 97567
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.225 ms) : 0, 1225
BytebuddyAgent [baseline] (706.596 ms) : 0, 706596
BytebuddyAgent [candidate] (703.199 ms) : 0, 703199
GlobalTracer [baseline] (222.671 ms) : 0, 222671
GlobalTracer [candidate] (221.387 ms) : 0, 221387
AppSec [baseline] (32.344 ms) : 0, 32344
AppSec [candidate] (32.286 ms) : 0, 32286
Debugger [baseline] (68.998 ms) : 0, 68998
Debugger [candidate] (68.416 ms) : 0, 68416
Remote Config [baseline] (647.628 µs) : 0, 648
Remote Config [candidate] (644.806 µs) : 0, 645
Telemetry [baseline] (9.177 ms) : 0, 9177
Telemetry [candidate] (9.036 ms) : 0, 9036
Flare Poller [baseline] (3.841 ms) : 0, 3841
Flare Poller [candidate] (3.707 ms) : 0, 3707
Profiling [baseline] (98.342 ms) : 0, 98342
Profiling [candidate] (98.143 ms) : 0, 98143
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~3523893773, baseline=1.57.0-SNAPSHOT~2a81ef5549
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1090999
Total [baseline] (8.788 s) : 0, 8787672
Agent [candidate] (1.083 s) : 0, 1082732
Total [candidate] (8.749 s) : 0, 8749054
section iast
Agent [baseline] (1.222 s) : 0, 1221896
Total [baseline] (9.402 s) : 0, 9401833
Agent [candidate] (1.223 s) : 0, 1223379
Total [candidate] (9.387 s) : 0, 9387330
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~3523893773, baseline=1.57.0-SNAPSHOT~2a81ef5549
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (654.865 ms) : 0, 654865
BytebuddyAgent [candidate] (650.355 ms) : 0, 650355
GlobalTracer [baseline] (284.501 ms) : 0, 284501
GlobalTracer [candidate] (282.366 ms) : 0, 282366
AppSec [baseline] (32.997 ms) : 0, 32997
AppSec [candidate] (32.3 ms) : 0, 32300
Debugger [baseline] (68.144 ms) : 0, 68144
Debugger [candidate] (67.428 ms) : 0, 67428
Remote Config [baseline] (653.036 µs) : 0, 653
Remote Config [candidate] (648.199 µs) : 0, 648
Telemetry [baseline] (9.085 ms) : 0, 9085
Telemetry [candidate] (9.122 ms) : 0, 9122
Flare Poller [baseline] (3.733 ms) : 0, 3733
Flare Poller [candidate] (3.709 ms) : 0, 3709
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (791.024 ms) : 0, 791024
BytebuddyAgent [candidate] (790.869 ms) : 0, 790869
GlobalTracer [baseline] (255.223 ms) : 0, 255223
GlobalTracer [candidate] (256.336 ms) : 0, 256336
AppSec [baseline] (34.698 ms) : 0, 34698
AppSec [candidate] (33.861 ms) : 0, 33861
Debugger [baseline] (64.824 ms) : 0, 64824
Debugger [candidate] (65.993 ms) : 0, 65993
Remote Config [baseline] (557.92 µs) : 0, 558
Remote Config [candidate] (553.156 µs) : 0, 553
Telemetry [baseline] (8.38 ms) : 0, 8380
Telemetry [candidate] (8.428 ms) : 0, 8428
Flare Poller [baseline] (3.465 ms) : 0, 3465
Flare Poller [candidate] (3.515 ms) : 0, 3515
IAST [baseline] (26.934 ms) : 0, 26934
IAST [candidate] (27.048 ms) : 0, 27048
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 20 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~3523893773, baseline=1.57.0-SNAPSHOT~2a81ef5549
dateFormat X
axisFormat %s
section baseline
no_agent (19.32 ms) : 19120, 19520
. : milestone, 19320,
appsec (19.604 ms) : 19402, 19807
. : milestone, 19604,
code_origins (17.571 ms) : 17395, 17746
. : milestone, 17571,
iast (17.904 ms) : 17725, 18084
. : milestone, 17904,
profiling (18.718 ms) : 18532, 18904
. : milestone, 18718,
tracing (17.854 ms) : 17678, 18030
. : milestone, 17854,
section candidate
no_agent (19.377 ms) : 19177, 19577
. : milestone, 19377,
appsec (19.181 ms) : 18986, 19375
. : milestone, 19181,
code_origins (17.809 ms) : 17633, 17985
. : milestone, 17809,
iast (18.644 ms) : 18457, 18831
. : milestone, 18644,
profiling (19.024 ms) : 18832, 19217
. : milestone, 19024,
tracing (17.809 ms) : 17630, 17988
. : milestone, 17809,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~3523893773, baseline=1.57.0-SNAPSHOT~2a81ef5549
dateFormat X
axisFormat %s
section baseline
no_agent (1.235 ms) : 1223, 1248
. : milestone, 1235,
iast (3.208 ms) : 3166, 3251
. : milestone, 3208,
iast_FULL (5.75 ms) : 5693, 5808
. : milestone, 5750,
iast_GLOBAL (3.692 ms) : 3635, 3750
. : milestone, 3692,
profiling (2.045 ms) : 2027, 2062
. : milestone, 2045,
tracing (1.816 ms) : 1801, 1831
. : milestone, 1816,
section candidate
no_agent (1.199 ms) : 1187, 1211
. : milestone, 1199,
iast (3.144 ms) : 3108, 3181
. : milestone, 3144,
iast_FULL (5.655 ms) : 5599, 5711
. : milestone, 5655,
iast_GLOBAL (3.599 ms) : 3547, 3651
. : milestone, 3599,
profiling (1.979 ms) : 1962, 1995
. : milestone, 1979,
tracing (1.875 ms) : 1859, 1891
. : milestone, 1875,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~3523893773, baseline=1.57.0-SNAPSHOT~2a81ef5549
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (3.665 ms) : 3451, 3880
. : milestone, 3665,
iast (2.199 ms) : 2136, 2263
. : milestone, 2199,
iast_GLOBAL (2.251 ms) : 2187, 2316
. : milestone, 2251,
profiling (2.066 ms) : 2014, 2119
. : milestone, 2066,
tracing (2.042 ms) : 1991, 2093
. : milestone, 2042,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.697 ms) : 3479, 3916
. : milestone, 3697,
iast (2.201 ms) : 2138, 2265
. : milestone, 2201,
iast_GLOBAL (2.252 ms) : 2187, 2316
. : milestone, 2252,
profiling (2.093 ms) : 2039, 2148
. : milestone, 2093,
tracing (2.036 ms) : 1985, 2087
. : milestone, 2036,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~3523893773, baseline=1.57.0-SNAPSHOT~2a81ef5549
dateFormat X
axisFormat %s
section baseline
no_agent (15.558 s) : 15558000, 15558000
. : milestone, 15558000,
appsec (14.605 s) : 14605000, 14605000
. : milestone, 14605000,
iast (18.213 s) : 18213000, 18213000
. : milestone, 18213000,
iast_GLOBAL (17.689 s) : 17689000, 17689000
. : milestone, 17689000,
profiling (15.023 s) : 15023000, 15023000
. : milestone, 15023000,
tracing (14.933 s) : 14933000, 14933000
. : milestone, 14933000,
section candidate
no_agent (15.639 s) : 15639000, 15639000
. : milestone, 15639000,
appsec (14.767 s) : 14767000, 14767000
. : milestone, 14767000,
iast (18.117 s) : 18117000, 18117000
. : milestone, 18117000,
iast_GLOBAL (17.771 s) : 17771000, 17771000
. : milestone, 17771000,
profiling (14.9 s) : 14900000, 14900000
. : milestone, 14900000,
tracing (14.626 s) : 14626000, 14626000
. : milestone, 14626000,
|
ba0ea25 to
a1594bf
Compare
8ada6bb to
76c63a2
Compare
0c5f78d to
d18c7ab
Compare
metadata/supported-configurations.json with Type, Default, and Aliases fields
sarahchen6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skimmed metadata/supported-configurations.json... LGTM
What Does This Do
This PR backfills all configurations in the local
supported-configurations.jsonwith the type, default, and aliases used for each configuration in the Java tracer. The data was procured by logging each call toConfigProvider.javaand manually filling in the gaps when necessary.This PR also enables the strictness field to enforce these fields for future added configurations.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]