Skip to content

Refactor: Introduce overloaded tryCommitBlockingResponse accepting RequestBlockingAction #10125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jandro996 merged 4 commits into from
Dec 11, 2025
Merged

Refactor: Introduce overloaded tryCommitBlockingResponse accepting RequestBlockingAction #10125

jandro996 merged 4 commits into from
Dec 11, 2025

Conversation

@jandro996
Copy link
Member

@jandro996 jandro996 commented Dec 9, 2025

What Does This Do

  1. Added default method to BlockResponseFunction
  2. Updated all call sites to use the new signature:

Motivation

This PR prepares the codebase for adding securityResponseId to RequestBlockingAction in a follow-up PR. Currently, tons of classes manually extract individual fields (statusCode, blockingContentType, extraHeaders) from RequestBlockingAction before calling tryCommitBlockingResponse. This pattern makes it difficult to extend RequestBlockingAction with new fields, as every call site would need to be updated.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@jandro996 jandro996 added type: enhancement Enhancements and improvements tag: no release notes Changes to exclude from release notes comp: asm waf Application Security Management (WAF) labels Dec 9, 2025
@pr-commenter
Copy link

pr-commenter bot commented Dec 9, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alejandro.gonzalez/appsec-block-refactor
git_commit_date 1765415623 1765440913
git_commit_sha f38cc2e 5f62fa1
release_version 1.57.0-SNAPSHOT~f38cc2ee7a 1.57.0-SNAPSHOT~5f62fa11c7
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1765442782 1765442782
ci_job_id 1286453354 1286453354
ci_pipeline_id 86153781 86153781
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-jbmd8jh0 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-jbmd8jh0 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~5f62fa11c7, baseline=1.57.0-SNAPSHOT~f38cc2ee7a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1092165
Total [baseline] (10.911 s) : 0, 10911324
Agent [candidate] (1.081 s) : 0, 1081465
Total [candidate] (10.753 s) : 0, 10753485
section appsec
Agent [baseline] (1.266 s) : 0, 1266057
Total [baseline] (11.12 s) : 0, 11119621
Agent [candidate] (1.273 s) : 0, 1272840
Total [candidate] (11.109 s) : 0, 11108596
section iast
Agent [baseline] (1.223 s) : 0, 1223316
Total [baseline] (11.133 s) : 0, 11132712
Agent [candidate] (1.227 s) : 0, 1227351
Total [candidate] (11.077 s) : 0, 11076639
section profiling
Agent [baseline] (1.221 s) : 0, 1220875
Total [baseline] (11.056 s) : 0, 11055549
Agent [candidate] (1.205 s) : 0, 1205320
Total [candidate] (10.941 s) : 0, 10941346
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent appsec 1.266 s 173.892 ms (15.9%)
Agent iast 1.223 s 131.151 ms (12.0%)
Agent profiling 1.221 s 128.711 ms (11.8%)
Total tracing 10.911 s -
Total appsec 11.12 s 208.296 ms (1.9%)
Total iast 11.133 s 221.387 ms (2.0%)
Total profiling 11.056 s 144.225 ms (1.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent appsec 1.273 s 191.375 ms (17.7%)
Agent iast 1.227 s 145.886 ms (13.5%)
Agent profiling 1.205 s 123.854 ms (11.5%)
Total tracing 10.753 s -
Total appsec 11.109 s 355.111 ms (3.3%)
Total iast 11.077 s 323.155 ms (3.0%)
Total profiling 10.941 s 187.861 ms (1.7%) 
gantt
    title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~5f62fa11c7, baseline=1.57.0-SNAPSHOT~f38cc2ee7a

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.214 ms) : 0, 1214
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (656.126 ms) : 0, 656126
BytebuddyAgent [candidate] (648.957 ms) : 0, 648957
GlobalTracer [baseline] (283.798 ms) : 0, 283798
GlobalTracer [candidate] (281.927 ms) : 0, 281927
AppSec [baseline] (32.672 ms) : 0, 32672
AppSec [candidate] (32.352 ms) : 0, 32352
Debugger [baseline] (68.946 ms) : 0, 68946
Debugger [candidate] (68.199 ms) : 0, 68199
Remote Config [baseline] (655.31 µs) : 0, 655
Remote Config [candidate] (624.943 µs) : 0, 625
Telemetry [baseline] (9.155 ms) : 0, 9155
Telemetry [candidate] (9.051 ms) : 0, 9051
Flare Poller [baseline] (3.771 ms) : 0, 3771
Flare Poller [candidate] (3.711 ms) : 0, 3711
section appsec
crashtracking [baseline] (1.219 ms) : 0, 1219
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (690.173 ms) : 0, 690173
BytebuddyAgent [candidate] (694.864 ms) : 0, 694864
GlobalTracer [baseline] (258.955 ms) : 0, 258955
GlobalTracer [candidate] (261.14 ms) : 0, 261140
IAST [baseline] (24.8 ms) : 0, 24800
IAST [candidate] (24.926 ms) : 0, 24926
AppSec [baseline] (174.325 ms) : 0, 174325
AppSec [candidate] (175.355 ms) : 0, 175355
Debugger [baseline] (67.292 ms) : 0, 67292
Debugger [candidate] (66.005 ms) : 0, 66005
Remote Config [baseline] (727.461 µs) : 0, 727
Remote Config [candidate] (709.458 µs) : 0, 709
Telemetry [baseline] (9.024 ms) : 0, 9024
Telemetry [candidate] (9.123 ms) : 0, 9123
Flare Poller [baseline] (3.96 ms) : 0, 3960
Flare Poller [candidate] (3.943 ms) : 0, 3943
section iast
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (791.149 ms) : 0, 791149
BytebuddyAgent [candidate] (795.43 ms) : 0, 795430
GlobalTracer [baseline] (255.633 ms) : 0, 255633
GlobalTracer [candidate] (255.734 ms) : 0, 255734
IAST [baseline] (26.906 ms) : 0, 26906
IAST [candidate] (26.755 ms) : 0, 26755
AppSec [baseline] (35.311 ms) : 0, 35311
AppSec [candidate] (34.259 ms) : 0, 34259
Debugger [baseline] (65.417 ms) : 0, 65417
Debugger [candidate] (66.031 ms) : 0, 66031
Remote Config [baseline] (546.274 µs) : 0, 546
Remote Config [candidate] (530.296 µs) : 0, 530
Telemetry [baseline] (8.41 ms) : 0, 8410
Telemetry [candidate] (8.435 ms) : 0, 8435
Flare Poller [baseline] (3.457 ms) : 0, 3457
Flare Poller [candidate] (3.467 ms) : 0, 3467
section profiling
crashtracking [baseline] (1.21 ms) : 0, 1210
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (711.96 ms) : 0, 711960
BytebuddyAgent [candidate] (701.963 ms) : 0, 701963
GlobalTracer [baseline] (223.512 ms) : 0, 223512
GlobalTracer [candidate] (220.682 ms) : 0, 220682
AppSec [baseline] (33.028 ms) : 0, 33028
AppSec [candidate] (32.258 ms) : 0, 32258
Debugger [baseline] (69.141 ms) : 0, 69141
Debugger [candidate] (68.615 ms) : 0, 68615
Remote Config [baseline] (644.63 µs) : 0, 645
Remote Config [candidate] (642.291 µs) : 0, 642
Telemetry [baseline] (8.976 ms) : 0, 8976
Telemetry [candidate] (8.93 ms) : 0, 8930
Flare Poller [baseline] (3.793 ms) : 0, 3793
Flare Poller [candidate] (3.755 ms) : 0, 3755
ProfilingAgent [baseline] (98.177 ms) : 0, 98177
ProfilingAgent [candidate] (97.911 ms) : 0, 97911
Profiling [baseline] (98.764 ms) : 0, 98764
Profiling [candidate] (98.485 ms) : 0, 98485
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~5f62fa11c7, baseline=1.57.0-SNAPSHOT~f38cc2ee7a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1087884
Total [baseline] (8.796 s) : 0, 8795589
Agent [candidate] (1.091 s) : 0, 1090654
Total [candidate] (8.794 s) : 0, 8794043
section iast
Agent [baseline] (1.22 s) : 0, 1220277
Total [baseline] (9.46 s) : 0, 9460388
Agent [candidate] (1.223 s) : 0, 1222833
Total [candidate] (9.436 s) : 0, 9435515
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.088 s -
Agent iast 1.22 s 132.393 ms (12.2%)
Total tracing 8.796 s -
Total iast 9.46 s 664.799 ms (7.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.091 s -
Agent iast 1.223 s 132.179 ms (12.1%)
Total tracing 8.794 s -
Total iast 9.436 s 641.472 ms (7.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~5f62fa11c7, baseline=1.57.0-SNAPSHOT~f38cc2ee7a

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (653.751 ms) : 0, 653751
BytebuddyAgent [candidate] (655.111 ms) : 0, 655111
GlobalTracer [baseline] (283.609 ms) : 0, 283609
GlobalTracer [candidate] (284.553 ms) : 0, 284553
AppSec [baseline] (32.564 ms) : 0, 32564
AppSec [candidate] (32.718 ms) : 0, 32718
Debugger [baseline] (67.65 ms) : 0, 67650
Debugger [candidate] (67.558 ms) : 0, 67558
Remote Config [baseline] (657.408 µs) : 0, 657
Remote Config [candidate] (669.517 µs) : 0, 670
Telemetry [baseline] (9.107 ms) : 0, 9107
Telemetry [candidate] (9.178 ms) : 0, 9178
Flare Poller [baseline] (3.771 ms) : 0, 3771
Flare Poller [candidate] (3.911 ms) : 0, 3911
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (788.52 ms) : 0, 788520
BytebuddyAgent [candidate] (791.384 ms) : 0, 791384
GlobalTracer [baseline] (255.856 ms) : 0, 255856
GlobalTracer [candidate] (255.546 ms) : 0, 255546
IAST [baseline] (26.869 ms) : 0, 26869
IAST [candidate] (26.988 ms) : 0, 26988
AppSec [baseline] (34.338 ms) : 0, 34338
AppSec [candidate] (35.468 ms) : 0, 35468
Debugger [baseline] (65.585 ms) : 0, 65585
Debugger [candidate] (64.324 ms) : 0, 64324
Remote Config [baseline] (560.806 µs) : 0, 561
Remote Config [candidate] (535.145 µs) : 0, 535
Telemetry [baseline] (8.427 ms) : 0, 8427
Telemetry [candidate] (8.444 ms) : 0, 8444
Flare Poller [baseline] (3.457 ms) : 0, 3457
Flare Poller [candidate] (3.526 ms) : 0, 3526
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alejandro.gonzalez/appsec-block-refactor
git_commit_date 1765415623 1765440913
git_commit_sha f38cc2e 5f62fa1
release_version 1.57.0-SNAPSHOT~f38cc2ee7a 1.57.0-SNAPSHOT~5f62fa11c7
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1765443264 1765443264
ci_job_id 1286453355 1286453355
ci_pipeline_id 86153781 86153781
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-j93qid7v 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-j93qid7v 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~5f62fa11c7, baseline=1.57.0-SNAPSHOT~f38cc2ee7a
    dateFormat X
    axisFormat %s
section baseline
no_agent (18.898 ms) : 18705, 19091
.   : milestone, 18898,
appsec (18.603 ms) : 18417, 18789
.   : milestone, 18603,
code_origins (17.706 ms) : 17527, 17885
.   : milestone, 17706,
iast (17.843 ms) : 17666, 18019
.   : milestone, 17843,
profiling (18.476 ms) : 18292, 18659
.   : milestone, 18476,
tracing (17.679 ms) : 17507, 17851
.   : milestone, 17679,
section candidate
no_agent (17.3 ms) : 17123, 17478
.   : milestone, 17300,
appsec (18.555 ms) : 18366, 18744
.   : milestone, 18555,
code_origins (17.613 ms) : 17439, 17788
.   : milestone, 17613,
iast (17.786 ms) : 17609, 17964
.   : milestone, 17786,
profiling (18.682 ms) : 18494, 18870
.   : milestone, 18682,
tracing (17.717 ms) : 17539, 17896
.   : milestone, 17717,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.898 ms [18.705 ms, 19.091 ms] -
appsec 18.603 ms [18.417 ms, 18.789 ms] -294.534 µs (-1.6%)
code_origins 17.706 ms [17.527 ms, 17.885 ms] -1.191 ms (-6.3%)
iast 17.843 ms [17.666 ms, 18.019 ms] -1.055 ms (-5.6%)
profiling 18.476 ms [18.292 ms, 18.659 ms] -422.14 µs (-2.2%)
tracing 17.679 ms [17.507 ms, 17.851 ms] -1.219 ms (-6.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 17.3 ms [17.123 ms, 17.478 ms] -
appsec 18.555 ms [18.366 ms, 18.744 ms] 1.255 ms (7.3%)
code_origins 17.613 ms [17.439 ms, 17.788 ms] 312.706 µs (1.8%)
iast 17.786 ms [17.609 ms, 17.964 ms] 485.962 µs (2.8%)
profiling 18.682 ms [18.494 ms, 18.87 ms] 1.382 ms (8.0%)
tracing 17.717 ms [17.539 ms, 17.896 ms] 416.992 µs (2.4%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~5f62fa11c7, baseline=1.57.0-SNAPSHOT~f38cc2ee7a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.197 ms) : 1185, 1209
.   : milestone, 1197,
iast (3.238 ms) : 3194, 3281
.   : milestone, 3238,
iast_FULL (5.753 ms) : 5695, 5811
.   : milestone, 5753,
iast_GLOBAL (3.574 ms) : 3518, 3629
.   : milestone, 3574,
profiling (2.102 ms) : 2083, 2122
.   : milestone, 2102,
tracing (1.803 ms) : 1787, 1820
.   : milestone, 1803,
section candidate
no_agent (1.197 ms) : 1185, 1208
.   : milestone, 1197,
iast (3.328 ms) : 3279, 3377
.   : milestone, 3328,
iast_FULL (5.841 ms) : 5782, 5900
.   : milestone, 5841,
iast_GLOBAL (3.599 ms) : 3541, 3657
.   : milestone, 3599,
profiling (2.051 ms) : 2033, 2069
.   : milestone, 2051,
tracing (1.774 ms) : 1760, 1788
.   : milestone, 1774,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.197 ms [1.185 ms, 1.209 ms] -
iast 3.238 ms [3.194 ms, 3.281 ms] 2.04 ms (170.5%)
iast_FULL 5.753 ms [5.695 ms, 5.811 ms] 4.556 ms (380.6%)
iast_GLOBAL 3.574 ms [3.518 ms, 3.629 ms] 2.377 ms (198.5%)
profiling 2.102 ms [2.083 ms, 2.122 ms] 905.184 µs (75.6%)
tracing 1.803 ms [1.787 ms, 1.82 ms] 606.451 µs (50.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.197 ms [1.185 ms, 1.208 ms] -
iast 3.328 ms [3.279 ms, 3.377 ms] 2.132 ms (178.1%)
iast_FULL 5.841 ms [5.782 ms, 5.9 ms] 4.644 ms (388.2%)
iast_GLOBAL 3.599 ms [3.541 ms, 3.657 ms] 2.402 ms (200.8%)
profiling 2.051 ms [2.033 ms, 2.069 ms] 854.294 µs (71.4%)
tracing 1.774 ms [1.76 ms, 1.788 ms] 577.571 µs (48.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alejandro.gonzalez/appsec-block-refactor
git_commit_date 1765415623 1765440913
git_commit_sha f38cc2e 5f62fa1
release_version 1.57.0-SNAPSHOT~f38cc2ee7a 1.57.0-SNAPSHOT~5f62fa11c7
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1765442987 1765442987
ci_job_id 1286453356 1286453356
ci_pipeline_id 86153781 86153781
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-ynbnzsog 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-ynbnzsog 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~5f62fa11c7, baseline=1.57.0-SNAPSHOT~f38cc2ee7a
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.984 s) : 14984000, 14984000
.   : milestone, 14984000,
appsec (14.64 s) : 14640000, 14640000
.   : milestone, 14640000,
iast (18.55 s) : 18550000, 18550000
.   : milestone, 18550000,
iast_GLOBAL (17.739 s) : 17739000, 17739000
.   : milestone, 17739000,
profiling (15.113 s) : 15113000, 15113000
.   : milestone, 15113000,
tracing (14.766 s) : 14766000, 14766000
.   : milestone, 14766000,
section candidate
no_agent (14.972 s) : 14972000, 14972000
.   : milestone, 14972000,
appsec (14.709 s) : 14709000, 14709000
.   : milestone, 14709000,
iast (18.142 s) : 18142000, 18142000
.   : milestone, 18142000,
iast_GLOBAL (17.851 s) : 17851000, 17851000
.   : milestone, 17851000,
profiling (14.62 s) : 14620000, 14620000
.   : milestone, 14620000,
tracing (14.634 s) : 14634000, 14634000
.   : milestone, 14634000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.984 s [14.984 s, 14.984 s] -
appsec 14.64 s [14.64 s, 14.64 s] -344.0 ms (-2.3%)
iast 18.55 s [18.55 s, 18.55 s] 3.566 s (23.8%)
iast_GLOBAL 17.739 s [17.739 s, 17.739 s] 2.755 s (18.4%)
profiling 15.113 s [15.113 s, 15.113 s] 129.0 ms (0.9%)
tracing 14.766 s [14.766 s, 14.766 s] -218.0 ms (-1.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.972 s [14.972 s, 14.972 s] -
appsec 14.709 s [14.709 s, 14.709 s] -263.0 ms (-1.8%)
iast 18.142 s [18.142 s, 18.142 s] 3.17 s (21.2%)
iast_GLOBAL 17.851 s [17.851 s, 17.851 s] 2.879 s (19.2%)
profiling 14.62 s [14.62 s, 14.62 s] -352.0 ms (-2.4%)
tracing 14.634 s [14.634 s, 14.634 s] -338.0 ms (-2.3%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~5f62fa11c7, baseline=1.57.0-SNAPSHOT~f38cc2ee7a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.482 ms) : 1471, 1494
.   : milestone, 1482,
appsec (3.723 ms) : 3504, 3942
.   : milestone, 3723,
iast (2.211 ms) : 2146, 2275
.   : milestone, 2211,
iast_GLOBAL (2.253 ms) : 2188, 2318
.   : milestone, 2253,
profiling (2.065 ms) : 2013, 2118
.   : milestone, 2065,
tracing (2.05 ms) : 1999, 2101
.   : milestone, 2050,
section candidate
no_agent (1.48 ms) : 1469, 1492
.   : milestone, 1480,
appsec (3.707 ms) : 3488, 3927
.   : milestone, 3707,
iast (2.219 ms) : 2154, 2283
.   : milestone, 2219,
iast_GLOBAL (2.262 ms) : 2197, 2327
.   : milestone, 2262,
profiling (2.099 ms) : 2045, 2153
.   : milestone, 2099,
tracing (2.048 ms) : 1997, 2099
.   : milestone, 2048,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.482 ms [1.471 ms, 1.494 ms] -
appsec 3.723 ms [3.504 ms, 3.942 ms] 2.241 ms (151.2%)
iast 2.211 ms [2.146 ms, 2.275 ms] 728.492 µs (49.2%)
iast_GLOBAL 2.253 ms [2.188 ms, 2.318 ms] 770.952 µs (52.0%)
profiling 2.065 ms [2.013 ms, 2.118 ms] 583.071 µs (39.3%)
tracing 2.05 ms [1.999 ms, 2.101 ms] 567.665 µs (38.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.48 ms [1.469 ms, 1.492 ms] -
appsec 3.707 ms [3.488 ms, 3.927 ms] 2.227 ms (150.4%)
iast 2.219 ms [2.154 ms, 2.283 ms] 738.073 µs (49.9%)
iast_GLOBAL 2.262 ms [2.197 ms, 2.327 ms] 781.89 µs (52.8%)
profiling 2.099 ms [2.045 ms, 2.153 ms] 618.476 µs (41.8%)
tracing 2.048 ms [1.997 ms, 2.099 ms] 567.633 µs (38.3%)

@jandro996 jandro996 marked this pull request as ready for review December 10, 2025 09:03
@jandro996 jandro996 requested review from a team as code owners December 10, 2025 09:03
@jandro996 jandro996 requested review from daniel-romano-DD, manuel-alvarez-alvarez and mtoffl01 and removed request for a team December 10, 2025 09:03
@jandro996 jandro996 enabled auto-merge (squash) December 10, 2025 11:31
@jandro996 jandro996 added tag: no release notes Changes to exclude from release notes and removed tag: no release notes Changes to exclude from release notes labels Dec 10, 2025
@jandro996 jandro996 merged commit 4a91aa7 into master Dec 11, 2025
711 of 713 checks passed
@jandro996 jandro996 deleted the alejandro.gonzalez/appsec-block-refactor branch December 11, 2025 15:52
@github-actions github-actions bot added this to the 1.57.0 milestone Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smola smola smola approved these changes

@manuel-alvarez-alvarez manuel-alvarez-alvarez Awaiting requested review from manuel-alvarez-alvarez manuel-alvarez-alvarez is a code owner automatically assigned from DataDog/asm-java

@daniel-romano-DD daniel-romano-DD Awaiting requested review from daniel-romano-DD daniel-romano-DD is a code owner automatically assigned from DataDog/asm-java

@mtoffl01 mtoffl01 Awaiting requested review from mtoffl01 mtoffl01 is a code owner automatically assigned from DataDog/apm-sdk-capabilities-java

Assignees

No one assigned

Labels

comp: asm waf Application Security Management (WAF) tag: no release notes Changes to exclude from release notes type: enhancement Enhancements and improvements

Projects

None yet

Milestone

1.57.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jandro996 @smola