-
Notifications
You must be signed in to change notification settings - Fork 320
Multi-tracing support for Couchbase #10147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ValentinZakharov
wants to merge
2
commits into
master
Choose a base branch
from
vzakharov/couchbase-multitrace
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~ba9e98f494, baseline=1.57.0-SNAPSHOT~296ecfba9e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.101 s) : 0, 1101432
Total [baseline] (11.017 s) : 0, 11017415
Agent [candidate] (1.082 s) : 0, 1082409
Total [candidate] (10.819 s) : 0, 10819079
section appsec
Agent [baseline] (1.274 s) : 0, 1274382
Total [baseline] (11.165 s) : 0, 11165292
Agent [candidate] (1.264 s) : 0, 1263690
Total [candidate] (11.307 s) : 0, 11307309
section iast
Agent [baseline] (1.223 s) : 0, 1223093
Total [baseline] (11.173 s) : 0, 11173430
Agent [candidate] (1.226 s) : 0, 1225900
Total [candidate] (11.194 s) : 0, 11194394
section profiling
Agent [baseline] (1.215 s) : 0, 1215407
Total [baseline] (11.058 s) : 0, 11058298
Agent [candidate] (1.208 s) : 0, 1208445
Total [candidate] (11.118 s) : 0, 11117575
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~ba9e98f494, baseline=1.57.0-SNAPSHOT~296ecfba9e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.218 ms) : 0, 1218
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (662.228 ms) : 0, 662228
BytebuddyAgent [candidate] (648.637 ms) : 0, 648637
GlobalTracer [baseline] (285.795 ms) : 0, 285795
GlobalTracer [candidate] (282.616 ms) : 0, 282616
AppSec [baseline] (32.983 ms) : 0, 32983
AppSec [candidate] (32.324 ms) : 0, 32324
Debugger [baseline] (69.523 ms) : 0, 69523
Debugger [candidate] (68.608 ms) : 0, 68608
Remote Config [baseline] (643.883 µs) : 0, 644
Remote Config [candidate] (654.975 µs) : 0, 655
Telemetry [baseline] (9.121 ms) : 0, 9121
Telemetry [candidate] (9.052 ms) : 0, 9052
Flare Poller [baseline] (3.843 ms) : 0, 3843
Flare Poller [candidate] (3.723 ms) : 0, 3723
section appsec
crashtracking [baseline] (1.216 ms) : 0, 1216
crashtracking [candidate] (1.211 ms) : 0, 1211
BytebuddyAgent [baseline] (694.219 ms) : 0, 694219
BytebuddyAgent [candidate] (686.923 ms) : 0, 686923
GlobalTracer [baseline] (261.262 ms) : 0, 261262
GlobalTracer [candidate] (258.966 ms) : 0, 258966
AppSec [baseline] (175.972 ms) : 0, 175972
AppSec [candidate] (175.608 ms) : 0, 175608
Debugger [baseline] (67.344 ms) : 0, 67344
Debugger [candidate] (66.88 ms) : 0, 66880
Remote Config [baseline] (732.071 µs) : 0, 732
Remote Config [candidate] (716.328 µs) : 0, 716
Telemetry [baseline] (9.053 ms) : 0, 9053
Telemetry [candidate] (9.298 ms) : 0, 9298
Flare Poller [baseline] (4.008 ms) : 0, 4008
Flare Poller [candidate] (4.046 ms) : 0, 4046
IAST [baseline] (24.839 ms) : 0, 24839
IAST [candidate] (24.593 ms) : 0, 24593
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (790.683 ms) : 0, 790683
BytebuddyAgent [candidate] (791.854 ms) : 0, 791854
GlobalTracer [baseline] (255.711 ms) : 0, 255711
GlobalTracer [candidate] (256.573 ms) : 0, 256573
AppSec [baseline] (35.427 ms) : 0, 35427
AppSec [candidate] (35.259 ms) : 0, 35259
Debugger [baseline] (65.538 ms) : 0, 65538
Debugger [candidate] (66.089 ms) : 0, 66089
Remote Config [baseline] (585.448 µs) : 0, 585
Remote Config [candidate] (544.296 µs) : 0, 544
Telemetry [baseline] (8.421 ms) : 0, 8421
Telemetry [candidate] (8.44 ms) : 0, 8440
Flare Poller [baseline] (3.448 ms) : 0, 3448
Flare Poller [candidate] (3.508 ms) : 0, 3508
IAST [baseline] (26.737 ms) : 0, 26737
IAST [candidate] (26.994 ms) : 0, 26994
section profiling
ProfilingAgent [baseline] (99.899 ms) : 0, 99899
ProfilingAgent [candidate] (98.225 ms) : 0, 98225
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (707.221 ms) : 0, 707221
BytebuddyAgent [candidate] (703.468 ms) : 0, 703468
GlobalTracer [baseline] (222.439 ms) : 0, 222439
GlobalTracer [candidate] (221.685 ms) : 0, 221685
AppSec [baseline] (32.59 ms) : 0, 32590
AppSec [candidate] (32.426 ms) : 0, 32426
Debugger [baseline] (68.463 ms) : 0, 68463
Debugger [candidate] (68.111 ms) : 0, 68111
Remote Config [baseline] (618.89 µs) : 0, 619
Remote Config [candidate] (645.599 µs) : 0, 646
Telemetry [baseline] (9.15 ms) : 0, 9150
Telemetry [candidate] (9.134 ms) : 0, 9134
Flare Poller [baseline] (3.819 ms) : 0, 3819
Flare Poller [candidate] (3.751 ms) : 0, 3751
Profiling [baseline] (100.485 ms) : 0, 100485
Profiling [candidate] (98.797 ms) : 0, 98797
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~ba9e98f494, baseline=1.57.0-SNAPSHOT~296ecfba9e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.093 s) : 0, 1092919
Total [baseline] (8.762 s) : 0, 8761964
Agent [candidate] (1.08 s) : 0, 1079916
Total [candidate] (8.746 s) : 0, 8745574
section iast
Agent [baseline] (1.241 s) : 0, 1241155
Total [baseline] (9.528 s) : 0, 9527602
Agent [candidate] (1.235 s) : 0, 1234583
Total [candidate] (9.527 s) : 0, 9526843
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~ba9e98f494, baseline=1.57.0-SNAPSHOT~296ecfba9e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (656.721 ms) : 0, 656721
BytebuddyAgent [candidate] (648.007 ms) : 0, 648007
GlobalTracer [baseline] (284.62 ms) : 0, 284620
GlobalTracer [candidate] (282.315 ms) : 0, 282315
AppSec [baseline] (32.837 ms) : 0, 32837
AppSec [candidate] (32.289 ms) : 0, 32289
Debugger [baseline] (68.251 ms) : 0, 68251
Debugger [candidate] (67.027 ms) : 0, 67027
Remote Config [baseline] (620.086 µs) : 0, 620
Remote Config [candidate] (652.25 µs) : 0, 652
Telemetry [baseline] (8.995 ms) : 0, 8995
Telemetry [candidate] (9.066 ms) : 0, 9066
Flare Poller [baseline] (3.757 ms) : 0, 3757
Flare Poller [candidate] (3.723 ms) : 0, 3723
section iast
crashtracking [baseline] (1.219 ms) : 0, 1219
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (803.999 ms) : 0, 803999
BytebuddyAgent [candidate] (798.172 ms) : 0, 798172
GlobalTracer [baseline] (259.246 ms) : 0, 259246
GlobalTracer [candidate] (258.248 ms) : 0, 258248
AppSec [baseline] (35.63 ms) : 0, 35630
AppSec [candidate] (35.881 ms) : 0, 35881
Debugger [baseline] (65.075 ms) : 0, 65075
Debugger [candidate] (65.491 ms) : 0, 65491
Remote Config [baseline] (560.861 µs) : 0, 561
Remote Config [candidate] (559.269 µs) : 0, 559
Telemetry [baseline] (8.506 ms) : 0, 8506
Telemetry [candidate] (8.54 ms) : 0, 8540
Flare Poller [baseline] (3.541 ms) : 0, 3541
Flare Poller [candidate] (3.554 ms) : 0, 3554
IAST [baseline] (27.379 ms) : 0, 27379
IAST [candidate] (27.175 ms) : 0, 27175
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~ba9e98f494, baseline=1.57.0-SNAPSHOT~296ecfba9e
dateFormat X
axisFormat %s
section baseline
no_agent (1.214 ms) : 1203, 1225
. : milestone, 1214,
iast (3.169 ms) : 3129, 3209
. : milestone, 3169,
iast_FULL (5.988 ms) : 5928, 6049
. : milestone, 5988,
iast_GLOBAL (3.608 ms) : 3553, 3664
. : milestone, 3608,
profiling (2.119 ms) : 2100, 2138
. : milestone, 2119,
tracing (1.803 ms) : 1789, 1818
. : milestone, 1803,
section candidate
no_agent (1.212 ms) : 1200, 1224
. : milestone, 1212,
iast (3.251 ms) : 3213, 3288
. : milestone, 3251,
iast_FULL (5.781 ms) : 5723, 5838
. : milestone, 5781,
iast_GLOBAL (3.659 ms) : 3602, 3716
. : milestone, 3659,
profiling (1.966 ms) : 1948, 1985
. : milestone, 1966,
tracing (1.822 ms) : 1807, 1837
. : milestone, 1822,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~ba9e98f494, baseline=1.57.0-SNAPSHOT~296ecfba9e
dateFormat X
axisFormat %s
section baseline
no_agent (17.51 ms) : 17330, 17690
. : milestone, 17510,
appsec (18.731 ms) : 18540, 18922
. : milestone, 18731,
code_origins (17.782 ms) : 17604, 17959
. : milestone, 17782,
iast (17.883 ms) : 17703, 18063
. : milestone, 17883,
profiling (18.592 ms) : 18406, 18777
. : milestone, 18592,
tracing (18.041 ms) : 17861, 18222
. : milestone, 18041,
section candidate
no_agent (19.033 ms) : 18835, 19231
. : milestone, 19033,
appsec (18.596 ms) : 18406, 18787
. : milestone, 18596,
code_origins (17.758 ms) : 17581, 17935
. : milestone, 17758,
iast (17.986 ms) : 17806, 18166
. : milestone, 17986,
profiling (18.672 ms) : 18484, 18861
. : milestone, 18672,
tracing (17.684 ms) : 17509, 17860
. : milestone, 17684,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~ba9e98f494, baseline=1.57.0-SNAPSHOT~296ecfba9e
dateFormat X
axisFormat %s
section baseline
no_agent (15.46 s) : 15460000, 15460000
. : milestone, 15460000,
appsec (14.611 s) : 14611000, 14611000
. : milestone, 14611000,
iast (18.377 s) : 18377000, 18377000
. : milestone, 18377000,
iast_GLOBAL (18.012 s) : 18012000, 18012000
. : milestone, 18012000,
profiling (14.731 s) : 14731000, 14731000
. : milestone, 14731000,
tracing (15.016 s) : 15016000, 15016000
. : milestone, 15016000,
section candidate
no_agent (15.016 s) : 15016000, 15016000
. : milestone, 15016000,
appsec (14.62 s) : 14620000, 14620000
. : milestone, 14620000,
iast (17.99 s) : 17990000, 17990000
. : milestone, 17990000,
iast_GLOBAL (17.825 s) : 17825000, 17825000
. : milestone, 17825000,
profiling (14.527 s) : 14527000, 14527000
. : milestone, 14527000,
tracing (14.726 s) : 14726000, 14726000
. : milestone, 14726000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~ba9e98f494, baseline=1.57.0-SNAPSHOT~296ecfba9e
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (3.642 ms) : 3428, 3856
. : milestone, 3642,
iast (2.214 ms) : 2149, 2279
. : milestone, 2214,
iast_GLOBAL (2.263 ms) : 2197, 2328
. : milestone, 2263,
profiling (2.098 ms) : 2044, 2153
. : milestone, 2098,
tracing (2.04 ms) : 1988, 2092
. : milestone, 2040,
section candidate
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (3.703 ms) : 3483, 3922
. : milestone, 3703,
iast (2.211 ms) : 2146, 2276
. : milestone, 2211,
iast_GLOBAL (2.268 ms) : 2202, 2334
. : milestone, 2268,
profiling (2.104 ms) : 2049, 2159
. : milestone, 2104,
tracing (2.051 ms) : 1999, 2102
. : milestone, 2051,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Introduced support for combining user-provided Couchbase
RequestTracerwith Datadog'sDataDogRequestTracer, allowing both tracers to operate simultaneouslyAdded
DelegatingRequestTracerthat forwards tracing calls to two tracers:DatadogRequestTracerthe application's custom tracerDelegatingRequestSpanthat mirrors span operations (attributes, events, end(), etc.) to both underlying spansNew instrumentation advice that wraps any user-supplied tracer into this delegating tracer automatically
If the application does not configure a custom tracer, Datadog continues to trace Couchbase operations exactly as before
If the application does configure its own tracer, both tracers now run side-by-side without interfering with each other
Motivation
Сustomer reported that they are using a custom Couchbase
RequestTracerin their applicationBecause Couchbase only allows one tracer to be registered, Datadog’s tracer was being replaced by the custom one. As a result, Couchbase operations were not showing up in the Datadog dashboard at all
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]