-
Notifications
You must be signed in to change notification settings - Fork 319
Don't run spotless on check jobs, it's already run as part of the spotless job #10155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~a4c915e15b, baseline=1.57.0-SNAPSHOT~552ae2be7d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.082 s) : 0, 1082173
Total [baseline] (10.908 s) : 0, 10907666
Agent [candidate] (1.083 s) : 0, 1082543
Total [candidate] (10.813 s) : 0, 10813185
section appsec
Agent [baseline] (1.28 s) : 0, 1279963
Total [baseline] (10.949 s) : 0, 10949111
Agent [candidate] (1.276 s) : 0, 1275545
Total [candidate] (11.093 s) : 0, 11093471
section iast
Agent [baseline] (1.224 s) : 0, 1223944
Total [baseline] (11.161 s) : 0, 11160519
Agent [candidate] (1.241 s) : 0, 1241447
Total [candidate] (11.244 s) : 0, 11244282
section profiling
Agent [baseline] (1.204 s) : 0, 1204458
Total [baseline] (10.978 s) : 0, 10977700
Agent [candidate] (1.205 s) : 0, 1205445
Total [candidate] (11.028 s) : 0, 11028140
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~a4c915e15b, baseline=1.57.0-SNAPSHOT~552ae2be7d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (649.716 ms) : 0, 649716
BytebuddyAgent [candidate] (649.611 ms) : 0, 649611
GlobalTracer [baseline] (281.867 ms) : 0, 281867
GlobalTracer [candidate] (281.727 ms) : 0, 281727
AppSec [baseline] (32.371 ms) : 0, 32371
AppSec [candidate] (32.579 ms) : 0, 32579
Debugger [baseline] (68.007 ms) : 0, 68007
Debugger [candidate] (68.282 ms) : 0, 68282
Remote Config [baseline] (662.602 µs) : 0, 663
Remote Config [candidate] (676.427 µs) : 0, 676
Telemetry [baseline] (9.032 ms) : 0, 9032
Telemetry [candidate] (9.133 ms) : 0, 9133
Flare Poller [baseline] (3.748 ms) : 0, 3748
Flare Poller [candidate] (3.815 ms) : 0, 3815
section appsec
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (699.258 ms) : 0, 699258
BytebuddyAgent [candidate] (696.16 ms) : 0, 696160
GlobalTracer [baseline] (262.068 ms) : 0, 262068
GlobalTracer [candidate] (261.024 ms) : 0, 261024
AppSec [baseline] (175.977 ms) : 0, 175977
AppSec [candidate] (176.058 ms) : 0, 176058
Debugger [baseline] (67.046 ms) : 0, 67046
Debugger [candidate] (66.875 ms) : 0, 66875
Remote Config [baseline] (685.658 µs) : 0, 686
Remote Config [candidate] (681.219 µs) : 0, 681
Telemetry [baseline] (9.071 ms) : 0, 9071
Telemetry [candidate] (9.046 ms) : 0, 9046
Flare Poller [baseline] (3.973 ms) : 0, 3973
Flare Poller [candidate] (3.78 ms) : 0, 3780
IAST [baseline] (24.739 ms) : 0, 24739
IAST [candidate] (24.897 ms) : 0, 24897
section iast
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (791.654 ms) : 0, 791654
BytebuddyAgent [candidate] (804.186 ms) : 0, 804186
GlobalTracer [baseline] (255.801 ms) : 0, 255801
GlobalTracer [candidate] (259.289 ms) : 0, 259289
AppSec [baseline] (35.472 ms) : 0, 35472
AppSec [candidate] (34.563 ms) : 0, 34563
Debugger [baseline] (64.996 ms) : 0, 64996
Debugger [candidate] (66.55 ms) : 0, 66550
Remote Config [baseline] (547.474 µs) : 0, 547
Remote Config [candidate] (556.856 µs) : 0, 557
Telemetry [baseline] (8.396 ms) : 0, 8396
Telemetry [candidate] (8.508 ms) : 0, 8508
Flare Poller [baseline] (3.495 ms) : 0, 3495
Flare Poller [candidate] (3.504 ms) : 0, 3504
IAST [baseline] (26.818 ms) : 0, 26818
IAST [candidate] (27.33 ms) : 0, 27330
section profiling
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (701.693 ms) : 0, 701693
BytebuddyAgent [candidate] (702.152 ms) : 0, 702152
GlobalTracer [baseline] (221.058 ms) : 0, 221058
GlobalTracer [candidate] (221.288 ms) : 0, 221288
AppSec [baseline] (31.939 ms) : 0, 31939
AppSec [candidate] (32.16 ms) : 0, 32160
Debugger [baseline] (67.843 ms) : 0, 67843
Debugger [candidate] (68.507 ms) : 0, 68507
Remote Config [baseline] (654.235 µs) : 0, 654
Remote Config [candidate] (660.803 µs) : 0, 661
Telemetry [baseline] (9.041 ms) : 0, 9041
Telemetry [candidate] (9.053 ms) : 0, 9053
Flare Poller [baseline] (3.75 ms) : 0, 3750
Flare Poller [candidate] (3.713 ms) : 0, 3713
ProfilingAgent [baseline] (97.37 ms) : 0, 97370
ProfilingAgent [candidate] (96.87 ms) : 0, 96870
Profiling [baseline] (97.969 ms) : 0, 97969
Profiling [candidate] (97.436 ms) : 0, 97436
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~a4c915e15b, baseline=1.57.0-SNAPSHOT~552ae2be7d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1087619
Total [baseline] (8.785 s) : 0, 8784947
Agent [candidate] (1.081 s) : 0, 1080676
Total [candidate] (8.787 s) : 0, 8786547
section iast
Agent [baseline] (1.222 s) : 0, 1222132
Total [baseline] (9.377 s) : 0, 9376670
Agent [candidate] (1.246 s) : 0, 1245525
Total [candidate] (9.407 s) : 0, 9406915
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~a4c915e15b, baseline=1.57.0-SNAPSHOT~552ae2be7d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (653.224 ms) : 0, 653224
BytebuddyAgent [candidate] (648.332 ms) : 0, 648332
GlobalTracer [baseline] (283.654 ms) : 0, 283654
GlobalTracer [candidate] (281.908 ms) : 0, 281908
AppSec [baseline] (32.585 ms) : 0, 32585
AppSec [candidate] (32.406 ms) : 0, 32406
Debugger [baseline] (67.814 ms) : 0, 67814
Debugger [candidate] (67.943 ms) : 0, 67943
Remote Config [baseline] (660.181 µs) : 0, 660
Remote Config [candidate] (646.194 µs) : 0, 646
Telemetry [baseline] (9.026 ms) : 0, 9026
Telemetry [candidate] (9.009 ms) : 0, 9009
Flare Poller [baseline] (3.745 ms) : 0, 3745
Flare Poller [candidate] (3.706 ms) : 0, 3706
section iast
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (791.025 ms) : 0, 791025
BytebuddyAgent [candidate] (807.547 ms) : 0, 807547
GlobalTracer [baseline] (255.648 ms) : 0, 255648
GlobalTracer [candidate] (260.599 ms) : 0, 260599
AppSec [baseline] (34.388 ms) : 0, 34388
AppSec [candidate] (34.352 ms) : 0, 34352
Debugger [baseline] (65.003 ms) : 0, 65003
Debugger [candidate] (66.125 ms) : 0, 66125
Remote Config [baseline] (573.153 µs) : 0, 573
Remote Config [candidate] (593.47 µs) : 0, 593
Telemetry [baseline] (8.423 ms) : 0, 8423
Telemetry [candidate] (8.372 ms) : 0, 8372
Flare Poller [baseline] (3.452 ms) : 0, 3452
Flare Poller [candidate] (3.426 ms) : 0, 3426
IAST [baseline] (26.878 ms) : 0, 26878
IAST [candidate] (27.368 ms) : 0, 27368
LoadParameters
See matching parameters
SummaryFound 6 performance improvements and 1 performance regressions! Performance is the same for 13 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~a4c915e15b, baseline=1.57.0-SNAPSHOT~552ae2be7d
dateFormat X
axisFormat %s
section baseline
no_agent (1.217 ms) : 1205, 1230
. : milestone, 1217,
iast (3.223 ms) : 3180, 3265
. : milestone, 3223,
iast_FULL (5.616 ms) : 5560, 5673
. : milestone, 5616,
iast_GLOBAL (3.497 ms) : 3442, 3551
. : milestone, 3497,
profiling (2.079 ms) : 2061, 2097
. : milestone, 2079,
tracing (1.803 ms) : 1788, 1819
. : milestone, 1803,
section candidate
no_agent (1.217 ms) : 1205, 1229
. : milestone, 1217,
iast (3.059 ms) : 3019, 3098
. : milestone, 3059,
iast_FULL (5.812 ms) : 5754, 5870
. : milestone, 5812,
iast_GLOBAL (3.639 ms) : 3585, 3693
. : milestone, 3639,
profiling (2.184 ms) : 2164, 2203
. : milestone, 2184,
tracing (1.836 ms) : 1821, 1852
. : milestone, 1836,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~a4c915e15b, baseline=1.57.0-SNAPSHOT~552ae2be7d
dateFormat X
axisFormat %s
section baseline
no_agent (18.269 ms) : 18079, 18460
. : milestone, 18269,
appsec (18.878 ms) : 18685, 19072
. : milestone, 18878,
code_origins (17.689 ms) : 17516, 17862
. : milestone, 17689,
iast (18.005 ms) : 17823, 18188
. : milestone, 18005,
profiling (19.64 ms) : 19435, 19845
. : milestone, 19640,
tracing (18.761 ms) : 18571, 18952
. : milestone, 18761,
section candidate
no_agent (18.389 ms) : 18198, 18580
. : milestone, 18389,
appsec (18.599 ms) : 18406, 18791
. : milestone, 18599,
code_origins (18.045 ms) : 17868, 18223
. : milestone, 18045,
iast (17.851 ms) : 17673, 18030
. : milestone, 17851,
profiling (18.809 ms) : 18623, 18994
. : milestone, 18809,
tracing (17.607 ms) : 17432, 17782
. : milestone, 17607,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~a4c915e15b, baseline=1.57.0-SNAPSHOT~552ae2be7d
dateFormat X
axisFormat %s
section baseline
no_agent (15.101 s) : 15101000, 15101000
. : milestone, 15101000,
appsec (14.636 s) : 14636000, 14636000
. : milestone, 14636000,
iast (18.389 s) : 18389000, 18389000
. : milestone, 18389000,
iast_GLOBAL (17.826 s) : 17826000, 17826000
. : milestone, 17826000,
profiling (14.633 s) : 14633000, 14633000
. : milestone, 14633000,
tracing (14.674 s) : 14674000, 14674000
. : milestone, 14674000,
section candidate
no_agent (15.267 s) : 15267000, 15267000
. : milestone, 15267000,
appsec (14.745 s) : 14745000, 14745000
. : milestone, 14745000,
iast (18.133 s) : 18133000, 18133000
. : milestone, 18133000,
iast_GLOBAL (17.813 s) : 17813000, 17813000
. : milestone, 17813000,
profiling (15.079 s) : 15079000, 15079000
. : milestone, 15079000,
tracing (14.522 s) : 14522000, 14522000
. : milestone, 14522000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~a4c915e15b, baseline=1.57.0-SNAPSHOT~552ae2be7d
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (3.64 ms) : 3426, 3854
. : milestone, 3640,
iast (2.209 ms) : 2146, 2273
. : milestone, 2209,
iast_GLOBAL (2.263 ms) : 2198, 2328
. : milestone, 2263,
profiling (2.078 ms) : 2026, 2130
. : milestone, 2078,
tracing (2.049 ms) : 1998, 2099
. : milestone, 2049,
section candidate
no_agent (1.482 ms) : 1471, 1494
. : milestone, 1482,
appsec (3.662 ms) : 3448, 3876
. : milestone, 3662,
iast (2.223 ms) : 2158, 2288
. : milestone, 2223,
iast_GLOBAL (2.264 ms) : 2200, 2329
. : milestone, 2264,
profiling (2.073 ms) : 2021, 2125
. : milestone, 2073,
tracing (2.054 ms) : 2003, 2105
. : milestone, 2054,
|
|
Just curious, about "Note the -PskipSpotless thus becomes useless." - how about other jobs, like test_smoke, test_base, ...? |
916c68d to
b0b8398
Compare
b0b8398 to
a4c915e
Compare
What Does This Do
Exclude
spotlessChecktask, on check jobs, because it's already runned as part of the spotless job.Note the
-PskipSpotlessthus becomes useless.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]