-
Notifications
You must be signed in to change notification settings - Fork 319
Simplify tasks partitioning UX #10158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
d2a0af6 to
12e4fff
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~b551b2efaa, baseline=1.57.0-SNAPSHOT~ce2b2fe37e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.082 s) : 0, 1082107
Total [baseline] (10.901 s) : 0, 10901415
Agent [candidate] (1.083 s) : 0, 1082602
Total [candidate] (10.847 s) : 0, 10846582
section appsec
Agent [baseline] (1.263 s) : 0, 1262654
Total [baseline] (11.035 s) : 0, 11035485
Agent [candidate] (1.279 s) : 0, 1278572
Total [candidate] (11.073 s) : 0, 11073047
section iast
Agent [baseline] (1.221 s) : 0, 1221179
Total [baseline] (11.302 s) : 0, 11301792
Agent [candidate] (1.22 s) : 0, 1220037
Total [candidate] (11.247 s) : 0, 11247429
section profiling
Agent [baseline] (1.206 s) : 0, 1205542
Total [baseline] (10.909 s) : 0, 10909172
Agent [candidate] (1.204 s) : 0, 1203723
Total [candidate] (10.97 s) : 0, 10969905
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~b551b2efaa, baseline=1.57.0-SNAPSHOT~ce2b2fe37e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (649.673 ms) : 0, 649673
BytebuddyAgent [candidate] (648.662 ms) : 0, 648662
GlobalTracer [baseline] (281.877 ms) : 0, 281877
GlobalTracer [candidate] (282.891 ms) : 0, 282891
AppSec [baseline] (32.405 ms) : 0, 32405
AppSec [candidate] (32.481 ms) : 0, 32481
Debugger [baseline] (68.025 ms) : 0, 68025
Debugger [candidate] (68.466 ms) : 0, 68466
Remote Config [baseline] (636.654 µs) : 0, 637
Remote Config [candidate] (631.36 µs) : 0, 631
Telemetry [baseline] (9.038 ms) : 0, 9038
Telemetry [candidate] (9.076 ms) : 0, 9076
Flare Poller [baseline] (3.741 ms) : 0, 3741
Flare Poller [candidate] (3.753 ms) : 0, 3753
section appsec
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (687.5 ms) : 0, 687500
BytebuddyAgent [candidate] (698.249 ms) : 0, 698249
GlobalTracer [baseline] (258.059 ms) : 0, 258059
GlobalTracer [candidate] (262.025 ms) : 0, 262025
AppSec [baseline] (174.768 ms) : 0, 174768
AppSec [candidate] (175.487 ms) : 0, 175487
Debugger [baseline] (67.375 ms) : 0, 67375
Debugger [candidate] (67.109 ms) : 0, 67109
Remote Config [baseline] (733.973 µs) : 0, 734
Remote Config [candidate] (712.663 µs) : 0, 713
Telemetry [baseline] (9.1 ms) : 0, 9100
Telemetry [candidate] (9.097 ms) : 0, 9097
Flare Poller [baseline] (3.991 ms) : 0, 3991
Flare Poller [candidate] (3.847 ms) : 0, 3847
IAST [baseline] (24.453 ms) : 0, 24453
IAST [candidate] (25.006 ms) : 0, 25006
section iast
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (789.907 ms) : 0, 789907
BytebuddyAgent [candidate] (788.955 ms) : 0, 788955
GlobalTracer [baseline] (255.153 ms) : 0, 255153
GlobalTracer [candidate] (255.423 ms) : 0, 255423
AppSec [baseline] (35.033 ms) : 0, 35033
AppSec [candidate] (35.279 ms) : 0, 35279
Debugger [baseline] (65.153 ms) : 0, 65153
Debugger [candidate] (64.723 ms) : 0, 64723
Remote Config [baseline] (548.219 µs) : 0, 548
Remote Config [candidate] (556.02 µs) : 0, 556
Telemetry [baseline] (8.416 ms) : 0, 8416
Telemetry [candidate] (8.457 ms) : 0, 8457
Flare Poller [baseline] (3.493 ms) : 0, 3493
Flare Poller [candidate] (3.487 ms) : 0, 3487
IAST [baseline] (26.95 ms) : 0, 26950
IAST [candidate] (26.673 ms) : 0, 26673
section profiling
ProfilingAgent [baseline] (96.614 ms) : 0, 96614
ProfilingAgent [candidate] (96.596 ms) : 0, 96596
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (701.971 ms) : 0, 701971
BytebuddyAgent [candidate] (701.014 ms) : 0, 701014
GlobalTracer [baseline] (221.584 ms) : 0, 221584
GlobalTracer [candidate] (221.333 ms) : 0, 221333
AppSec [baseline] (32.198 ms) : 0, 32198
AppSec [candidate] (32.073 ms) : 0, 32073
Debugger [baseline] (68.421 ms) : 0, 68421
Debugger [candidate] (68.034 ms) : 0, 68034
Remote Config [baseline] (663.405 µs) : 0, 663
Remote Config [candidate] (627.352 µs) : 0, 627
Telemetry [baseline] (9.091 ms) : 0, 9091
Telemetry [candidate] (9.063 ms) : 0, 9063
Flare Poller [baseline] (3.828 ms) : 0, 3828
Flare Poller [candidate] (3.803 ms) : 0, 3803
Profiling [baseline] (97.195 ms) : 0, 97195
Profiling [candidate] (97.157 ms) : 0, 97157
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~b551b2efaa, baseline=1.57.0-SNAPSHOT~ce2b2fe37e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1079664
Total [baseline] (8.77 s) : 0, 8770416
Agent [candidate] (1.078 s) : 0, 1078333
Total [candidate] (8.781 s) : 0, 8781060
section iast
Agent [baseline] (1.221 s) : 0, 1221398
Total [baseline] (9.409 s) : 0, 9408850
Agent [candidate] (1.222 s) : 0, 1221560
Total [candidate] (9.372 s) : 0, 9372476
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~b551b2efaa, baseline=1.57.0-SNAPSHOT~ce2b2fe37e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (648.273 ms) : 0, 648273
BytebuddyAgent [candidate] (647.323 ms) : 0, 647323
GlobalTracer [baseline] (281.701 ms) : 0, 281701
GlobalTracer [candidate] (281.415 ms) : 0, 281415
AppSec [baseline] (32.336 ms) : 0, 32336
AppSec [candidate] (32.443 ms) : 0, 32443
Debugger [baseline] (67.114 ms) : 0, 67114
Debugger [candidate] (67.111 ms) : 0, 67111
Remote Config [baseline] (657.144 µs) : 0, 657
Remote Config [candidate] (626.917 µs) : 0, 627
Telemetry [baseline] (9.021 ms) : 0, 9021
Telemetry [candidate] (8.974 ms) : 0, 8974
Flare Poller [baseline] (3.798 ms) : 0, 3798
Flare Poller [candidate] (3.754 ms) : 0, 3754
section iast
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (789.923 ms) : 0, 789923
BytebuddyAgent [candidate] (788.793 ms) : 0, 788793
GlobalTracer [baseline] (255.235 ms) : 0, 255235
GlobalTracer [candidate] (256.46 ms) : 0, 256460
AppSec [baseline] (32.002 ms) : 0, 32002
AppSec [candidate] (34.765 ms) : 0, 34765
Debugger [baseline] (68.239 ms) : 0, 68239
Debugger [candidate] (65.28 ms) : 0, 65280
Remote Config [baseline] (552.692 µs) : 0, 553
Remote Config [candidate] (549.629 µs) : 0, 550
Telemetry [baseline] (8.477 ms) : 0, 8477
Telemetry [candidate] (8.414 ms) : 0, 8414
Flare Poller [baseline] (3.497 ms) : 0, 3497
Flare Poller [candidate] (3.476 ms) : 0, 3476
IAST [baseline] (26.853 ms) : 0, 26853
IAST [candidate] (27.101 ms) : 0, 27101
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 3 performance regressions! Performance is the same for 15 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~b551b2efaa, baseline=1.57.0-SNAPSHOT~ce2b2fe37e
dateFormat X
axisFormat %s
section baseline
no_agent (19.488 ms) : 19283, 19692
. : milestone, 19488,
appsec (18.927 ms) : 18735, 19119
. : milestone, 18927,
code_origins (18.053 ms) : 17875, 18232
. : milestone, 18053,
iast (17.509 ms) : 17337, 17681
. : milestone, 17509,
profiling (18.831 ms) : 18643, 19019
. : milestone, 18831,
tracing (17.784 ms) : 17602, 17965
. : milestone, 17784,
section candidate
no_agent (18.512 ms) : 18322, 18703
. : milestone, 18512,
appsec (18.699 ms) : 18510, 18889
. : milestone, 18699,
code_origins (18.061 ms) : 17882, 18239
. : milestone, 18061,
iast (17.68 ms) : 17505, 17855
. : milestone, 17680,
profiling (19.935 ms) : 19731, 20139
. : milestone, 19935,
tracing (18.0 ms) : 17821, 18178
. : milestone, 18000,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~b551b2efaa, baseline=1.57.0-SNAPSHOT~ce2b2fe37e
dateFormat X
axisFormat %s
section baseline
no_agent (1.197 ms) : 1185, 1209
. : milestone, 1197,
iast (3.288 ms) : 3247, 3329
. : milestone, 3288,
iast_FULL (5.523 ms) : 5469, 5577
. : milestone, 5523,
iast_GLOBAL (3.72 ms) : 3661, 3780
. : milestone, 3720,
profiling (1.949 ms) : 1932, 1965
. : milestone, 1949,
tracing (1.843 ms) : 1827, 1859
. : milestone, 1843,
section candidate
no_agent (1.199 ms) : 1188, 1211
. : milestone, 1199,
iast (3.26 ms) : 3219, 3302
. : milestone, 3260,
iast_FULL (5.71 ms) : 5653, 5766
. : milestone, 5710,
iast_GLOBAL (3.508 ms) : 3454, 3562
. : milestone, 3508,
profiling (2.066 ms) : 2047, 2084
. : milestone, 2066,
tracing (1.796 ms) : 1781, 1811
. : milestone, 1796,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~b551b2efaa, baseline=1.57.0-SNAPSHOT~ce2b2fe37e
dateFormat X
axisFormat %s
section baseline
no_agent (14.802 s) : 14802000, 14802000
. : milestone, 14802000,
appsec (15.026 s) : 15026000, 15026000
. : milestone, 15026000,
iast (18.408 s) : 18408000, 18408000
. : milestone, 18408000,
iast_GLOBAL (17.877 s) : 17877000, 17877000
. : milestone, 17877000,
profiling (14.703 s) : 14703000, 14703000
. : milestone, 14703000,
tracing (14.668 s) : 14668000, 14668000
. : milestone, 14668000,
section candidate
no_agent (14.996 s) : 14996000, 14996000
. : milestone, 14996000,
appsec (14.97 s) : 14970000, 14970000
. : milestone, 14970000,
iast (18.0 s) : 18000000, 18000000
. : milestone, 18000000,
iast_GLOBAL (17.781 s) : 17781000, 17781000
. : milestone, 17781000,
profiling (14.537 s) : 14537000, 14537000
. : milestone, 14537000,
tracing (14.724 s) : 14724000, 14724000
. : milestone, 14724000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~b551b2efaa, baseline=1.57.0-SNAPSHOT~ce2b2fe37e
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1488
. : milestone, 1476,
appsec (3.742 ms) : 3517, 3967
. : milestone, 3742,
iast (2.221 ms) : 2157, 2285
. : milestone, 2221,
iast_GLOBAL (2.27 ms) : 2205, 2335
. : milestone, 2270,
profiling (2.082 ms) : 2030, 2135
. : milestone, 2082,
tracing (2.07 ms) : 2018, 2121
. : milestone, 2070,
section candidate
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.661 ms) : 3446, 3876
. : milestone, 3661,
iast (2.234 ms) : 2169, 2300
. : milestone, 2234,
iast_GLOBAL (2.273 ms) : 2207, 2338
. : milestone, 2273,
profiling (2.468 ms) : 2255, 2682
. : milestone, 2468,
tracing (2.06 ms) : 2009, 2111
. : milestone, 2060,
|
| script: | ||
| - export SKIP_BUILDSCAN="true" | ||
| - ./gradlew --version | ||
| - ./gradlew :runMuzzle -PtaskPartitionCount=$NORMALIZED_NODE_TOTAL -PtaskPartition=$NORMALIZED_NODE_INDEX $GRADLE_ARGS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are some env that now are no more referenced. should they be cleaned up as well?
What Does This Do
Instead of passing two property to specify a partition or a slot, this PR allows to pass a fraction as a single property named
slote.g. :This will also enable to reproduce locally, e.g. when a CI job indicates
test_base: [8, 3/4], it can be reproduced easily:test_base->:baseTest,8->-PtestJvm=8,3/4->-Pslot=3/4.Also added some info logging.
The ci config had the flag out of order, total was first.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]