-
Notifications
You must be signed in to change notification settings - Fork 320
Set /dd-smoke-tests/play-*/ ownership #10159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~5c3040e66f, baseline=1.57.0-SNAPSHOT~896c0120ac
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084390
Total [baseline] (8.753 s) : 0, 8752851
Agent [candidate] (1.087 s) : 0, 1086746
Total [candidate] (8.749 s) : 0, 8748775
section iast
Agent [baseline] (1.217 s) : 0, 1216558
Total [baseline] (9.401 s) : 0, 9401457
Agent [candidate] (1.227 s) : 0, 1227395
Total [candidate] (9.499 s) : 0, 9499027
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~5c3040e66f, baseline=1.57.0-SNAPSHOT~896c0120ac
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (651.829 ms) : 0, 651829
BytebuddyAgent [candidate] (653.017 ms) : 0, 653017
GlobalTracer [baseline] (282.638 ms) : 0, 282638
GlobalTracer [candidate] (283.219 ms) : 0, 283219
AppSec [baseline] (32.51 ms) : 0, 32510
AppSec [candidate] (32.616 ms) : 0, 32616
Debugger [baseline] (66.453 ms) : 0, 66453
Debugger [candidate] (67.466 ms) : 0, 67466
Remote Config [baseline] (654.598 µs) : 0, 655
Remote Config [candidate] (663.565 µs) : 0, 664
Telemetry [baseline] (8.986 ms) : 0, 8986
Telemetry [candidate] (9.092 ms) : 0, 9092
Flare Poller [baseline] (4.447 ms) : 0, 4447
Flare Poller [candidate] (3.82 ms) : 0, 3820
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (786.994 ms) : 0, 786994
BytebuddyAgent [candidate] (794.682 ms) : 0, 794682
GlobalTracer [baseline] (254.371 ms) : 0, 254371
GlobalTracer [candidate] (256.574 ms) : 0, 256574
IAST [baseline] (26.845 ms) : 0, 26845
IAST [candidate] (27.075 ms) : 0, 27075
AppSec [baseline] (34.451 ms) : 0, 34451
AppSec [candidate] (35.457 ms) : 0, 35457
Debugger [baseline] (65.089 ms) : 0, 65089
Debugger [candidate] (64.453 ms) : 0, 64453
Remote Config [baseline] (534.123 µs) : 0, 534
Remote Config [candidate] (552.524 µs) : 0, 553
Telemetry [baseline] (8.367 ms) : 0, 8367
Telemetry [candidate] (8.434 ms) : 0, 8434
Flare Poller [baseline] (3.436 ms) : 0, 3436
Flare Poller [candidate] (3.425 ms) : 0, 3425
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~5c3040e66f, baseline=1.57.0-SNAPSHOT~896c0120ac
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081107
Total [baseline] (10.773 s) : 0, 10772711
Agent [candidate] (1.079 s) : 0, 1079385
Total [candidate] (10.738 s) : 0, 10738244
section appsec
Agent [baseline] (1.262 s) : 0, 1261845
Total [baseline] (11.105 s) : 0, 11105201
Agent [candidate] (1.263 s) : 0, 1263142
Total [candidate] (11.117 s) : 0, 11116631
section iast
Agent [baseline] (1.222 s) : 0, 1221692
Total [baseline] (11.058 s) : 0, 11058287
Agent [candidate] (1.231 s) : 0, 1231055
Total [candidate] (11.226 s) : 0, 11226060
section profiling
Agent [baseline] (1.204 s) : 0, 1204245
Total [baseline] (10.982 s) : 0, 10981531
Agent [candidate] (1.222 s) : 0, 1221662
Total [candidate] (11.143 s) : 0, 11142980
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~5c3040e66f, baseline=1.57.0-SNAPSHOT~896c0120ac
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (648.219 ms) : 0, 648219
BytebuddyAgent [candidate] (647.766 ms) : 0, 647766
GlobalTracer [baseline] (281.5 ms) : 0, 281500
GlobalTracer [candidate] (281.261 ms) : 0, 281261
AppSec [baseline] (32.488 ms) : 0, 32488
AppSec [candidate] (32.379 ms) : 0, 32379
Debugger [baseline] (68.759 ms) : 0, 68759
Debugger [candidate] (67.929 ms) : 0, 67929
Remote Config [baseline] (661.398 µs) : 0, 661
Remote Config [candidate] (648.698 µs) : 0, 649
Telemetry [baseline] (9.067 ms) : 0, 9067
Telemetry [candidate] (8.99 ms) : 0, 8990
Flare Poller [baseline] (3.757 ms) : 0, 3757
Flare Poller [candidate] (3.753 ms) : 0, 3753
section appsec
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (688.142 ms) : 0, 688142
BytebuddyAgent [candidate] (688.248 ms) : 0, 688248
GlobalTracer [baseline] (258.356 ms) : 0, 258356
GlobalTracer [candidate] (258.984 ms) : 0, 258984
IAST [baseline] (24.414 ms) : 0, 24414
IAST [candidate] (24.474 ms) : 0, 24474
AppSec [baseline] (174.794 ms) : 0, 174794
AppSec [candidate] (174.269 ms) : 0, 174269
Debugger [baseline] (65.918 ms) : 0, 65918
Debugger [candidate] (66.899 ms) : 0, 66899
Remote Config [baseline] (702.229 µs) : 0, 702
Remote Config [candidate] (698.587 µs) : 0, 699
Telemetry [baseline] (9.009 ms) : 0, 9009
Telemetry [candidate] (8.995 ms) : 0, 8995
Flare Poller [baseline] (3.911 ms) : 0, 3911
Flare Poller [candidate] (3.867 ms) : 0, 3867
section iast
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (789.946 ms) : 0, 789946
BytebuddyAgent [candidate] (796.179 ms) : 0, 796179
GlobalTracer [baseline] (255.332 ms) : 0, 255332
GlobalTracer [candidate] (256.743 ms) : 0, 256743
IAST [baseline] (26.892 ms) : 0, 26892
IAST [candidate] (27.117 ms) : 0, 27117
AppSec [baseline] (33.58 ms) : 0, 33580
AppSec [candidate] (35.605 ms) : 0, 35605
Debugger [baseline] (66.97 ms) : 0, 66970
Debugger [candidate] (66.191 ms) : 0, 66191
Remote Config [baseline] (562.218 µs) : 0, 562
Remote Config [candidate] (573.427 µs) : 0, 573
Telemetry [baseline] (8.401 ms) : 0, 8401
Telemetry [candidate] (8.488 ms) : 0, 8488
Flare Poller [baseline] (3.471 ms) : 0, 3471
Flare Poller [candidate] (3.495 ms) : 0, 3495
section profiling
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (701.406 ms) : 0, 701406
BytebuddyAgent [candidate] (712.02 ms) : 0, 712020
GlobalTracer [baseline] (220.409 ms) : 0, 220409
GlobalTracer [candidate] (223.496 ms) : 0, 223496
AppSec [baseline] (32.405 ms) : 0, 32405
AppSec [candidate] (32.954 ms) : 0, 32954
Debugger [baseline] (68.34 ms) : 0, 68340
Debugger [candidate] (69.048 ms) : 0, 69048
Remote Config [baseline] (641.199 µs) : 0, 641
Remote Config [candidate] (668.946 µs) : 0, 669
Telemetry [baseline] (8.921 ms) : 0, 8921
Telemetry [candidate] (9.044 ms) : 0, 9044
Flare Poller [baseline] (3.79 ms) : 0, 3790
Flare Poller [candidate] (3.833 ms) : 0, 3833
ProfilingAgent [baseline] (97.566 ms) : 0, 97566
ProfilingAgent [candidate] (99.009 ms) : 0, 99009
Profiling [baseline] (98.141 ms) : 0, 98141
Profiling [candidate] (99.591 ms) : 0, 99591
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~5c3040e66f, baseline=1.57.0-SNAPSHOT~896c0120ac
dateFormat X
axisFormat %s
section baseline
no_agent (1.226 ms) : 1214, 1239
. : milestone, 1226,
iast (3.285 ms) : 3239, 3331
. : milestone, 3285,
iast_FULL (6.087 ms) : 6023, 6150
. : milestone, 6087,
iast_GLOBAL (3.688 ms) : 3627, 3749
. : milestone, 3688,
profiling (2.141 ms) : 2121, 2161
. : milestone, 2141,
tracing (1.936 ms) : 1916, 1956
. : milestone, 1936,
section candidate
no_agent (1.224 ms) : 1212, 1236
. : milestone, 1224,
iast (3.148 ms) : 3104, 3191
. : milestone, 3148,
iast_FULL (5.893 ms) : 5835, 5951
. : milestone, 5893,
iast_GLOBAL (3.61 ms) : 3557, 3662
. : milestone, 3610,
profiling (2.041 ms) : 2024, 2059
. : milestone, 2041,
tracing (1.859 ms) : 1844, 1874
. : milestone, 1859,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~5c3040e66f, baseline=1.57.0-SNAPSHOT~896c0120ac
dateFormat X
axisFormat %s
section baseline
no_agent (18.356 ms) : 18167, 18544
. : milestone, 18356,
appsec (18.446 ms) : 18260, 18633
. : milestone, 18446,
code_origins (18.066 ms) : 17879, 18254
. : milestone, 18066,
iast (17.67 ms) : 17491, 17849
. : milestone, 17670,
profiling (19.974 ms) : 19766, 20181
. : milestone, 19974,
tracing (18.329 ms) : 18145, 18512
. : milestone, 18329,
section candidate
no_agent (17.031 ms) : 16861, 17201
. : milestone, 17031,
appsec (18.247 ms) : 18064, 18430
. : milestone, 18247,
code_origins (17.988 ms) : 17810, 18166
. : milestone, 17988,
iast (17.938 ms) : 17756, 18120
. : milestone, 17938,
profiling (19.113 ms) : 18920, 19305
. : milestone, 19113,
tracing (17.806 ms) : 17630, 17981
. : milestone, 17806,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~5c3040e66f, baseline=1.57.0-SNAPSHOT~896c0120ac
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.685 ms) : 3466, 3904
. : milestone, 3685,
iast (2.209 ms) : 2144, 2273
. : milestone, 2209,
iast_GLOBAL (2.245 ms) : 2180, 2309
. : milestone, 2245,
profiling (2.063 ms) : 2011, 2116
. : milestone, 2063,
tracing (2.042 ms) : 1991, 2093
. : milestone, 2042,
section candidate
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.708 ms) : 3487, 3929
. : milestone, 3708,
iast (2.212 ms) : 2148, 2276
. : milestone, 2212,
iast_GLOBAL (2.254 ms) : 2190, 2319
. : milestone, 2254,
profiling (2.069 ms) : 2016, 2123
. : milestone, 2069,
tracing (2.044 ms) : 1993, 2094
. : milestone, 2044,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~5c3040e66f, baseline=1.57.0-SNAPSHOT~896c0120ac
dateFormat X
axisFormat %s
section baseline
no_agent (15.67 s) : 15670000, 15670000
. : milestone, 15670000,
appsec (14.919 s) : 14919000, 14919000
. : milestone, 14919000,
iast (18.011 s) : 18011000, 18011000
. : milestone, 18011000,
iast_GLOBAL (17.917 s) : 17917000, 17917000
. : milestone, 17917000,
profiling (14.562 s) : 14562000, 14562000
. : milestone, 14562000,
tracing (14.666 s) : 14666000, 14666000
. : milestone, 14666000,
section candidate
no_agent (14.878 s) : 14878000, 14878000
. : milestone, 14878000,
appsec (14.694 s) : 14694000, 14694000
. : milestone, 14694000,
iast (18.387 s) : 18387000, 18387000
. : milestone, 18387000,
iast_GLOBAL (17.912 s) : 17912000, 17912000
. : milestone, 17912000,
profiling (14.558 s) : 14558000, 14558000
. : milestone, 14558000,
tracing (14.552 s) : 14552000, 14552000
. : milestone, 14552000,
|
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
.github/CODEOWNERS
Outdated
| * @DataDog/apm-java | ||
|
|
||
| # shared ownership | ||
| /dd-smoke-tests/play-2.6/ @DataDog/asm-java @DataDog/apm-idm-java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 suggestion: I would split controller and test to the related teams.
Similarly, it should be able to apply a pattern (and test it) so it applies to all versions of play framework smoke test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would split controller and test to the related teams,
Do you have more details, I'm not familiar enough with the code base to see how to achieve this.
Similarly, it should be able to apply a pattern (and test it)
done in 5c3040e
What Does This Do
Set @DataDog/asm-java and @DataDog/apm-idm-java as default owners for
/dd-smoke-tests/play-2.6/Motivation
https://dd.slack.com/archives/CFDP7Q5NV/p1765355921166009
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]