Add EVENT_TYPE to the StackTraceEvent #7638

Mariovido · 2024-09-18T10:32:31Z

What Does This Do

This add a field to the StackTraceEvent where we can add the type of the event. That field was specified as optional in the RFC of Exploit Prevention for ASM Libraries. As the implementation before was only for RASP it wasn't needed. Next, we are going to add a new type that will be for IAST and we will need to have this field to identify the EVENT_TYPE.

Motivation

We were missing this optional value

Additional Notes

RFC that contains the event schema --> [RFC] Exploit prevention in the ASM libraries

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APPSEC-11649

pr-commenter · 2024-09-18T10:44:56Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mario.vidal/add_type_stack_trace_event
git_commit_date	1726653524	1726655448
git_commit_sha	`5765052`	`15e88a0`
release_version	1.40.0-SNAPSHOT~5765052e34	1.40.0-SNAPSHOT~15e88a01b7

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1726657738	1726657738
ci_job_id	643272819	643272819
ci_pipeline_id	44574361	44574361
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~15e88a01b7, baseline=1.40.0-SNAPSHOT~5765052e34

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068746
Total [baseline] (8.591 s) : 0, 8590832
Agent [candidate] (1.072 s) : 0, 1071757
Total [candidate] (8.594 s) : 0, 8593740
section iast
Agent [baseline] (1.191 s) : 0, 1190776
Total [baseline] (9.023 s) : 0, 9022646
Agent [candidate] (1.201 s) : 0, 1200564
Total [candidate] (9.043 s) : 0, 9043042
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.189 s) : 0, 1188818
Total [baseline] (9.001 s) : 0, 9001014
Agent [candidate] (1.193 s) : 0, 1192931
Total [candidate] (9.016 s) : 0, 9016048
section iast_TELEMETRY_OFF
Agent [baseline] (1.196 s) : 0, 1196422
Total [baseline] (9.062 s) : 0, 9062237
Agent [candidate] (1.188 s) : 0, 1187557
Total [candidate] (9.039 s) : 0, 9039002

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.069 s	-
Agent	iast	1.191 s	122.03 ms (11.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.189 s	120.072 ms (11.2%)
Agent	iast_TELEMETRY_OFF	1.196 s	127.677 ms (11.9%)
Total	tracing	8.591 s	-
Total	iast	9.023 s	431.815 ms (5.0%)
Total	iast_HARDCODED_SECRET_DISABLED	9.001 s	410.182 ms (4.8%)
Total	iast_TELEMETRY_OFF	9.062 s	471.405 ms (5.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.072 s	-
Agent	iast	1.201 s	128.806 ms (12.0%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.193 s	121.174 ms (11.3%)
Agent	iast_TELEMETRY_OFF	1.188 s	115.799 ms (10.8%)
Total	tracing	8.594 s	-
Total	iast	9.043 s	449.302 ms (5.2%)
Total	iast_HARDCODED_SECRET_DISABLED	9.016 s	422.307 ms (4.9%)
Total	iast_TELEMETRY_OFF	9.039 s	445.262 ms (5.2%)

gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~15e88a01b7, baseline=1.40.0-SNAPSHOT~5765052e34

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.324 ms) : 0, 683324
BytebuddyAgent [candidate] (682.946 ms) : 0, 682946
GlobalTracer [baseline] (310.535 ms) : 0, 310535
GlobalTracer [candidate] (313.654 ms) : 0, 313654
AppSec [baseline] (52.781 ms) : 0, 52781
AppSec [candidate] (53.162 ms) : 0, 53162
Remote Config [baseline] (662.944 µs) : 0, 663
Remote Config [candidate] (661.264 µs) : 0, 661
Telemetry [baseline] (7.606 ms) : 0, 7606
Telemetry [candidate] (7.581 ms) : 0, 7581
section iast
BytebuddyAgent [baseline] (791.7 ms) : 0, 791700
BytebuddyAgent [candidate] (798.654 ms) : 0, 798654
GlobalTracer [baseline] (299.732 ms) : 0, 299732
GlobalTracer [candidate] (301.974 ms) : 0, 301974
AppSec [baseline] (53.931 ms) : 0, 53931
AppSec [candidate] (53.966 ms) : 0, 53966
IAST [baseline] (23.681 ms) : 0, 23681
IAST [candidate] (23.873 ms) : 0, 23873
Remote Config [baseline] (623.744 µs) : 0, 624
Remote Config [candidate] (653.282 µs) : 0, 653
Telemetry [baseline] (7.369 ms) : 0, 7369
Telemetry [candidate] (7.546 ms) : 0, 7546
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (790.952 ms) : 0, 790952
BytebuddyAgent [candidate] (792.975 ms) : 0, 792975
GlobalTracer [baseline] (299.279 ms) : 0, 299279
GlobalTracer [candidate] (300.654 ms) : 0, 300654
AppSec [baseline] (54.095 ms) : 0, 54095
AppSec [candidate] (52.301 ms) : 0, 52301
IAST [baseline] (22.67 ms) : 0, 22670
IAST [candidate] (25.259 ms) : 0, 25259
Remote Config [baseline] (629.381 µs) : 0, 629
Remote Config [candidate] (631.522 µs) : 0, 632
Telemetry [baseline] (7.447 ms) : 0, 7447
Telemetry [candidate] (7.323 ms) : 0, 7323
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (794.902 ms) : 0, 794902
BytebuddyAgent [candidate] (788.708 ms) : 0, 788708
GlobalTracer [baseline] (301.809 ms) : 0, 301809
GlobalTracer [candidate] (299.961 ms) : 0, 299961
AppSec [baseline] (55.227 ms) : 0, 55227
AppSec [candidate] (55.631 ms) : 0, 55631
IAST [baseline] (22.644 ms) : 0, 22644
IAST [candidate] (20.845 ms) : 0, 20845
Remote Config [baseline] (603.369 µs) : 0, 603
Remote Config [candidate] (605.516 µs) : 0, 606
Telemetry [baseline] (7.363 ms) : 0, 7363
Telemetry [candidate] (8.052 ms) : 0, 8052

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~15e88a01b7, baseline=1.40.0-SNAPSHOT~5765052e34

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1066998
Total [baseline] (10.444 s) : 0, 10443843
Agent [candidate] (1.065 s) : 0, 1065311
Total [candidate] (10.431 s) : 0, 10430741
section appsec
Agent [baseline] (1.206 s) : 0, 1205931
Total [baseline] (10.742 s) : 0, 10741511
Agent [candidate] (1.207 s) : 0, 1207042
Total [candidate] (10.683 s) : 0, 10682933
section iast
Agent [baseline] (1.193 s) : 0, 1193322
Total [baseline] (10.837 s) : 0, 10836641
Agent [candidate] (1.193 s) : 0, 1193158
Total [candidate] (10.969 s) : 0, 10969498
section profiling
Agent [baseline] (1.267 s) : 0, 1266530
Total [baseline] (10.66 s) : 0, 10660418
Agent [candidate] (1.275 s) : 0, 1274538
Total [candidate] (10.714 s) : 0, 10713840

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.067 s	-
Agent	appsec	1.206 s	138.932 ms (13.0%)
Agent	iast	1.193 s	126.323 ms (11.8%)
Agent	profiling	1.267 s	199.531 ms (18.7%)
Total	tracing	10.444 s	-
Total	appsec	10.742 s	297.669 ms (2.9%)
Total	iast	10.837 s	392.798 ms (3.8%)
Total	profiling	10.66 s	216.575 ms (2.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.065 s	-
Agent	appsec	1.207 s	141.731 ms (13.3%)
Agent	iast	1.193 s	127.847 ms (12.0%)
Agent	profiling	1.275 s	209.226 ms (19.6%)
Total	tracing	10.431 s	-
Total	appsec	10.683 s	252.192 ms (2.4%)
Total	iast	10.969 s	538.757 ms (5.2%)
Total	profiling	10.714 s	283.098 ms (2.7%)

gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~15e88a01b7, baseline=1.40.0-SNAPSHOT~5765052e34

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.988 ms) : 0, 680988
BytebuddyAgent [candidate] (679.756 ms) : 0, 679756
GlobalTracer [baseline] (311.15 ms) : 0, 311150
GlobalTracer [candidate] (311.18 ms) : 0, 311180
AppSec [baseline] (52.88 ms) : 0, 52880
AppSec [candidate] (52.467 ms) : 0, 52467
Remote Config [baseline] (668.76 µs) : 0, 669
Remote Config [candidate] (660.14 µs) : 0, 660
Telemetry [baseline] (7.585 ms) : 0, 7585
Telemetry [candidate] (7.492 ms) : 0, 7492
section appsec
BytebuddyAgent [baseline] (706.522 ms) : 0, 706522
BytebuddyAgent [candidate] (707.649 ms) : 0, 707649
GlobalTracer [baseline] (304.933 ms) : 0, 304933
GlobalTracer [candidate] (305.505 ms) : 0, 305505
AppSec [baseline] (162.065 ms) : 0, 162065
AppSec [candidate] (161.576 ms) : 0, 161576
IAST [baseline] (20.614 ms) : 0, 20614
IAST [candidate] (20.884 ms) : 0, 20884
Remote Config [baseline] (626.614 µs) : 0, 627
Remote Config [candidate] (644.242 µs) : 0, 644
Telemetry [baseline] (7.707 ms) : 0, 7707
Telemetry [candidate] (7.415 ms) : 0, 7415
section iast
BytebuddyAgent [baseline] (793.203 ms) : 0, 793203
BytebuddyAgent [candidate] (793.302 ms) : 0, 793302
GlobalTracer [baseline] (300.295 ms) : 0, 300295
GlobalTracer [candidate] (300.062 ms) : 0, 300062
AppSec [baseline] (52.729 ms) : 0, 52729
AppSec [candidate] (55.832 ms) : 0, 55832
IAST [baseline] (25.264 ms) : 0, 25264
IAST [candidate] (22.162 ms) : 0, 22162
Remote Config [baseline] (702.937 µs) : 0, 703
Remote Config [candidate] (619.799 µs) : 0, 620
Telemetry [baseline] (7.376 ms) : 0, 7376
Telemetry [candidate] (7.434 ms) : 0, 7434
section profiling
BytebuddyAgent [baseline] (673.065 ms) : 0, 673065
BytebuddyAgent [candidate] (679.289 ms) : 0, 679289
GlobalTracer [baseline] (396.075 ms) : 0, 396075
GlobalTracer [candidate] (396.959 ms) : 0, 396959
AppSec [baseline] (53.586 ms) : 0, 53586
AppSec [candidate] (53.578 ms) : 0, 53578
Remote Config [baseline] (649.302 µs) : 0, 649
Remote Config [candidate] (655.524 µs) : 0, 656
Telemetry [baseline] (7.434 ms) : 0, 7434
Telemetry [candidate] (7.491 ms) : 0, 7491
ProfilingAgent [baseline] (97.575 ms) : 0, 97575
ProfilingAgent [candidate] (97.985 ms) : 0, 97985
Profiling [baseline] (97.598 ms) : 0, 97598
Profiling [candidate] (98.008 ms) : 0, 98008

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-09-18T10:39:22	2024-09-18T10:46:04
git_branch	master	mario.vidal/add_type_stack_trace_event
git_commit_date	1726653524	1726655448
git_commit_sha	`5765052`	`15e88a0`
release_version	1.40.0-SNAPSHOT~5765052e34	1.40.0-SNAPSHOT~15e88a01b7
start_time	2024-09-18T10:39:10	2024-09-18T10:45:51

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1726656704	1726656704
ci_job_id	643272821	643272821
ci_pipeline_id	44574361	44574361
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 19 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~15e88a01b7, baseline=1.40.0-SNAPSHOT~5765052e34
    dateFormat X
    axisFormat %s
section baseline
no_agent (343.374 µs) : 324, 363
.   : milestone, 343,
iast (457.05 µs) : 436, 479
.   : milestone, 457,
iast_FULL (516.58 µs) : 495, 538
.   : milestone, 517,
iast_GLOBAL (476.981 µs) : 456, 498
.   : milestone, 477,
iast_HARDCODED_SECRET_DISABLED (455.727 µs) : 435, 477
.   : milestone, 456,
iast_INACTIVE (415.73 µs) : 395, 437
.   : milestone, 416,
iast_TELEMETRY_OFF (445.519 µs) : 423, 468
.   : milestone, 446,
tracing (411.144 µs) : 391, 431
.   : milestone, 411,
section candidate
no_agent (345.384 µs) : 326, 365
.   : milestone, 345,
iast (458.992 µs) : 438, 480
.   : milestone, 459,
iast_FULL (521.223 µs) : 500, 542
.   : milestone, 521,
iast_GLOBAL (475.411 µs) : 454, 497
.   : milestone, 475,
iast_HARDCODED_SECRET_DISABLED (454.145 µs) : 433, 475
.   : milestone, 454,
iast_INACTIVE (422.101 µs) : 402, 443
.   : milestone, 422,
iast_TELEMETRY_OFF (445.699 µs) : 423, 468
.   : milestone, 446,
tracing (416.407 µs) : 395, 438
.   : milestone, 416,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	343.374 µs [324.041 µs, 362.707 µs]	-
iast	457.05 µs [435.536 µs, 478.563 µs]	113.675 µs (33.1%)
iast_FULL	516.58 µs [495.493 µs, 537.668 µs]	173.206 µs (50.4%)
iast_GLOBAL	476.981 µs [455.573 µs, 498.389 µs]	133.607 µs (38.9%)
iast_HARDCODED_SECRET_DISABLED	455.727 µs [434.745 µs, 476.709 µs]	112.353 µs (32.7%)
iast_INACTIVE	415.73 µs [394.821 µs, 436.638 µs]	72.355 µs (21.1%)
iast_TELEMETRY_OFF	445.519 µs [422.883 µs, 468.154 µs]	102.144 µs (29.7%)
tracing	411.144 µs [390.936 µs, 431.353 µs]	67.77 µs (19.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	345.384 µs [325.729 µs, 365.039 µs]	-
iast	458.992 µs [437.891 µs, 480.093 µs]	113.608 µs (32.9%)
iast_FULL	521.223 µs [500.208 µs, 542.238 µs]	175.839 µs (50.9%)
iast_GLOBAL	475.411 µs [453.75 µs, 497.073 µs]	130.027 µs (37.6%)
iast_HARDCODED_SECRET_DISABLED	454.145 µs [433.058 µs, 475.232 µs]	108.761 µs (31.5%)
iast_INACTIVE	422.101 µs [401.669 µs, 442.533 µs]	76.717 µs (22.2%)
iast_TELEMETRY_OFF	445.699 µs [422.971 µs, 468.428 µs]	100.315 µs (29.0%)
tracing	416.407 µs [395.228 µs, 437.586 µs]	71.023 µs (20.6%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~15e88a01b7, baseline=1.40.0-SNAPSHOT~5765052e34
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.3 ms) : 1280, 1320
.   : milestone, 1300,
appsec (1.675 ms) : 1652, 1699
.   : milestone, 1675,
appsec_no_iast (1.698 ms) : 1674, 1722
.   : milestone, 1698,
iast (1.444 ms) : 1421, 1467
.   : milestone, 1444,
profiling (1.504 ms) : 1480, 1528
.   : milestone, 1504,
tracing (1.432 ms) : 1408, 1455
.   : milestone, 1432,
section candidate
no_agent (1.311 ms) : 1292, 1331
.   : milestone, 1311,
appsec (1.695 ms) : 1672, 1718
.   : milestone, 1695,
appsec_no_iast (1.696 ms) : 1671, 1721
.   : milestone, 1696,
iast (1.469 ms) : 1446, 1491
.   : milestone, 1469,
profiling (1.503 ms) : 1479, 1527
.   : milestone, 1503,
tracing (1.453 ms) : 1429, 1477
.   : milestone, 1453,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.3 ms [1.28 ms, 1.32 ms]	-
appsec	1.675 ms [1.652 ms, 1.699 ms]	375.039 µs (28.8%)
appsec_no_iast	1.698 ms [1.674 ms, 1.722 ms]	397.752 µs (30.6%)
iast	1.444 ms [1.421 ms, 1.467 ms]	144.005 µs (11.1%)
profiling	1.504 ms [1.48 ms, 1.528 ms]	203.826 µs (15.7%)
tracing	1.432 ms [1.408 ms, 1.455 ms]	131.59 µs (10.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.311 ms [1.292 ms, 1.331 ms]	-
appsec	1.695 ms [1.672 ms, 1.718 ms]	383.911 µs (29.3%)
appsec_no_iast	1.696 ms [1.671 ms, 1.721 ms]	384.636 µs (29.3%)
iast	1.469 ms [1.446 ms, 1.491 ms]	157.263 µs (12.0%)
profiling	1.503 ms [1.479 ms, 1.527 ms]	191.979 µs (14.6%)
tracing	1.453 ms [1.429 ms, 1.477 ms]	141.529 µs (10.8%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mario.vidal/add_type_stack_trace_event
git_commit_date	1726653524	1726655448
git_commit_sha	`5765052`	`15e88a0`
release_version	1.40.0-SNAPSHOT~5765052e34	1.40.0-SNAPSHOT~15e88a01b7

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1726657228	1726657228
ci_job_id	643272823	643272823
ci_pipeline_id	44574361	44574361
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~15e88a01b7, baseline=1.40.0-SNAPSHOT~5765052e34
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.984 s) : 14984000, 14984000
.   : milestone, 14984000,
appsec (15.24 s) : 15240000, 15240000
.   : milestone, 15240000,
iast (18.553 s) : 18553000, 18553000
.   : milestone, 18553000,
iast_GLOBAL (18.044 s) : 18044000, 18044000
.   : milestone, 18044000,
profiling (15.064 s) : 15064000, 15064000
.   : milestone, 15064000,
tracing (14.89 s) : 14890000, 14890000
.   : milestone, 14890000,
section candidate
no_agent (15.098 s) : 15098000, 15098000
.   : milestone, 15098000,
appsec (15.159 s) : 15159000, 15159000
.   : milestone, 15159000,
iast (18.939 s) : 18939000, 18939000
.   : milestone, 18939000,
iast_GLOBAL (18.356 s) : 18356000, 18356000
.   : milestone, 18356000,
profiling (15.283 s) : 15283000, 15283000
.   : milestone, 15283000,
tracing (15.071 s) : 15071000, 15071000
.   : milestone, 15071000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.984 s [14.984 s, 14.984 s]	-
appsec	15.24 s [15.24 s, 15.24 s]	256.0 ms (1.7%)
iast	18.553 s [18.553 s, 18.553 s]	3.569 s (23.8%)
iast_GLOBAL	18.044 s [18.044 s, 18.044 s]	3.06 s (20.4%)
profiling	15.064 s [15.064 s, 15.064 s]	80.0 ms (0.5%)
tracing	14.89 s [14.89 s, 14.89 s]	-94.0 ms (-0.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.098 s [15.098 s, 15.098 s]	-
appsec	15.159 s [15.159 s, 15.159 s]	61.0 ms (0.4%)
iast	18.939 s [18.939 s, 18.939 s]	3.841 s (25.4%)
iast_GLOBAL	18.356 s [18.356 s, 18.356 s]	3.258 s (21.6%)
profiling	15.283 s [15.283 s, 15.283 s]	185.0 ms (1.2%)
tracing	15.071 s [15.071 s, 15.071 s]	-27.0 ms (-0.2%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~15e88a01b7, baseline=1.40.0-SNAPSHOT~5765052e34
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.441 ms) : 1430, 1453
.   : milestone, 1441,
appsec (2.264 ms) : 2223, 2305
.   : milestone, 2264,
iast (2.014 ms) : 1964, 2064
.   : milestone, 2014,
iast_GLOBAL (2.064 ms) : 2013, 2115
.   : milestone, 2064,
profiling (1.892 ms) : 1852, 1931
.   : milestone, 1892,
tracing (1.873 ms) : 1834, 1911
.   : milestone, 1873,
section candidate
no_agent (1.443 ms) : 1432, 1455
.   : milestone, 1443,
appsec (2.254 ms) : 2214, 2295
.   : milestone, 2254,
iast (2.001 ms) : 1953, 2049
.   : milestone, 2001,
iast_GLOBAL (2.082 ms) : 2031, 2134
.   : milestone, 2082,
profiling (1.904 ms) : 1864, 1944
.   : milestone, 1904,
tracing (1.87 ms) : 1832, 1907
.   : milestone, 1870,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.441 ms [1.43 ms, 1.453 ms]	-
appsec	2.264 ms [2.223 ms, 2.305 ms]	822.944 µs (57.1%)
iast	2.014 ms [1.964 ms, 2.064 ms]	572.699 µs (39.7%)
iast_GLOBAL	2.064 ms [2.013 ms, 2.115 ms]	623.022 µs (43.2%)
profiling	1.892 ms [1.852 ms, 1.931 ms]	450.401 µs (31.3%)
tracing	1.873 ms [1.834 ms, 1.911 ms]	431.509 µs (29.9%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.443 ms [1.432 ms, 1.455 ms]	-
appsec	2.254 ms [2.214 ms, 2.295 ms]	810.718 µs (56.2%)
iast	2.001 ms [1.953 ms, 2.049 ms]	557.421 µs (38.6%)
iast_GLOBAL	2.082 ms [2.031 ms, 2.134 ms]	639.049 µs (44.3%)
profiling	1.904 ms [1.864 ms, 1.944 ms]	460.768 µs (31.9%)
tracing	1.87 ms [1.832 ms, 1.907 ms]	426.206 µs (29.5%)

jandro996

I'm don't have a strong opinion but seems that we should block this until all the stackTrace report vía metastruct with different products will be clarified... Although it's true that there is an optional field in the RFC that we missed in the APPSEC implementation

Add stacktrace type

15e88a0

Mariovido added type: enhancement comp: asm iast Application Security Management (IAST) labels Sep 18, 2024

Mariovido marked this pull request as ready for review September 18, 2024 12:07

Mariovido requested a review from a team as a code owner September 18, 2024 12:07

Mariovido requested review from smola and jandro996 September 18, 2024 12:07

jandro996 requested changes Sep 19, 2024

View reviewed changes

jandro996 requested a review from ValentinZakharov September 19, 2024 13:42

Mariovido closed this Oct 7, 2024

Mariovido deleted the mario.vidal/add_type_stack_trace_event branch October 7, 2024 10:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add EVENT_TYPE to the StackTraceEvent #7638

Add EVENT_TYPE to the StackTraceEvent #7638

Mariovido commented Sep 18, 2024 •

edited

Loading

pr-commenter bot commented Sep 18, 2024 •

edited

Loading

jandro996 left a comment

Add EVENT_TYPE to the StackTraceEvent #7638

Add EVENT_TYPE to the StackTraceEvent #7638

Conversation

Mariovido commented Sep 18, 2024 • edited Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Sep 18, 2024 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

jandro996 left a comment

Choose a reason for hiding this comment

Mariovido commented Sep 18, 2024 •

edited

Loading

pr-commenter bot commented Sep 18, 2024 •

edited

Loading