Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce log level for "WAF object had not been closed" #7657

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Reduce log level for "WAF object had not been closed" #7657

merged 1 commit into from
Sep 23, 2024
+4 −1

Conversation

smola
Copy link
Member

@smola smola commented Sep 20, 2024 •
edited by jira bot
Loading

What Does This Do

For log message WAF object had not been closed (probably missed request-end event):

  • Reduce log level to debug.
  • Send it to telemetry logs.

Motivation

These rarely happen, but when they happen, they tend to happen frequently. The insistent logging becomes a problem in itself, and the error is not directly actionable by our customers. Hence the debug level. However, this indicates a bug in the tracer, so we'll force it to telemetry logs (if telemetry logs are enabled) so that we still have info on any regression.

Additional Notes

Contributor Checklist

Jira ticket: SCRS-1078

@smola smola added type: enhancement comp: asm waf Application Security Management (WAF) labels Sep 20, 2024
@smola smola requested a review from a team as a code owner September 20, 2024 14:10
@smola smola force-pushed the smola/missing-request-end-log-debug branch from 84cfecf to 66f15fc Compare September 20, 2024 14:41
@pr-commenter
Copy link

pr-commenter bot commented Sep 20, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/missing-request-end-log-debug
git_commit_date 1726843314 1726843278
git_commit_sha f681000 66f15fc
release_version 1.40.0-SNAPSHOT~f6810002f7 1.40.0-SNAPSHOT~66f15fc66c
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1726845689 1726845689
ci_job_id 646600664 646600664
ci_pipeline_id 44799516 44799516
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~66f15fc66c, baseline=1.40.0-SNAPSHOT~f6810002f7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1080736
Total [baseline] (10.464 s) : 0, 10464130
Agent [candidate] (1.073 s) : 0, 1072654
Total [candidate] (10.406 s) : 0, 10406244
section appsec
Agent [baseline] (1.203 s) : 0, 1203322
Total [baseline] (10.662 s) : 0, 10662201
Agent [candidate] (1.203 s) : 0, 1203435
Total [candidate] (10.654 s) : 0, 10654207
section iast
Agent [baseline] (1.193 s) : 0, 1193486
Total [baseline] (10.904 s) : 0, 10904125
Agent [candidate] (1.202 s) : 0, 1202434
Total [candidate] (10.916 s) : 0, 10916331
section profiling
Agent [baseline] (1.266 s) : 0, 1265895
Total [baseline] (10.593 s) : 0, 10592629
Agent [candidate] (1.269 s) : 0, 1269145
Total [candidate] (10.629 s) : 0, 10628643
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent appsec 1.203 s 122.586 ms (11.3%)
Agent iast 1.193 s 112.75 ms (10.4%)
Agent profiling 1.266 s 185.159 ms (17.1%)
Total tracing 10.464 s -
Total appsec 10.662 s 198.071 ms (1.9%)
Total iast 10.904 s 439.995 ms (4.2%)
Total profiling 10.593 s 128.499 ms (1.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.073 s -
Agent appsec 1.203 s 130.78 ms (12.2%)
Agent iast 1.202 s 129.78 ms (12.1%)
Agent profiling 1.269 s 196.491 ms (18.3%)
Total tracing 10.406 s -
Total appsec 10.654 s 247.964 ms (2.4%)
Total iast 10.916 s 510.088 ms (4.9%)
Total profiling 10.629 s 222.399 ms (2.1%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~66f15fc66c, baseline=1.40.0-SNAPSHOT~f6810002f7

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.764 ms) : 0, 689764
BytebuddyAgent [candidate] (685.656 ms) : 0, 685656
GlobalTracer [baseline] (314.407 ms) : 0, 314407
GlobalTracer [candidate] (310.789 ms) : 0, 310789
AppSec [baseline] (54.215 ms) : 0, 54215
AppSec [candidate] (54.043 ms) : 0, 54043
Remote Config [baseline] (675.299 µs) : 0, 675
Remote Config [candidate] (673.447 µs) : 0, 673
Telemetry [baseline] (7.723 ms) : 0, 7723
Telemetry [candidate] (7.64 ms) : 0, 7640
section appsec
BytebuddyAgent [baseline] (702.099 ms) : 0, 702099
BytebuddyAgent [candidate] (702.981 ms) : 0, 702981
GlobalTracer [baseline] (304.283 ms) : 0, 304283
GlobalTracer [candidate] (303.835 ms) : 0, 303835
AppSec [baseline] (162.623 ms) : 0, 162623
AppSec [candidate] (163.442 ms) : 0, 163442
Remote Config [baseline] (652.918 µs) : 0, 653
Remote Config [candidate] (650.879 µs) : 0, 651
Telemetry [baseline] (9.657 ms) : 0, 9657
Telemetry [candidate] (8.164 ms) : 0, 8164
IAST [baseline] (20.58 ms) : 0, 20580
IAST [candidate] (21.308 ms) : 0, 21308
section iast
BytebuddyAgent [baseline] (793.56 ms) : 0, 793560
BytebuddyAgent [candidate] (799.659 ms) : 0, 799659
GlobalTracer [baseline] (299.056 ms) : 0, 299056
GlobalTracer [candidate] (301.194 ms) : 0, 301194
AppSec [baseline] (55.145 ms) : 0, 55145
AppSec [candidate] (53.805 ms) : 0, 53805
Remote Config [baseline] (613.342 µs) : 0, 613
Remote Config [candidate] (609.076 µs) : 0, 609
Telemetry [baseline] (7.483 ms) : 0, 7483
Telemetry [candidate] (7.535 ms) : 0, 7535
IAST [baseline] (23.897 ms) : 0, 23897
IAST [candidate] (25.757 ms) : 0, 25757
section profiling
ProfilingAgent [baseline] (96.676 ms) : 0, 96676
ProfilingAgent [candidate] (96.325 ms) : 0, 96325
BytebuddyAgent [baseline] (673.52 ms) : 0, 673520
BytebuddyAgent [candidate] (675.496 ms) : 0, 675496
GlobalTracer [baseline] (394.811 ms) : 0, 394811
GlobalTracer [candidate] (396.241 ms) : 0, 396241
AppSec [baseline] (54.664 ms) : 0, 54664
AppSec [candidate] (54.57 ms) : 0, 54570
Remote Config [baseline] (647.993 µs) : 0, 648
Remote Config [candidate] (661.638 µs) : 0, 662
Telemetry [baseline] (7.431 ms) : 0, 7431
Telemetry [candidate] (7.456 ms) : 0, 7456
Profiling [baseline] (96.7 ms) : 0, 96700
Profiling [candidate] (96.349 ms) : 0, 96349
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~66f15fc66c, baseline=1.40.0-SNAPSHOT~f6810002f7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068788
Total [baseline] (8.578 s) : 0, 8578047
Agent [candidate] (1.066 s) : 0, 1066051
Total [candidate] (8.566 s) : 0, 8565796
section iast
Agent [baseline] (1.204 s) : 0, 1203644
Total [baseline] (9.014 s) : 0, 9013858
Agent [candidate] (1.197 s) : 0, 1196706
Total [candidate] (9.054 s) : 0, 9053997
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.192 s) : 0, 1192069
Total [baseline] (9.013 s) : 0, 9013409
Agent [candidate] (1.191 s) : 0, 1191120
Total [candidate] (8.989 s) : 0, 8988694
section iast_TELEMETRY_OFF
Agent [baseline] (1.198 s) : 0, 1197819
Total [baseline] (9.036 s) : 0, 9036145
Agent [candidate] (1.199 s) : 0, 1198524
Total [candidate] (9.018 s) : 0, 9018203
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.069 s -
Agent iast 1.204 s 134.856 ms (12.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.192 s 123.282 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.198 s 129.031 ms (12.1%)
Total tracing 8.578 s -
Total iast 9.014 s 435.811 ms (5.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.013 s 435.363 ms (5.1%)
Total iast_TELEMETRY_OFF 9.036 s 458.098 ms (5.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent iast 1.197 s 130.655 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.191 s 125.069 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.199 s 132.472 ms (12.4%)
Total tracing 8.566 s -
Total iast 9.054 s 488.201 ms (5.7%)
Total iast_HARDCODED_SECRET_DISABLED 8.989 s 422.898 ms (4.9%)
Total iast_TELEMETRY_OFF 9.018 s 452.407 ms (5.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~66f15fc66c, baseline=1.40.0-SNAPSHOT~f6810002f7

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.776 ms) : 0, 681776
BytebuddyAgent [candidate] (680.33 ms) : 0, 680330
GlobalTracer [baseline] (310.851 ms) : 0, 310851
GlobalTracer [candidate] (310.022 ms) : 0, 310022
AppSec [baseline] (54.065 ms) : 0, 54065
AppSec [candidate] (53.754 ms) : 0, 53754
Remote Config [baseline] (672.2 µs) : 0, 672
Remote Config [candidate] (667.516 µs) : 0, 668
Telemetry [baseline] (7.639 ms) : 0, 7639
Telemetry [candidate] (7.551 ms) : 0, 7551
section iast
BytebuddyAgent [baseline] (800.718 ms) : 0, 800718
BytebuddyAgent [candidate] (796.115 ms) : 0, 796115
GlobalTracer [baseline] (301.556 ms) : 0, 301556
GlobalTracer [candidate] (300.201 ms) : 0, 300201
AppSec [baseline] (55.876 ms) : 0, 55876
AppSec [candidate] (54.015 ms) : 0, 54015
IAST [baseline] (23.598 ms) : 0, 23598
IAST [candidate] (24.504 ms) : 0, 24504
Remote Config [baseline] (631.605 µs) : 0, 632
Remote Config [candidate] (640.665 µs) : 0, 641
Telemetry [baseline] (7.392 ms) : 0, 7392
Telemetry [candidate] (7.412 ms) : 0, 7412
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (792.268 ms) : 0, 792268
BytebuddyAgent [candidate] (791.981 ms) : 0, 791981
GlobalTracer [baseline] (299.328 ms) : 0, 299328
GlobalTracer [candidate] (299.049 ms) : 0, 299049
AppSec [baseline] (53.356 ms) : 0, 53356
AppSec [candidate] (54.765 ms) : 0, 54765
IAST [baseline] (25.326 ms) : 0, 25326
IAST [candidate] (23.567 ms) : 0, 23567
Remote Config [baseline] (638.94 µs) : 0, 639
Remote Config [candidate] (607.213 µs) : 0, 607
Telemetry [baseline] (7.402 ms) : 0, 7402
Telemetry [candidate] (7.356 ms) : 0, 7356
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (796.527 ms) : 0, 796527
BytebuddyAgent [candidate] (796.092 ms) : 0, 796092
GlobalTracer [baseline] (301.726 ms) : 0, 301726
GlobalTracer [candidate] (301.914 ms) : 0, 301914
AppSec [baseline] (56.199 ms) : 0, 56199
AppSec [candidate] (56.234 ms) : 0, 56234
IAST [baseline] (21.551 ms) : 0, 21551
IAST [candidate] (22.545 ms) : 0, 22545
Remote Config [baseline] (613.833 µs) : 0, 614
Remote Config [candidate] (600.084 µs) : 0, 600
Telemetry [baseline] (7.304 ms) : 0, 7304
Telemetry [candidate] (7.233 ms) : 0, 7233
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-20T14:49:57 2024-09-20T14:56:48
git_branch master smola/missing-request-end-log-debug
git_commit_date 1726843314 1726843278
git_commit_sha f681000 66f15fc
release_version 1.40.0-SNAPSHOT~f6810002f7 1.40.0-SNAPSHOT~66f15fc66c
start_time 2024-09-20T14:49:43 2024-09-20T14:56:35
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1726844554 1726844554
ci_job_id 646600665 646600665
ci_pipeline_id 44799516 44799516
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~66f15fc66c, baseline=1.40.0-SNAPSHOT~f6810002f7
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.668 µs) : 352, 397
.   : milestone, 375,
iast (487.316 µs) : 466, 509
.   : milestone, 487,
iast_FULL (556.132 µs) : 535, 578
.   : milestone, 556,
iast_GLOBAL (513.618 µs) : 492, 535
.   : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (487.068 µs) : 466, 508
.   : milestone, 487,
iast_INACTIVE (448.205 µs) : 427, 469
.   : milestone, 448,
iast_TELEMETRY_OFF (478.437 µs) : 456, 501
.   : milestone, 478,
tracing (438.974 µs) : 419, 459
.   : milestone, 439,
section candidate
no_agent (373.226 µs) : 353, 393
.   : milestone, 373,
iast (486.611 µs) : 465, 508
.   : milestone, 487,
iast_FULL (556.304 µs) : 535, 578
.   : milestone, 556,
iast_GLOBAL (509.479 µs) : 488, 531
.   : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (482.145 µs) : 461, 503
.   : milestone, 482,
iast_INACTIVE (453.045 µs) : 432, 474
.   : milestone, 453,
iast_TELEMETRY_OFF (475.1 µs) : 453, 498
.   : milestone, 475,
tracing (453.628 µs) : 433, 475
.   : milestone, 454,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.668 µs [352.295 µs, 397.04 µs] -
iast 487.316 µs [466.067 µs, 508.565 µs] 112.649 µs (30.1%)
iast_FULL 556.132 µs [534.732 µs, 577.532 µs] 181.464 µs (48.4%)
iast_GLOBAL 513.618 µs [491.971 µs, 535.264 µs] 138.95 µs (37.1%)
iast_HARDCODED_SECRET_DISABLED 487.068 µs [465.892 µs, 508.243 µs] 112.4 µs (30.0%)
iast_INACTIVE 448.205 µs [427.317 µs, 469.092 µs] 73.537 µs (19.6%)
iast_TELEMETRY_OFF 478.437 µs [455.659 µs, 501.215 µs] 103.77 µs (27.7%)
tracing 438.974 µs [418.681 µs, 459.267 µs] 64.306 µs (17.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.226 µs [353.093 µs, 393.359 µs] -
iast 486.611 µs [464.994 µs, 508.228 µs] 113.385 µs (30.4%)
iast_FULL 556.304 µs [535.056 µs, 577.552 µs] 183.078 µs (49.1%)
iast_GLOBAL 509.479 µs [487.741 µs, 531.217 µs] 136.253 µs (36.5%)
iast_HARDCODED_SECRET_DISABLED 482.145 µs [461.349 µs, 502.941 µs] 108.919 µs (29.2%)
iast_INACTIVE 453.045 µs [432.197 µs, 473.893 µs] 79.819 µs (21.4%)
iast_TELEMETRY_OFF 475.1 µs [452.55 µs, 497.651 µs] 101.874 µs (27.3%)
tracing 453.628 µs [432.708 µs, 474.547 µs] 80.401 µs (21.5%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~66f15fc66c, baseline=1.40.0-SNAPSHOT~f6810002f7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.351 ms) : 1332, 1370
.   : milestone, 1351,
appsec (1.71 ms) : 1685, 1735
.   : milestone, 1710,
appsec_no_iast (1.717 ms) : 1694, 1741
.   : milestone, 1717,
iast (1.486 ms) : 1463, 1509
.   : milestone, 1486,
profiling (1.496 ms) : 1474, 1519
.   : milestone, 1496,
tracing (1.486 ms) : 1462, 1509
.   : milestone, 1486,
section candidate
no_agent (1.345 ms) : 1324, 1365
.   : milestone, 1345,
appsec (1.746 ms) : 1722, 1770
.   : milestone, 1746,
appsec_no_iast (1.744 ms) : 1720, 1768
.   : milestone, 1744,
iast (1.476 ms) : 1453, 1499
.   : milestone, 1476,
profiling (1.482 ms) : 1460, 1505
.   : milestone, 1482,
tracing (1.453 ms) : 1428, 1478
.   : milestone, 1453,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.351 ms [1.332 ms, 1.37 ms] -
appsec 1.71 ms [1.685 ms, 1.735 ms] 358.415 µs (26.5%)
appsec_no_iast 1.717 ms [1.694 ms, 1.741 ms] 366.073 µs (27.1%)
iast 1.486 ms [1.463 ms, 1.509 ms] 134.623 µs (10.0%)
profiling 1.496 ms [1.474 ms, 1.519 ms] 144.895 µs (10.7%)
tracing 1.486 ms [1.462 ms, 1.509 ms] 134.5 µs (10.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.345 ms [1.324 ms, 1.365 ms] -
appsec 1.746 ms [1.722 ms, 1.77 ms] 401.039 µs (29.8%)
appsec_no_iast 1.744 ms [1.72 ms, 1.768 ms] 399.389 µs (29.7%)
iast 1.476 ms [1.453 ms, 1.499 ms] 131.675 µs (9.8%)
profiling 1.482 ms [1.46 ms, 1.505 ms] 137.877 µs (10.3%)
tracing 1.453 ms [1.428 ms, 1.478 ms] 108.643 µs (8.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/missing-request-end-log-debug
git_commit_date 1726843314 1726843278
git_commit_sha f681000 66f15fc
release_version 1.40.0-SNAPSHOT~f6810002f7 1.40.0-SNAPSHOT~66f15fc66c
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1726845090 1726845090
ci_job_id 646600666 646600666
ci_pipeline_id 44799516 44799516
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~66f15fc66c, baseline=1.40.0-SNAPSHOT~f6810002f7
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.346 s) : 15346000, 15346000
.   : milestone, 15346000,
appsec (14.963 s) : 14963000, 14963000
.   : milestone, 14963000,
iast (18.977 s) : 18977000, 18977000
.   : milestone, 18977000,
iast_GLOBAL (17.698 s) : 17698000, 17698000
.   : milestone, 17698000,
profiling (15.14 s) : 15140000, 15140000
.   : milestone, 15140000,
tracing (14.939 s) : 14939000, 14939000
.   : milestone, 14939000,
section candidate
no_agent (15.863 s) : 15863000, 15863000
.   : milestone, 15863000,
appsec (15.063 s) : 15063000, 15063000
.   : milestone, 15063000,
iast (18.765 s) : 18765000, 18765000
.   : milestone, 18765000,
iast_GLOBAL (17.933 s) : 17933000, 17933000
.   : milestone, 17933000,
profiling (15.688 s) : 15688000, 15688000
.   : milestone, 15688000,
tracing (14.9 s) : 14900000, 14900000
.   : milestone, 14900000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.346 s [15.346 s, 15.346 s] -
appsec 14.963 s [14.963 s, 14.963 s] -383.0 ms (-2.5%)
iast 18.977 s [18.977 s, 18.977 s] 3.631 s (23.7%)
iast_GLOBAL 17.698 s [17.698 s, 17.698 s] 2.352 s (15.3%)
profiling 15.14 s [15.14 s, 15.14 s] -206.0 ms (-1.3%)
tracing 14.939 s [14.939 s, 14.939 s] -407.0 ms (-2.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.863 s [15.863 s, 15.863 s] -
appsec 15.063 s [15.063 s, 15.063 s] -800.0 ms (-5.0%)
iast 18.765 s [18.765 s, 18.765 s] 2.902 s (18.3%)
iast_GLOBAL 17.933 s [17.933 s, 17.933 s] 2.07 s (13.0%)
profiling 15.688 s [15.688 s, 15.688 s] -175.0 ms (-1.1%)
tracing 14.9 s [14.9 s, 14.9 s] -963.0 ms (-6.1%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~66f15fc66c, baseline=1.40.0-SNAPSHOT~f6810002f7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.468 ms) : 1457, 1480
.   : milestone, 1468,
appsec (2.316 ms) : 2275, 2357
.   : milestone, 2316,
iast (2.056 ms) : 2005, 2107
.   : milestone, 2056,
iast_GLOBAL (2.1 ms) : 2049, 2151
.   : milestone, 2100,
profiling (1.921 ms) : 1882, 1961
.   : milestone, 1921,
tracing (1.891 ms) : 1852, 1929
.   : milestone, 1891,
section candidate
no_agent (1.461 ms) : 1449, 1472
.   : milestone, 1461,
appsec (2.308 ms) : 2268, 2349
.   : milestone, 2308,
iast (2.052 ms) : 2002, 2103
.   : milestone, 2052,
iast_GLOBAL (2.091 ms) : 2040, 2142
.   : milestone, 2091,
profiling (2.359 ms) : 2185, 2533
.   : milestone, 2359,
tracing (1.898 ms) : 1860, 1936
.   : milestone, 1898,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.457 ms, 1.48 ms] -
appsec 2.316 ms [2.275 ms, 2.357 ms] 847.366 µs (57.7%)
iast 2.056 ms [2.005 ms, 2.107 ms] 587.332 µs (40.0%)
iast_GLOBAL 2.1 ms [2.049 ms, 2.151 ms] 631.861 µs (43.0%)
profiling 1.921 ms [1.882 ms, 1.961 ms] 452.973 µs (30.8%)
tracing 1.891 ms [1.852 ms, 1.929 ms] 422.114 µs (28.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.461 ms [1.449 ms, 1.472 ms] -
appsec 2.308 ms [2.268 ms, 2.349 ms] 847.687 µs (58.0%)
iast 2.052 ms [2.002 ms, 2.103 ms] 591.708 µs (40.5%)
iast_GLOBAL 2.091 ms [2.04 ms, 2.142 ms] 630.395 µs (43.2%)
profiling 2.359 ms [2.185 ms, 2.533 ms] 898.633 µs (61.5%)
tracing 1.898 ms [1.86 ms, 1.936 ms] 437.54 µs (30.0%)

PerfectSlayer
PerfectSlayer approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable

@smola smola enabled auto-merge (squash) September 23, 2024 07:11
@smola smola merged commit 7f040c5 into master Sep 23, 2024
102 checks passed
@smola smola deleted the smola/missing-request-end-log-debug branch September 23, 2024 07:27
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 23, 2024
smola added a commit that referenced this pull request Sep 23, 2024
@smola
Reduce log level for "WAF object had not been closed" (#7657)
c6196ff 
(cherry picked from commit 7f040c5)
@smola smola mentioned this pull request Sep 23, 2024
Merged
5 tasks
smola added a commit that referenced this pull request Sep 23, 2024
@smola
Reduce log level for "WAF object had not been closed" (#7657) (#7667)
b9e1c16 
(cherry picked from commit 7f040c5)
jordan-wong pushed a commit that referenced this pull request Sep 23, 2024
@smola @jordan-wong
Reduce log level for "WAF object had not been closed" (#7657)
4c1a347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandro996 jandro996 jandro996 approved these changes

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

Assignees
No one assigned
Labels
comp: asm waf Application Security Management (WAF) type: enhancement
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
4 participants
@smola @PerfectSlayer @manuel-alvarez-alvarez @jandro996