Add error priorities for dynamic instrumentation and manual instrumentation #9098
Conversation
|
👋 @deejgregor Thanks for having opened this pull request. Having one more level for manual instrumentation makes sense. I think there is no need to create an additional one for the TagInterceptor, since the setError here uses the default (That will be lower of the one created for manual instrumentation). |
amarziali
added
type: enhancement
| @@ -217,7 +217,7 @@ private boolean interceptDbStatement(DDSpanContext span, Object value) { | |||
| } | |||
|
|
|||
| private boolean interceptError(DDSpanContext span, Object value) { | |||
| span.setErrorFlag(asBoolean(value), ErrorPriorities.DEFAULT); | |||
| span.setErrorFlag(asBoolean(value), ErrorPriorities.TAG_INTERCEPTOR); | |||
There was a problem hiding this comment.
I would still use the default here. The ones using the interceptor, are setting a tag to infer the error flag.Both are falling hence into the manual instrumentation use case
deejgregor
force-pushed
the
feature-more-error-priorities
branch
from
d616ce3 to
f573ade
Compare
|
👋 @deejgregor , |
|
Hi @deejgregor , |
|
Closing this PR. The modifications have been included in the release 1.53.0. Thank you again for this idea and collaboration @deejgregor ! |
What Does This Do
Adds error priorities for dynamic instrumentation and manual instrumentation, similar to what exists for priorities for resource name today.
It also sets the priority for manual instrumentation from otel spans for both resource name and error.
Motivation
Reliably override error status set by automatic instrumentation from dynamic instrumentation and manual instrumentation.
Additional Notes
No tests have been added yet. If the change generally seems good, I'm happy to write tests.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]