Skip to content

Fix pekko instrumentation in a rare edge case #9676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix pekko instrumentation in a rare edge case #9676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...java/datadog/trace/instrumentation/pekkohttp/DatadogServerRequestResponseFlowWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,19 @@ public void onUpstreamFailure(final Throwable ex) throws Exception {
// Mark the span as failed
AgentSpan span = fromContext(scope.context());
DatadogWrapperHelper.finishSpan(span, ex);

// Clean up the leaked scope like in the normal response path
AgentSpan activeSpan = activeSpan();
if (activeSpan == span) {
scope.close();
}
}
// We will not receive any more responses from the user code, so clean up any
// remaining spans
scope = scopes.poll();
while (scope != null) {
fromContext(scope.context()).finish();
scope.close();
scope = scopes.poll();
}
fail(responseOutlet, ex);
Expand Down
Loading