-
Notifications
You must be signed in to change notification settings - Fork 313
Add Capture Expressions #9694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Capture Expressions #9694
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (318.337 µs) : 294, 343
. : milestone, 318,
basic (282.033 µs) : 276, 289
. : milestone, 282,
loop (8.971 ms) : 8967, 8976
. : milestone, 8971,
section candidate
noprobe (326.694 µs) : 277, 377
. : milestone, 327,
basic (282.481 µs) : 276, 289
. : milestone, 282,
loop (8.964 ms) : 8957, 8970
. : milestone, 8964,
|
🎯 Code Coverage 🔗 Commit SHA: d192119 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~d192119497, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.027 s) : 0, 1027188
Total [baseline] (10.655 s) : 0, 10654589
Agent [candidate] (1.017 s) : 0, 1016669
Total [candidate] (10.716 s) : 0, 10716336
section appsec
Agent [baseline] (1.192 s) : 0, 1191864
Total [baseline] (10.97 s) : 0, 10970318
Agent [candidate] (1.19 s) : 0, 1190102
Total [candidate] (11.043 s) : 0, 11042624
section iast
Agent [baseline] (1.159 s) : 0, 1158563
Total [baseline] (10.972 s) : 0, 10972295
Agent [candidate] (1.148 s) : 0, 1147710
Total [candidate] (11.076 s) : 0, 11075514
section profiling
Agent [baseline] (1.167 s) : 0, 1166720
Total [baseline] (11.01 s) : 0, 11009713
Agent [candidate] (1.158 s) : 0, 1158434
Total [candidate] (11.007 s) : 0, 11007463
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~d192119497, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (700.542 ms) : 0, 700542
BytebuddyAgent [candidate] (693.948 ms) : 0, 693948
GlobalTracer [baseline] (243.841 ms) : 0, 243841
GlobalTracer [candidate] (241.67 ms) : 0, 241670
AppSec [baseline] (32.482 ms) : 0, 32482
AppSec [candidate] (32.739 ms) : 0, 32739
Debugger [baseline] (6.527 ms) : 0, 6527
Debugger [candidate] (6.406 ms) : 0, 6406
Remote Config [baseline] (701.178 µs) : 0, 701
Remote Config [candidate] (700.192 µs) : 0, 700
Telemetry [baseline] (9.278 ms) : 0, 9278
Telemetry [candidate] (9.233 ms) : 0, 9233
Flare Poller [baseline] (10.946 ms) : 0, 10946
Flare Poller [candidate] (9.333 ms) : 0, 9333
section appsec
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (716.674 ms) : 0, 716674
BytebuddyAgent [candidate] (715.047 ms) : 0, 715047
GlobalTracer [baseline] (234.203 ms) : 0, 234203
GlobalTracer [candidate] (233.703 ms) : 0, 233703
AppSec [baseline] (174.773 ms) : 0, 174773
AppSec [candidate] (175.063 ms) : 0, 175063
Debugger [baseline] (6.08 ms) : 0, 6080
Debugger [candidate] (6.096 ms) : 0, 6096
Remote Config [baseline] (632.42 µs) : 0, 632
Remote Config [candidate] (639.921 µs) : 0, 640
Telemetry [baseline] (8.377 ms) : 0, 8377
Telemetry [candidate] (8.382 ms) : 0, 8382
Flare Poller [baseline] (3.951 ms) : 0, 3951
Flare Poller [candidate] (3.957 ms) : 0, 3957
IAST [baseline] (24.72 ms) : 0, 24720
IAST [candidate] (24.733 ms) : 0, 24733
section iast
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (821.215 ms) : 0, 821215
BytebuddyAgent [candidate] (812.958 ms) : 0, 812958
GlobalTracer [baseline] (233.089 ms) : 0, 233089
GlobalTracer [candidate] (231.154 ms) : 0, 231154
AppSec [baseline] (34.296 ms) : 0, 34296
AppSec [candidate] (34.368 ms) : 0, 34368
Debugger [baseline] (6.164 ms) : 0, 6164
Debugger [candidate] (6.132 ms) : 0, 6132
Remote Config [baseline] (616.757 µs) : 0, 617
Remote Config [candidate] (603.979 µs) : 0, 604
Telemetry [baseline] (8.677 ms) : 0, 8677
Telemetry [candidate] (8.551 ms) : 0, 8551
Flare Poller [baseline] (4.188 ms) : 0, 4188
Flare Poller [candidate] (4.137 ms) : 0, 4137
IAST [baseline] (27.469 ms) : 0, 27469
IAST [candidate] (27.129 ms) : 0, 27129
section profiling
crashtracking [baseline] (1.443 ms) : 0, 1443
crashtracking [candidate] (1.421 ms) : 0, 1421
BytebuddyAgent [baseline] (724.356 ms) : 0, 724356
BytebuddyAgent [candidate] (718.755 ms) : 0, 718755
GlobalTracer [baseline] (218.44 ms) : 0, 218440
GlobalTracer [candidate] (216.863 ms) : 0, 216863
AppSec [baseline] (32.81 ms) : 0, 32810
AppSec [candidate] (32.976 ms) : 0, 32976
Debugger [baseline] (7.274 ms) : 0, 7274
Debugger [candidate] (7.227 ms) : 0, 7227
Remote Config [baseline] (708.074 µs) : 0, 708
Remote Config [candidate] (690.325 µs) : 0, 690
Telemetry [baseline] (14.923 ms) : 0, 14923
Telemetry [candidate] (15.866 ms) : 0, 15866
Flare Poller [baseline] (5.088 ms) : 0, 5088
Flare Poller [candidate] (4.133 ms) : 0, 4133
ProfilingAgent [baseline] (108.019 ms) : 0, 108019
ProfilingAgent [candidate] (106.95 ms) : 0, 106950
Profiling [baseline] (109.519 ms) : 0, 109519
Profiling [candidate] (108.608 ms) : 0, 108608
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~d192119497, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.026 s) : 0, 1025610
Total [baseline] (8.713 s) : 0, 8713257
Agent [candidate] (1.017 s) : 0, 1017167
Total [candidate] (8.684 s) : 0, 8683926
section iast
Agent [baseline] (1.156 s) : 0, 1156198
Total [baseline] (9.293 s) : 0, 9292674
Agent [candidate] (1.153 s) : 0, 1152810
Total [candidate] (9.261 s) : 0, 9261309
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~d192119497, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.484 ms) : 0, 1484
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (698.699 ms) : 0, 698699
BytebuddyAgent [candidate] (693.178 ms) : 0, 693178
GlobalTracer [baseline] (243.717 ms) : 0, 243717
GlobalTracer [candidate] (241.787 ms) : 0, 241787
AppSec [baseline] (32.972 ms) : 0, 32972
AppSec [candidate] (33.066 ms) : 0, 33066
Debugger [baseline] (6.486 ms) : 0, 6486
Debugger [candidate] (6.443 ms) : 0, 6443
Remote Config [baseline] (702.095 µs) : 0, 702
Remote Config [candidate] (690.968 µs) : 0, 691
Telemetry [baseline] (9.388 ms) : 0, 9388
Telemetry [candidate] (9.325 ms) : 0, 9325
Flare Poller [baseline] (10.869 ms) : 0, 10869
Flare Poller [candidate] (10.131 ms) : 0, 10131
section iast
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (819.079 ms) : 0, 819079
BytebuddyAgent [candidate] (816.441 ms) : 0, 816441
GlobalTracer [baseline] (232.454 ms) : 0, 232454
GlobalTracer [candidate] (231.817 ms) : 0, 231817
AppSec [baseline] (35.037 ms) : 0, 35037
AppSec [candidate] (35.425 ms) : 0, 35425
Debugger [baseline] (6.241 ms) : 0, 6241
Debugger [candidate] (6.139 ms) : 0, 6139
Remote Config [baseline] (620.572 µs) : 0, 621
Remote Config [candidate] (612.812 µs) : 0, 613
Telemetry [baseline] (8.786 ms) : 0, 8786
Telemetry [candidate] (8.748 ms) : 0, 8748
Flare Poller [baseline] (4.271 ms) : 0, 4271
Flare Poller [candidate] (4.238 ms) : 0, 4238
IAST [baseline] (26.863 ms) : 0, 26863
IAST [candidate] (26.579 ms) : 0, 26579
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~d192119497, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section baseline
no_agent (37.604 ms) : 37302, 37906
. : milestone, 37604,
appsec (49.157 ms) : 48718, 49595
. : milestone, 49157,
code_origins (44.058 ms) : 43694, 44422
. : milestone, 44058,
iast (45.396 ms) : 45004, 45788
. : milestone, 45396,
profiling (47.3 ms) : 46894, 47705
. : milestone, 47300,
tracing (43.806 ms) : 43427, 44185
. : milestone, 43806,
section candidate
no_agent (37.556 ms) : 37252, 37860
. : milestone, 37556,
appsec (48.417 ms) : 47981, 48853
. : milestone, 48417,
code_origins (44.281 ms) : 43910, 44651
. : milestone, 44281,
iast (44.206 ms) : 43827, 44585
. : milestone, 44206,
profiling (46.502 ms) : 46090, 46914
. : milestone, 46502,
tracing (46.348 ms) : 45936, 46761
. : milestone, 46348,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~d192119497, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section baseline
no_agent (4.296 ms) : 4245, 4346
. : milestone, 4296,
iast (9.268 ms) : 9118, 9418
. : milestone, 9268,
iast_FULL (15.797 ms) : 15478, 16116
. : milestone, 15797,
iast_GLOBAL (10.926 ms) : 10723, 11129
. : milestone, 10926,
profiling (9.448 ms) : 9286, 9609
. : milestone, 9448,
tracing (8.585 ms) : 8451, 8719
. : milestone, 8585,
section candidate
no_agent (4.317 ms) : 4269, 4365
. : milestone, 4317,
iast (10.214 ms) : 10042, 10386
. : milestone, 10214,
iast_FULL (14.411 ms) : 14126, 14697
. : milestone, 14411,
iast_GLOBAL (10.844 ms) : 10651, 11038
. : milestone, 10844,
profiling (8.662 ms) : 8530, 8794
. : milestone, 8662,
tracing (7.813 ms) : 7698, 7928
. : milestone, 7813,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~d192119497, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section baseline
no_agent (14.921 s) : 14921000, 14921000
. : milestone, 14921000,
appsec (15.063 s) : 15063000, 15063000
. : milestone, 15063000,
iast (18.374 s) : 18374000, 18374000
. : milestone, 18374000,
iast_GLOBAL (18.274 s) : 18274000, 18274000
. : milestone, 18274000,
profiling (14.939 s) : 14939000, 14939000
. : milestone, 14939000,
tracing (15.359 s) : 15359000, 15359000
. : milestone, 15359000,
section candidate
no_agent (14.944 s) : 14944000, 14944000
. : milestone, 14944000,
appsec (15.034 s) : 15034000, 15034000
. : milestone, 15034000,
iast (18.399 s) : 18399000, 18399000
. : milestone, 18399000,
iast_GLOBAL (18.125 s) : 18125000, 18125000
. : milestone, 18125000,
profiling (15.028 s) : 15028000, 15028000
. : milestone, 15028000,
tracing (15.235 s) : 15235000, 15235000
. : milestone, 15235000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~d192119497, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (3.744 ms) : 3525, 3964
. : milestone, 3744,
iast (2.221 ms) : 2158, 2284
. : milestone, 2221,
iast_GLOBAL (2.257 ms) : 2194, 2321
. : milestone, 2257,
profiling (2.068 ms) : 2017, 2119
. : milestone, 2068,
tracing (2.049 ms) : 1999, 2098
. : milestone, 2049,
section candidate
no_agent (1.485 ms) : 1473, 1496
. : milestone, 1485,
appsec (3.682 ms) : 3470, 3895
. : milestone, 3682,
iast (2.23 ms) : 2167, 2293
. : milestone, 2230,
iast_GLOBAL (2.263 ms) : 2200, 2327
. : milestone, 2263,
profiling (2.083 ms) : 2031, 2136
. : milestone, 2083,
tracing (2.048 ms) : 1998, 2097
. : milestone, 2048,
|
Previously watches, capture expressions allow to describe what exactly we want to capture and put into a snapshot for a log probe. When one or more capture expressions is defined, only the capture expressions are added to the Captures part of the snapshot. Expressions can be complex using the expression language and must return a value from which we start to capture the object graph following the limits that can be defined per capture expressions. A new attribute captureExpressions is added into the snapshot.
844be15
to
d192119
Compare
What Does This Do
Previously watches, capture expressions allow to describe what exactly
we want to capture and put into a snapshot for a log probe.
When one or more capture expressions is defined, only the capture expressions are added to the Captures part of the snapshot. Expressions can be complex using the expression language and must return a value from which we start to capture the object graph following the limits that can be defined per capture expressions. A new attribute captureExpressions is added into the snapshot.
Motivation
implementation of the Capture Expressions RFC
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any useful labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: DEBUG-4261