-
Notifications
You must be signed in to change notification settings - Fork 312
Update telemetry tags in API10 #9708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🎯 Code Coverage 🔗 Commit SHA: 108528d | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~108528d9ac, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.017 s) : 0, 1016541
Total [baseline] (10.73 s) : 0, 10730263
Agent [candidate] (1.016 s) : 0, 1015642
Total [candidate] (10.822 s) : 0, 10821501
section appsec
Agent [baseline] (1.195 s) : 0, 1194681
Total [baseline] (10.973 s) : 0, 10972635
Agent [candidate] (1.208 s) : 0, 1207713
Total [candidate] (11.085 s) : 0, 11084878
section iast
Agent [baseline] (1.169 s) : 0, 1168874
Total [baseline] (11.031 s) : 0, 11031193
Agent [candidate] (1.161 s) : 0, 1161222
Total [candidate] (10.958 s) : 0, 10958430
section profiling
Agent [baseline] (1.179 s) : 0, 1178981
Total [baseline] (11.129 s) : 0, 11129098
Agent [candidate] (1.16 s) : 0, 1160371
Total [candidate] (11.125 s) : 0, 11125235
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~108528d9ac, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (692.475 ms) : 0, 692475
BytebuddyAgent [candidate] (692.268 ms) : 0, 692268
GlobalTracer [baseline] (241.969 ms) : 0, 241969
GlobalTracer [candidate] (241.404 ms) : 0, 241404
AppSec [baseline] (32.11 ms) : 0, 32110
AppSec [candidate] (32.214 ms) : 0, 32214
Debugger [baseline] (6.456 ms) : 0, 6456
Debugger [candidate] (6.355 ms) : 0, 6355
Remote Config [baseline] (698.022 µs) : 0, 698
Remote Config [candidate] (704.162 µs) : 0, 704
Telemetry [baseline] (9.276 ms) : 0, 9276
Telemetry [candidate] (9.322 ms) : 0, 9322
Flare Poller [baseline] (10.935 ms) : 0, 10935
Flare Poller [candidate] (10.831 ms) : 0, 10831
section appsec
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.473 ms) : 0, 1473
BytebuddyAgent [baseline] (718.27 ms) : 0, 718270
BytebuddyAgent [candidate] (727.633 ms) : 0, 727633
GlobalTracer [baseline] (234.123 ms) : 0, 234123
GlobalTracer [candidate] (236.959 ms) : 0, 236959
AppSec [baseline] (175.837 ms) : 0, 175837
AppSec [candidate] (176.044 ms) : 0, 176044
Debugger [baseline] (6.154 ms) : 0, 6154
Debugger [candidate] (6.132 ms) : 0, 6132
Remote Config [baseline] (636.97 µs) : 0, 637
Remote Config [candidate] (630.179 µs) : 0, 630
Telemetry [baseline] (8.479 ms) : 0, 8479
Telemetry [candidate] (8.525 ms) : 0, 8525
Flare Poller [baseline] (3.99 ms) : 0, 3990
Flare Poller [candidate] (3.996 ms) : 0, 3996
IAST [baseline] (24.677 ms) : 0, 24677
IAST [candidate] (25.009 ms) : 0, 25009
section iast
crashtracking [baseline] (1.48 ms) : 0, 1480
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (828.55 ms) : 0, 828550
BytebuddyAgent [candidate] (821.89 ms) : 0, 821890
GlobalTracer [baseline] (234.629 ms) : 0, 234629
GlobalTracer [candidate] (235.042 ms) : 0, 235042
AppSec [baseline] (35.61 ms) : 0, 35610
AppSec [candidate] (35.103 ms) : 0, 35103
Debugger [baseline] (6.197 ms) : 0, 6197
Debugger [candidate] (6.079 ms) : 0, 6079
Remote Config [baseline] (636.533 µs) : 0, 637
Remote Config [candidate] (603.675 µs) : 0, 604
Telemetry [baseline] (8.775 ms) : 0, 8775
Telemetry [candidate] (8.636 ms) : 0, 8636
Flare Poller [baseline] (4.293 ms) : 0, 4293
Flare Poller [candidate] (4.201 ms) : 0, 4201
IAST [baseline] (27.038 ms) : 0, 27038
IAST [candidate] (26.776 ms) : 0, 26776
section profiling
ProfilingAgent [baseline] (108.289 ms) : 0, 108289
ProfilingAgent [candidate] (108.632 ms) : 0, 108632
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.426 ms) : 0, 1426
BytebuddyAgent [baseline] (733.197 ms) : 0, 733197
BytebuddyAgent [candidate] (720.396 ms) : 0, 720396
GlobalTracer [baseline] (220.958 ms) : 0, 220958
GlobalTracer [candidate] (217.29 ms) : 0, 217290
AppSec [baseline] (33.276 ms) : 0, 33276
AppSec [candidate] (32.437 ms) : 0, 32437
Debugger [baseline] (8.151 ms) : 0, 8151
Debugger [candidate] (6.463 ms) : 0, 6463
Remote Config [baseline] (707.257 µs) : 0, 707
Remote Config [candidate] (698.949 µs) : 0, 699
Telemetry [baseline] (14.351 ms) : 0, 14351
Telemetry [candidate] (15.617 ms) : 0, 15617
Flare Poller [baseline] (5.095 ms) : 0, 5095
Flare Poller [candidate] (4.981 ms) : 0, 4981
Profiling [baseline] (109.148 ms) : 0, 109148
Profiling [candidate] (109.205 ms) : 0, 109205
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~108528d9ac, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1017731
Total [baseline] (8.678 s) : 0, 8677713
Agent [candidate] (1.024 s) : 0, 1023632
Total [candidate] (8.688 s) : 0, 8688007
section iast
Agent [baseline] (1.149 s) : 0, 1148868
Total [baseline] (9.35 s) : 0, 9350011
Agent [candidate] (1.157 s) : 0, 1157138
Total [candidate] (9.311 s) : 0, 9311474
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~108528d9ac, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (693.545 ms) : 0, 693545
BytebuddyAgent [candidate] (696.761 ms) : 0, 696761
GlobalTracer [baseline] (241.856 ms) : 0, 241856
GlobalTracer [candidate] (243.173 ms) : 0, 243173
AppSec [baseline] (32.382 ms) : 0, 32382
AppSec [candidate] (32.641 ms) : 0, 32641
Debugger [baseline] (6.443 ms) : 0, 6443
Debugger [candidate] (6.482 ms) : 0, 6482
Remote Config [baseline] (701.776 µs) : 0, 702
Remote Config [candidate] (704.013 µs) : 0, 704
Telemetry [baseline] (9.24 ms) : 0, 9240
Telemetry [candidate] (9.386 ms) : 0, 9386
Flare Poller [baseline] (10.956 ms) : 0, 10956
Flare Poller [candidate] (11.776 ms) : 0, 11776
section iast
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.478 ms) : 0, 1478
BytebuddyAgent [baseline] (814.37 ms) : 0, 814370
BytebuddyAgent [candidate] (819.933 ms) : 0, 819933
GlobalTracer [baseline] (231.27 ms) : 0, 231270
GlobalTracer [candidate] (232.782 ms) : 0, 232782
AppSec [baseline] (34.834 ms) : 0, 34834
AppSec [candidate] (35.346 ms) : 0, 35346
Debugger [baseline] (6.072 ms) : 0, 6072
Debugger [candidate] (6.102 ms) : 0, 6102
Remote Config [baseline] (625.027 µs) : 0, 625
Remote Config [candidate] (609.739 µs) : 0, 610
Telemetry [baseline] (8.546 ms) : 0, 8546
Telemetry [candidate] (8.593 ms) : 0, 8593
Flare Poller [baseline] (4.179 ms) : 0, 4179
Flare Poller [candidate] (4.192 ms) : 0, 4192
IAST [baseline] (26.272 ms) : 0, 26272
IAST [candidate] (26.751 ms) : 0, 26751
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~108528d9ac, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section baseline
no_agent (36.931 ms) : 36632, 37229
. : milestone, 36931,
appsec (48.642 ms) : 48208, 49076
. : milestone, 48642,
code_origins (42.677 ms) : 42308, 43046
. : milestone, 42677,
iast (44.928 ms) : 44536, 45319
. : milestone, 44928,
profiling (48.72 ms) : 48270, 49171
. : milestone, 48720,
tracing (44.178 ms) : 43790, 44565
. : milestone, 44178,
section candidate
no_agent (36.874 ms) : 36575, 37174
. : milestone, 36874,
appsec (46.949 ms) : 46537, 47360
. : milestone, 46949,
code_origins (43.53 ms) : 43165, 43894
. : milestone, 43530,
iast (46.027 ms) : 45627, 46427
. : milestone, 46027,
profiling (50.767 ms) : 50278, 51255
. : milestone, 50767,
tracing (44.837 ms) : 44463, 45211
. : milestone, 44837,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~108528d9ac, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section baseline
no_agent (4.178 ms) : 4126, 4229
. : milestone, 4178,
iast (9.688 ms) : 9526, 9850
. : milestone, 9688,
iast_FULL (14.202 ms) : 13922, 14483
. : milestone, 14202,
iast_GLOBAL (10.787 ms) : 10591, 10983
. : milestone, 10787,
profiling (9.202 ms) : 9057, 9347
. : milestone, 9202,
tracing (7.636 ms) : 7529, 7744
. : milestone, 7636,
section candidate
no_agent (4.28 ms) : 4230, 4329
. : milestone, 4280,
iast (9.859 ms) : 9692, 10026
. : milestone, 9859,
iast_FULL (13.889 ms) : 13617, 14162
. : milestone, 13889,
iast_GLOBAL (10.802 ms) : 10608, 10996
. : milestone, 10802,
profiling (9.148 ms) : 9006, 9290
. : milestone, 9148,
tracing (7.989 ms) : 7874, 8104
. : milestone, 7989,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~108528d9ac, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section baseline
no_agent (15.548 s) : 15548000, 15548000
. : milestone, 15548000,
appsec (14.86 s) : 14860000, 14860000
. : milestone, 14860000,
iast (18.635 s) : 18635000, 18635000
. : milestone, 18635000,
iast_GLOBAL (17.934 s) : 17934000, 17934000
. : milestone, 17934000,
profiling (14.892 s) : 14892000, 14892000
. : milestone, 14892000,
tracing (15.052 s) : 15052000, 15052000
. : milestone, 15052000,
section candidate
no_agent (15.03 s) : 15030000, 15030000
. : milestone, 15030000,
appsec (14.939 s) : 14939000, 14939000
. : milestone, 14939000,
iast (18.32 s) : 18320000, 18320000
. : milestone, 18320000,
iast_GLOBAL (18.129 s) : 18129000, 18129000
. : milestone, 18129000,
profiling (14.851 s) : 14851000, 14851000
. : milestone, 14851000,
tracing (15.27 s) : 15270000, 15270000
. : milestone, 15270000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~108528d9ac, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.756 ms) : 3535, 3976
. : milestone, 3756,
iast (2.208 ms) : 2145, 2271
. : milestone, 2208,
iast_GLOBAL (2.258 ms) : 2195, 2322
. : milestone, 2258,
profiling (2.073 ms) : 2021, 2124
. : milestone, 2073,
tracing (2.027 ms) : 1978, 2077
. : milestone, 2027,
section candidate
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.714 ms) : 3496, 3931
. : milestone, 3714,
iast (2.217 ms) : 2153, 2280
. : milestone, 2217,
iast_GLOBAL (2.264 ms) : 2200, 2328
. : milestone, 2264,
profiling (2.067 ms) : 2016, 2118
. : milestone, 2067,
tracing (2.04 ms) : 1991, 2089
. : milestone, 2040,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What Does This Do
Adds the
rule_variant
tag toSSRF
RASP telemetry metrics.Motivation
Additional Notes
RFC
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any useful labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]