Skip to content

Conversation

@robcarlan-datadog
Copy link

@robcarlan-datadog robcarlan-datadog commented Dec 10, 2025

What does this PR do?

Splits DSM specific tests into their own test files, and updates CODEOWNERS so that the DSM team owns these tests.

Tests still run e.g.:
amqplib: https://github.com/DataDog/dd-trace-js/actions/runs/20139301302/job/57801733910?pr=7076#step:4:492
confluentinc-kafka-javascript: https://github.com/DataDog/dd-trace-js/actions/runs/20139301302/job/57801734114?pr=7076#step:7:410
kafkajs: https://github.com/DataDog/dd-trace-js/actions/runs/20139301302/job/57801734472?pr=7076#step:7:49

Motivation

Plugin Checklist

Additional Notes

@github-actions
Copy link

github-actions bot commented Dec 10, 2025

Overall package size

Self size: 3.57 MB
Deduped: 4.46 MB
No deduping: 4.46 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.82%. Comparing base (237ea96) to head (339f97a).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7076      +/-   ##
==========================================
+ Coverage   84.80%   84.82%   +0.02%     
==========================================
  Files         514      515       +1     
  Lines       21987    22022      +35     
==========================================
+ Hits        18646    18681      +35     
  Misses       3341     3341              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Dec 10, 2025

Benchmarks

Benchmark execution time: 2025-12-11 22:25:47

Comparing candidate commit 339f97a in PR branch rob.carlan/DSMON-1162-dsm-test-ownership with baseline commit 237ea96 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 293 metrics, 27 unstable metrics.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 11, 2025

⚠️ Tests

⚠️ Warnings

🧪 1 Test failed

❄️ Known flaky: tests.parametric.test_otel_span_methods.Test_Otel_Span_Methods.test_otel_get_span_context[library_env0, parametric-nodejs] from system_tests_suite (Datadog) (Fix with Cursor)
AssertionError: assert '000ad69bfa8bddfa' == '3050715178851834'
  - 3050715178851834
  + 000ad69bfa8bddfa

self = <tests.parametric.test_otel_span_methods.Test_Otel_Span_Methods object at 0x7f61d4f62090>
test_agent = <utils.docker_fixtures._test_agent.TestAgentAPI object at 0x7f61d28952e0>
test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7f61d2706900>

    @bug(context.library < "[email protected]", reason="APMRP-360")
    @missing_feature(context.library == "rust", reason="APMSP-2059")
...

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
* Fix with Cursor requires Datadog plugin ≥v2.17.0
🔗 Commit SHA: 339f97a | Docs | Datadog PR Page | Was this helpful? Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants