Skip to content

Conversation

@tlhunter
Copy link
Member

@tlhunter tlhunter commented Dec 10, 2025

What does this PR do?

  • adds context propagation for websocket messages sent using the ws package

Motivation

  • feature parity with the other tracers
  • spec

@tlhunter tlhunter added semver-minor integration-ws AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos labels Dec 10, 2025
@github-actions
Copy link

github-actions bot commented Dec 10, 2025

Overall package size

Self size: 3.58 MB
Deduped: 4.46 MB
No deduping: 4.46 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 47.14286% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.65%. Comparing base (5856d72) to head (fe1120a).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
packages/datadog-plugin-ws/src/close.js 47.61% 11 Missing ⚠️
packages/datadog-plugin-ws/src/util.js 44.44% 10 Missing ⚠️
packages/datadog-plugin-ws/src/producer.js 42.85% 8 Missing ⚠️
packages/datadog-plugin-ws/src/receiver.js 42.85% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7077      +/-   ##
==========================================
- Coverage   84.83%   84.65%   -0.19%     
==========================================
  Files         515      522       +7     
  Lines       22022    22218     +196     
==========================================
+ Hits        18683    18808     +125     
- Misses       3339     3410      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Dec 10, 2025

Benchmarks

Benchmark execution time: 2025-12-12 20:38:00

Comparing candidate commit fe1120a in PR branch tlhunter/websocket-context-propagation with baseline commit 5856d72 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 286 metrics, 34 unstable metrics.

@tlhunter tlhunter force-pushed the tlhunter/websocket-context-propagation branch from 47328cc to 3f28727 Compare December 11, 2025 23:58
@tlhunter tlhunter marked this pull request as ready for review December 12, 2025 00:34
@tlhunter tlhunter requested review from a team as code owners December 12, 2025 00:34
const pointerLink = spanLinks.find(link =>
link.attributes && link.attributes['link.kind'] === 'span-pointer'
)
if (pointerLink) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is always falsey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos integration-ws semver-minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants