-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEBUG-3568 DRY transport options, remove HTTP.new method #4469
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 20523 Passed, 1372 Skipped, 3m 23.28s Total Time |
BenchmarksBenchmark execution time: 2025-03-19 15:13:10 Comparing candidate commit f0ab44b in PR branch Found 3 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics. scenario:line instrumentation - targeted
scenario:line instrumentation - untargeted
scenario:method instrumentation
|
b28262f
to
0097941
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4469 +/- ##
=======================================
Coverage 97.72% 97.73%
=======================================
Files 1385 1386 +1
Lines 84228 84159 -69
Branches 4281 4256 -25
=======================================
- Hits 82315 82255 -60
+ Misses 1913 1904 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What does this PR do?
Reduces duplication of existing transport code by removing the HTTP.new method which was identical for all transports and removing the code that copied agent settings into transport options.
Transport options are now explicitly enumerated (they are
api_version
andheaders
) instead of being a hash. This will make code that passed invalid or unknown options fail instead of silently doing nothing.Motivation:
Preparation for chunking of dynamic instrumentation event submissions
Change log entry
None
Additional Notes:
This PR should not contain any API changes. The
options
style arguments have been replaced with explicit keyword arguments in some methods but the set of arguments accepted remains the same as before.How to test the change?
Existing unit tests