Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEBUG-3568 Inject logger into transport code #4487

Merged
merged 4 commits into from
Mar 27, 2025
Merged

Conversation

p-datadog
Copy link
Member

@p-datadog p-datadog commented Mar 12, 2025

What does this PR do?

Injects logger into transport code instead of referencing Datadog.logger

Motivation:

Ability in the future to define different loggers for different dd-trace-rb components

Change log entry
None

Additional Notes:

N/A

How to test the change?
Existing unit tests

@github-actions github-actions bot added core Involves Datadog core libraries tracing labels Mar 12, 2025
Copy link

github-actions bot commented Mar 12, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-03-25 16:26:55 UTC

@pr-commenter
Copy link

pr-commenter bot commented Mar 12, 2025

Benchmarks

Benchmark execution time: 2025-03-27 14:32:06

Comparing candidate commit 51d7c22 in PR branch transport-logger with baseline commit e3b94b8 in branch master.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

scenario:line instrumentation - targeted

  • 🟥 throughput [-12183.767op/s; -11564.340op/s] or [-7.444%; -7.065%]

scenario:method instrumentation

  • 🟥 throughput [-14997.841op/s; -14395.356op/s] or [-8.348%; -8.012%]

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Mar 12, 2025

Datadog Report

Branch report: transport-logger
Commit report: 51d7c22
Test service: dd-trace-rb

✅ 0 Failed, 20782 Passed, 1370 Skipped, 3m 22.53s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 99.34641% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.76%. Comparing base (e3b94b8) to head (51d7c22).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
lib/datadog/di/transport/http/client.rb 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4487      +/-   ##
==========================================
- Coverage   97.77%   97.76%   -0.01%     
==========================================
  Files        1392     1392              
  Lines       84891    84938      +47     
  Branches     4277     4277              
==========================================
+ Hits        83001    83039      +38     
- Misses       1890     1899       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@p-datadog p-datadog force-pushed the transport-logger branch 3 times, most recently from f5eefff to 66b94d3 Compare March 25, 2025 12:10
@p-datadog p-datadog changed the title Inject logger into transport code DEBUG-3568 Inject logger into transport code Mar 25, 2025
@p-datadog p-datadog marked this pull request as ready for review March 25, 2025 16:26
@p-datadog p-datadog requested review from a team as code owners March 25, 2025 16:26
@p-datadog p-datadog merged commit c0a829b into master Mar 27, 2025
460 checks passed
@p-datadog p-datadog deleted the transport-logger branch March 27, 2025 20:01
@github-actions github-actions bot added this to the 2.13.0 milestone Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants