-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEBUG-3568 Inject logger into transport code #4487
Conversation
Thank you for updating Change log entry section 👏 Visited at: 2025-03-25 16:26:55 UTC |
BenchmarksBenchmark execution time: 2025-03-27 14:32:06 Comparing candidate commit 51d7c22 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics. scenario:line instrumentation - targeted
scenario:method instrumentation
|
Datadog ReportBranch report: ✅ 0 Failed, 20782 Passed, 1370 Skipped, 3m 22.53s Total Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4487 +/- ##
==========================================
- Coverage 97.77% 97.76% -0.01%
==========================================
Files 1392 1392
Lines 84891 84938 +47
Branches 4277 4277
==========================================
+ Hits 83001 83039 +38
- Misses 1890 1899 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f5eefff
to
66b94d3
Compare
66b94d3
to
b650342
Compare
What does this PR do?
Injects
logger
into transport code instead of referencingDatadog.logger
Motivation:
Ability in the future to define different loggers for different dd-trace-rb components
Change log entry
None
Additional Notes:
N/A
How to test the change?
Existing unit tests