[APPSEC-57032] Add usr.login
to Kit::AppSec::Events
#4508
Merged
+138
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
appsec.events.<event>.usr.login
with a fallback value asusr.id
usr.login
when available tolibddwaf
Motivation:
This is an intermediate step to comply with v3 ATO behavior in which it is expected (by the backend) that we alway pass login data
appsec.events.<event>.usr.login
and in addition we passusr.login
tolibddwaf
when available.Change log entry
No. Announcement will be done as a part of #4433
Additional Notes:
Unfortunately, in the current state the
Kit::AppSec::Events
andKit::Identity
are coupled, which led to some questionable areas.How to test the change?
CI should be fine