Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenSearch resource names to be relative instead of full path #4509

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sarahchen6
Copy link
Contributor

@sarahchen6 sarahchen6 commented Mar 18, 2025

What does this PR do?
This PR updates OpenSearch resource names to use relative paths, instead of full paths, similar to how ElasticSearch does.

Motivation:
Resolve customer issue migrating from ElasticSearch to OpenSearch: #4474

Change log entry
Yes. Tracing: Update OpenSearch integration to include a feature flag for resource names. By default and with the existing implementation, the resource name is set to the full URL path; however, now resource names can instead be set to use relative paths.

Additional Notes:

How to test the change?
Tested through unit tests (bundle exec rspec spec/datadog/tracing/contrib/opensearch/patcher_spec.rb).

@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Mar 18, 2025
@pr-commenter
Copy link

pr-commenter bot commented Mar 18, 2025

Benchmarks

Benchmark execution time: 2025-03-20 14:59:13

Comparing candidate commit 8c436bc in PR branch sarahchen6/update-opensearch-resource-names with baseline commit 7d88b81 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Mar 18, 2025

Datadog Report

Branch report: sarahchen6/update-opensearch-resource-names
Commit report: 8c436bc
Test service: dd-trace-rb

✅ 0 Failed, 20792 Passed, 1370 Skipped, 3m 15.29s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (7d88b81) to head (8c436bc).
Report is 40 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4509      +/-   ##
==========================================
+ Coverage   97.70%   97.74%   +0.04%     
==========================================
  Files        1381     1388       +7     
  Lines       83973    84659     +686     
  Branches     4251     4276      +25     
==========================================
+ Hits        82043    82752     +709     
+ Misses       1930     1907      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sarahchen6 sarahchen6 marked this pull request as ready for review March 18, 2025 15:28
@sarahchen6 sarahchen6 requested a review from a team as a code owner March 18, 2025 15:28
@sarahchen6 sarahchen6 force-pushed the sarahchen6/update-opensearch-resource-names branch from 8f0b832 to 46300e5 Compare March 18, 2025 19:16
@sarahchen6 sarahchen6 requested a review from marcotc March 20, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants