Skip to content

DEBUG-3700 Do not initialize components from on crashtracking fork handler #4619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

p-datadog
Copy link
Member

What does this PR do?

Motivation:

Change log entry

Additional Notes:

How to test the change?

@github-actions github-actions bot added the core Involves Datadog core libraries label May 1, 2025
Copy link

github-actions bot commented May 1, 2025

👋 Hey @p-datadog, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-05-01 20:54:22 UTC

@p-datadog p-datadog changed the title Do not initialize components from on crashtracking fork handler DEBUG-3700 Do not initialize components from on crashtracking fork handler May 1, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (65cb319) to head (dfb0d36).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4619   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files        1412     1412           
  Lines       86236    86235    -1     
  Branches     4348     4348           
=======================================
  Hits        84307    84307           
+ Misses       1929     1928    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented May 1, 2025

Datadog Report

Branch report: crashtracking-component-tree
Commit report: dfb0d36
Test service: dd-trace-rb

✅ 0 Failed, 21033 Passed, 1372 Skipped, 3m 37.7s Total Time

@pr-commenter
Copy link

pr-commenter bot commented May 1, 2025

Benchmarks

Benchmark execution time: 2025-05-07 22:14:41

Comparing candidate commit dfb0d36 in PR branch crashtracking-component-tree with baseline commit 65cb319 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:profiling - Allocations ()

  • 🟥 throughput [-337952.112op/s; -292603.103op/s] or [-10.258%; -8.881%]

@ivoanjo
Copy link
Member

ivoanjo commented May 2, 2025

I'm curious what drove this change (I checked the JIRA ticket and didn't have any details about this).

In particular, the at_fork in the crashtracker gets applied once the crashtracker is initialized by the components, so I don't understand in what situation we'd go back to a case where the components are not initialized again after that?

@p-datadog p-datadog force-pushed the crashtracking-component-tree branch from ad849bc to dfb0d36 Compare May 7, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants