Skip to content

SDCD-1030: adding service catalog link naming parameters to the dora and cd visibility docs #28283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Mar 25, 2025

Conversation

henrywalsh
Copy link
Contributor

Our code looks for specifically links with the name of the service, or "Souce" (the name a link is given when setting up a code repository in the service catalog. This had led to some confusion around why links weren't being considered and we realized there was a gap in our documentation.

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. Your branch name MUST follow the <slack_username>/<branch_name> convention, or your pull request will not pass in CI. If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

Copy link
Contributor

Base automatically changed from henry.walsh/SDCD-887/addGitLabToDoraSetup to master March 24, 2025 13:21
@henrywalsh henrywalsh marked this pull request as ready for review March 24, 2025 13:27
@henrywalsh henrywalsh requested review from a team as code owners March 24, 2025 13:27
@henrywalsh henrywalsh requested a review from liashenko March 24, 2025 13:27
Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@aliciascott
Copy link
Contributor

Hi @henrywalsh this looks good but note there is a merge conflict you'll want to resolve before this can be merged, let me know if you need any help with this!

@henrywalsh
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 25, 2025

View all feedbacks in Devflow UI.
2025-03-25 09:24:58 UTC ℹ️ Start processing command /merge


2025-03-25 09:25:05 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-03-25 09:26:35 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 9m (p90).


2025-03-25 09:36:23 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 77328ab into master Mar 25, 2025
15 of 18 checks passed
@dd-mergequeue dd-mergequeue bot deleted the henry.walsh/SDCD-1030/pathSpecLinkName branch March 25, 2025 09:36
wdhif pushed a commit that referenced this pull request Mar 25, 2025
…and cd visibility docs (#28283)

Co-authored-by: maycmlee <[email protected]>
Signed-off-by: Wassim DHIF <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants