-
Notifications
You must be signed in to change notification settings - Fork 1.2k
SDCD-1030: adding service catalog link naming parameters to the dora and cd visibility docs #28283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDCD-1030: adding service catalog link naming parameters to the dora and cd visibility docs #28283
Conversation
…is in closed preview
…DoraSetup' into henry.walsh/SDCD-887/addGitLabToDoraSetup
Co-authored-by: Janine Chan <[email protected]>
Co-authored-by: Janine Chan <[email protected]>
Preview links (active after the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Hi @henrywalsh this looks good but note there is a merge conflict you'll want to resolve before this can be merged, let me know if you need any help with this! |
/merge |
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
The expected merge time in
|
…and cd visibility docs (#28283) Co-authored-by: maycmlee <[email protected]> Signed-off-by: Wassim DHIF <[email protected]>
Our code looks for specifically links with the name of the service, or "Souce" (the name a link is given when setting up a code repository in the service catalog. This had led to some confusion around why links weren't being considered and we realized there was a gap in our documentation.
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. Your branch name MUST follow the
<slack_username>/<branch_name>
convention, or your pull request will not pass in CI. If your branch doesn't follow this format, rename it or create a new branch and PR.To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes