-
Notifications
You must be signed in to change notification settings - Fork 1.2k
GCP-2948: Add region filtering docs to GCP quick start #33617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
GCP-2948: Add region filtering docs to GCP quick start #33617
Conversation
Preview links (active after the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm liking the language, it's succinct yet informative/accurate. I agree that having a screenshot of the UI feature would be useful for customers to see here, but not blocking on that
mauerbac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed this looks good! A screenshot wouldn't hurt either
|
|
||
| {{% collapse-content title="Limit metric collection by Google Cloud region, and by global resources" level="h4" %}} | ||
|
|
||
| Under the **Metric Collection** tab in Datadog's [Google Cloud integration page][11], deselect which region for Datadog to exclude from metrics collection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it be multiple regions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call can update since there may be multiple regions to deselect.
buraizu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looping me in, this looks good overall but suggesting a couple of minor phrasing updates
|
|
||
| Under the **Metric Collection** tab in Datadog's [Google Cloud integration page][11], deselect which region for Datadog to exclude from metrics collection. | ||
|
|
||
| Additionally, users can specify additional locations not listed and disable any global metrics not associated with a region. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Additionally, users can specify additional locations not listed and disable any global metrics not associated with a region. | |
| You can also specify additional locations not listed, and disable collection of any global metrics not associated with a region. |
|
|
||
| {{% collapse-content title="Limit metric collection by Google Cloud region, and by global resources" level="h4" %}} | ||
|
|
||
| Under the **Metric Collection** tab in Datadog's [Google Cloud integration page][11], deselect which region for Datadog to exclude from metrics collection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Under the **Metric Collection** tab in Datadog's [Google Cloud integration page][11], deselect which region for Datadog to exclude from metrics collection. | |
| Under the **Metric Collection** tab in Datadog's [Google Cloud integration page][11], deselect which regions to exclude from metric collection. |
Primary Reviewers: @buraizu @sujaysdesai
What does this PR do? What is the motivation?
Adding documentation on our QuickStart guide around the new region filtering feature that will allow customers to disable metric collection for regions, multi-region, and global resources.
Preview Link: https://docs-staging.datadoghq.com/dan.trujillo/GCP-2948-add-region-filterng-docs-gcp/getting_started/integrations/google_cloud/?tab=orglevel#google-cloud-integrations