Get rid of logs in interactive CLI commands #1488
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR aims at removing the logs from the interactive CLI commands executed by end users.
Currently, when a user runs an interactive CLI command like
agent status
oragent configcheck
, the human readable output is polluted by logs:An even more nastier effect is that, because of those logs, the output of commands run with
--json
isn’t JSON valid:This is because the
DD_LOG_LEVEL
environment variable is set not only for the main container process (the agent daemon itself), but also for all the commands interactively executed withkubectl exec
.This fix sets the
DD_LOG_LEVEL
environment variable only for the main container process directly inside thecommand:
property. So, commands executed viakubectl exec
don’t haveDD_LOG_LEVEL
set anymore:The JSON commands’ output is now JSON valid:
Which issue this PR fixes
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
.github/helm-docs.sh
)CHANGELOG.md
has been updatedREADME.md
make update-test-baselines
)