feat(agent): Add dogstatsd.enabled flag to disable it when using a standalone DogStatsD #1590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We're running dogstatsd in kubernetes as a standalone daemonset using https://github.com/DataDog/datadog-agent/blob/main/Dockerfiles/dogstatsd/alpine/README.md as we want the statsd UDP port to be up and running as soon as possible when we boot new kubernetes nodes.
There's currently no obvious way in the helm chart to instruct the datadog agent not to use dogstatsd, and ensure that an
8125 UDP
port doesn't get assigned to the agent container.This is key when running a separate dogstatsd daemonset, both in host networking mode, so that the daemonset don't clash on port
8125 UDP
, without having to resort to brittle workarounds, as redefining the dogstatsd port to a different, when we shouldn't be binding the container port at all.Which issue this PR fixes
Fixes #1589
Special notes for your reviewer:
Checklist
.github/helm-docs.sh
)CHANGELOG.md
has been updatedREADME.md
make update-test-baselines
)