Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agent): Add dogstatsd.enabled flag to disable it when using a standalone DogStatsD #1590

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rymir
Copy link

@rymir rymir commented Oct 28, 2024

What this PR does / why we need it:

We're running dogstatsd in kubernetes as a standalone daemonset using https://github.com/DataDog/datadog-agent/blob/main/Dockerfiles/dogstatsd/alpine/README.md as we want the statsd UDP port to be up and running as soon as possible when we boot new kubernetes nodes.

There's currently no obvious way in the helm chart to instruct the datadog agent not to use dogstatsd, and ensure that an 8125 UDP port doesn't get assigned to the agent container.

This is key when running a separate dogstatsd daemonset, both in host networking mode, so that the daemonset don't clash on port 8125 UDP, without having to resort to brittle workarounds, as redefining the dogstatsd port to a different, when we shouldn't be binding the container port at all.

Which issue this PR fixes

Fixes #1589

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

@rymir rymir requested a review from a team as a code owner October 28, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No easy way to disable dogstatsd and avoid the agent container port to be defined
1 participant