Skip to content

Modernize bs4 interface #20415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025
+3 −2
Merged

Modernize bs4 interface #20415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6543f27
Modernize bs4 interface
emmanuel-ferdman Jun 3, 2025
17d7aba
Modernize bs4 interface
emmanuel-ferdman Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions spark/changelog.d/20415.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Modernize bs4 interface by replacing deprecated 'findAll' with 'find_all'
4 changes: 2 additions & 2 deletions spark/datadog_checks/spark/spark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ def _describe_app(self, property, running_apps, addl_tags):
yield (response.json(), [f'app_name:{app_name}'] + addl_tags)
except JSONDecodeError:
self.log.debug(
'Skipping metrics for %s from app %s due to unparseable JSON payload.', property, app_name
'Skipping metrics for %s from app %s due to unparsable JSON payload.', property, app_name
)
continue

Expand Down Expand Up @@ -698,7 +698,7 @@ def _parse_proxy_redirect_url(html_content):

soup = BeautifulSoup(html_content, 'html.parser')
redirect_link = None
for link in soup.findAll('a'):
for link in soup.find_all('a'):
href = link.get('href')
if 'proxyapproved' in href:
redirect_link = href
Expand Down
Loading