Initial implementation of OTel process context support #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivoanjo
reviewed
Aug 26, 2025
There was a problem hiding this comment.
Ah, I can see why having a no-op fallback may be useful for implementers. I'll borrow steal build on this idea and add it on the reference implementation so we don't need to maintain it separately
There was a problem hiding this comment.
Update: https://github.com/DataDog/fullhost-code-hotspots-wip/pull/2 now has a no-op implementation
ddprof-lib/src/main/java/com/datadoghq/profiler/OTelContext.java
Outdated
Show resolved
Hide resolved
ddprof-lib/src/main/java/com/datadoghq/profiler/OTelContext.java
Outdated
Show resolved
Hide resolved
ddprof-lib/src/main/java/com/datadoghq/profiler/OTelContext.java
Outdated
Show resolved
Hide resolved
ddprof-test/src/test/java/com/datadoghq/profiler/context/ProcessContextTest.java
Outdated
Show resolved
Hide resolved
ddprof-test/src/test/java/com/datadoghq/profiler/context/ProcessContextTest.java
Outdated
Show resolved
Hide resolved
ddprof-test/src/test/java/com/datadoghq/profiler/context/ProcessContextTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Ivo Anjo <[email protected]>
- Add comprehensive gradle patching for otel_process_ctx.c to .cpp conversion - Add Linux preprocessor guards and C++ explicit casts for compilation - Fix gradle task dependencies and caching for proper file handling - Implement proper publish/update API usage in JNI setProcessCtx0 - Add native read functionality through JNI wrapper - Update ProcessContextTest for test resilience and native read testing - Resolve all compilation failures in gtest tasks 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
ivoanjo
approved these changes
Aug 26, 2025
ddprof-test/src/test/java/com/datadoghq/profiler/context/ProcessContextTest.java
Outdated
Show resolved
Hide resolved
ddprof-test/src/test/java/com/datadoghq/profiler/context/ProcessContextTest.java
Outdated
Show resolved
Hide resolved
ddprof-test/src/test/java/com/datadoghq/profiler/context/ProcessContextTest.java
Outdated
Show resolved
Hide resolved
ddprof-test/src/test/java/com/datadoghq/profiler/context/ProcessContextTest.java
Outdated
Show resolved
Hide resolved
zhengyu123
requested changes
Aug 27, 2025
ddprof-lib/src/main/java/com/datadoghq/profiler/OTelContext.java
Outdated
Show resolved
Hide resolved
ddprof-lib/src/main/java/com/datadoghq/profiler/OTelContext.java
Outdated
Show resolved
Hide resolved
|
I've opened #267 to bring the latest version of the reference library on top of this PR/branch :) |
…ference library (#267)
|
@zhengyu123 I addressed the locking. If you could re-review and potentially approve ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
It adds the support for publishing process context in OTel friendly way.
Additional Notes:
See https://github.com/DataDog/fullhost-code-hotspots-wip/pull/2
How to test the change?:
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!