-
Notifications
You must be signed in to change notification settings - Fork 14
build: update ffi build script and builder for mac x86_64 cross-compilation #866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #866 +/- ##
==========================================
- Coverage 71.83% 71.81% -0.03%
==========================================
Files 335 335
Lines 50330 50330
==========================================
- Hits 36156 36144 -12
- Misses 14174 14186 +12
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2025-04-03 19:18:49 Comparing candidate commit 47444c4 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Arguably this could go in as-is, and we could fix the sharp edges separately, up to you :D
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
@ivoanjo https://gitlab.ddbuild.io/DataDog/apm-reliability/libddprof-build/-/jobs/801726110 And to add a target in that case, I need to download tarballs for 32bit targets, i686-alpine-linux-musl, i686-unknown-linux-gnu, i686-alpine-linux-musl, and i686-unknown-linux-gnu manually. Though I've already done most of work, I don't want to spend more time on supporting 32bits where we might not get that much value as you pointed out earlier. So will close PR for now, and will just revert the libddprof changes adding 32bit linux builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.
PROF-11580