Skip to content

Conversation

sanchda
Copy link
Contributor

@sanchda sanchda commented Apr 3, 2025

What does this PR do?

Rust 1.86 changed code emission so more operations are handled safely. Unfortunately, this made it a little harder to trigger true segmentation faults within the language.

This PR uses some inline assembly to make this situation occur on supported platforms.

Motivation

Make tests more correct

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@pr-commenter
Copy link

pr-commenter bot commented Apr 3, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-04-09 17:12:27

Comparing candidate commit 1b7f4d9 in PR branch sanchda/fix_crashtracker_test_for_186 with baseline commit f03ceab in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1b7f4d9 1744218030 sanchda/fix_crashtracker_test_for_186
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 6.221ms 6.235ms ± 0.007ms 6.234ms ± 0.004ms 6.238ms 6.244ms 6.257ms 6.287ms 0.84% 2.712 15.360 0.12% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.234ms; 6.236ms] or [-0.016%; +0.016%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1b7f4d9 1744218030 sanchda/fix_crashtracker_test_for_186
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.747µs 26.081µs ± 10.816µs 18.328µs ± 0.297µs 34.809µs 44.235µs 47.018µs 87.528µs 377.56% 1.781 5.890 41.36% 0.765µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.583µs; 27.580µs] or [-5.747%; +5.747%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1b7f4d9 1744218030 sanchda/fix_crashtracker_test_for_186
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.925µs 4.988µs ± 0.043µs 5.004µs ± 0.036µs 5.018µs 5.042µs 5.057µs 5.101µs 1.95% -0.003 -1.442 0.86% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [4.982µs; 4.994µs] or [-0.119%; +0.119%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1b7f4d9 1744218030 sanchda/fix_crashtracker_test_for_186
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 244.760ns 254.377ns ± 12.108ns 248.290ns ± 1.822ns 255.712ns 283.699ns 285.673ns 288.945ns 16.37% 1.537 0.891 4.75% 0.856ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [252.699ns; 256.055ns] or [-0.660%; +0.660%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1b7f4d9 1744218030 sanchda/fix_crashtracker_test_for_186
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 53.757ms 53.886ms ± 0.097ms 53.867ms ± 0.036ms 53.910ms 54.017ms 54.298ms 54.469ms 1.12% 3.017 12.484 0.18% 0.007ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [53.872ms; 53.899ms] or [-0.025%; +0.025%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1b7f4d9 1744218030 sanchda/fix_crashtracker_test_for_186
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 147.963µs 149.107µs ± 0.335µs 149.036µs ± 0.130µs 149.210µs 149.686µs 150.347µs 150.983µs 1.31% 1.678 7.854 0.22% 0.024µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [149.060µs; 149.153µs] or [-0.031%; +0.031%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1b7f4d9 1744218030 sanchda/fix_crashtracker_test_for_186
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 68.005µs 68.178µs ± 0.189µs 68.154µs ± 0.047µs 68.206µs 68.316µs 68.494µs 70.382µs 3.27% 8.725 94.399 0.28% 0.013µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [68.152µs; 68.204µs] or [-0.038%; +0.038%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1b7f4d9 1744218030 sanchda/fix_crashtracker_test_for_186
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.893µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.914µs 3.916µs 3.917µs 3.921µs 0.22% -1.650 10.149 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 255051257.220op/s 255625205.696op/s ± 184222.998op/s 255612627.264op/s ± 98147.959op/s 255698245.663op/s 255923815.285op/s 256025599.607op/s 256892038.508op/s 0.50% 1.670 10.301 0.07% 13026.533op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 76.762µs 77.485µs ± 0.462µs 77.394µs ± 0.320µs 77.785µs 78.345µs 78.719µs 79.152µs 2.27% 0.884 0.467 0.59% 0.033µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12633985.126op/s 12906225.605op/s ± 76531.432op/s 12920867.205op/s ± 53591.268op/s 12968616.301op/s 13000379.113op/s 13008187.450op/s 13027240.971op/s 0.82% -0.854 0.382 0.59% 5411.589op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 70.846µs 71.353µs ± 0.271µs 71.316µs ± 0.186µs 71.507µs 71.923µs 72.080µs 72.269µs 1.34% 0.793 0.376 0.38% 0.019µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13837191.604op/s 14015099.912op/s ± 53114.075op/s 14022190.852op/s ± 36579.733op/s 14058200.249op/s 14084470.493op/s 14102453.606op/s 14115097.327op/s 0.66% -0.773 0.332 0.38% 3755.732op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.897µs 3.914µs ± 0.003µs 3.913µs ± 0.001µs 3.915µs 3.918µs 3.919µs 3.924µs 0.26% -0.877 7.881 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254867978.387op/s 255520236.763op/s ± 175354.105op/s 255528005.871op/s ± 88851.477op/s 255607732.277op/s 255772468.017op/s 256011503.822op/s 256606744.891op/s 0.42% 0.896 7.966 0.07% 12399.408op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 67.059µs 67.762µs ± 0.380µs 67.742µs ± 0.230µs 67.961µs 68.442µs 68.805µs 69.028µs 1.90% 0.535 0.350 0.56% 0.027µs 1 200
credit_card/is_card_number/378282246310005 throughput 14486914.597op/s 14757986.453op/s ± 82549.456op/s 14761991.565op/s ± 50308.578op/s 14814250.570op/s 14886234.191op/s 14906331.431op/s 14912310.576op/s 1.02% -0.501 0.285 0.56% 5837.128op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.748µs 51.844µs ± 0.030µs 51.838µs ± 0.018µs 51.861µs 51.903µs 51.919µs 51.939µs 0.20% 0.587 0.561 0.06% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19253260.784op/s 19288520.557op/s ± 11190.448op/s 19291042.205op/s ± 6534.699op/s 19295958.462op/s 19303060.404op/s 19310573.737op/s 19324302.243op/s 0.17% -0.584 0.559 0.06% 791.284op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.030µs 6.043µs ± 0.011µs 6.040µs ± 0.003µs 6.044µs 6.071µs 6.084µs 6.112µs 1.19% 2.903 9.867 0.19% 0.001µs 1 200
credit_card/is_card_number/x371413321323331 throughput 163610624.508op/s 165477570.262op/s ± 310905.907op/s 165554185.885op/s ± 80574.557op/s 165632713.213op/s 165714919.849op/s 165833704.511op/s 165838293.535op/s 0.17% -2.884 9.712 0.19% 21984.368op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.895µs 3.914µs ± 0.005µs 3.913µs ± 0.001µs 3.915µs 3.919µs 3.922µs 3.966µs 1.35% 6.639 74.529 0.12% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 252161027.901op/s 255501499.012op/s ± 303264.980op/s 255553949.182op/s ± 94873.180op/s 255614014.046op/s 255719564.244op/s 255861496.312op/s 256711870.453op/s 0.45% -6.523 73.029 0.12% 21444.072op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 66.011µs 66.274µs ± 0.177µs 66.243µs ± 0.082µs 66.331µs 66.642µs 66.905µs 67.275µs 1.56% 2.265 7.479 0.27% 0.013µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14864346.701op/s 15088922.619op/s ± 40065.194op/s 15095998.390op/s ± 18649.947op/s 15113831.521op/s 15132293.805op/s 15142357.278op/s 15148997.869op/s 0.35% -2.230 7.267 0.26% 2833.037op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 59.484µs 59.630µs ± 0.047µs 59.628µs ± 0.031µs 59.661µs 59.706µs 59.739µs 59.751µs 0.21% -0.017 0.196 0.08% 0.003µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16736061.550op/s 16770065.473op/s ± 13090.778op/s 16770772.736op/s ± 8735.290op/s 16779247.846op/s 16791524.230op/s 16800761.888op/s 16811199.621op/s 0.24% 0.023 0.198 0.08% 925.658op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.895µs 3.913µs ± 0.003µs 3.913µs ± 0.001µs 3.915µs 3.918µs 3.920µs 3.923µs 0.25% -1.181 10.038 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254923604.670op/s 255533260.711op/s ± 182241.796op/s 255548408.693op/s ± 94908.548op/s 255625248.787op/s 255799101.689op/s 255926817.702op/s 256770991.807op/s 0.48% 1.204 10.188 0.07% 12886.441op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 56.195µs 56.464µs ± 0.098µs 56.463µs ± 0.061µs 56.524µs 56.646µs 56.680µs 56.693µs 0.41% 0.038 -0.134 0.17% 0.007µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17638902.143op/s 17710465.905op/s ± 30583.375op/s 17710859.476op/s ± 19045.801op/s 17728413.995op/s 17761340.756op/s 17775978.809op/s 17795097.451op/s 0.48% -0.028 -0.133 0.17% 2162.571op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.729µs 51.834µs ± 0.035µs 51.834µs ± 0.017µs 51.850µs 51.886µs 51.919µs 52.044µs 0.40% 0.749 6.374 0.07% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19214694.443op/s 19292384.023op/s ± 13097.832op/s 19292482.684op/s ± 6350.535op/s 19298830.491op/s 19314081.997op/s 19328096.950op/s 19331339.968op/s 0.20% -0.733 6.300 0.07% 926.157op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.026µs 6.042µs ± 0.014µs 6.038µs ± 0.003µs 6.041µs 6.074µs 6.082µs 6.115µs 1.28% 2.704 8.047 0.23% 0.001µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 163529615.312op/s 165518077.171op/s ± 371164.603op/s 165621151.876op/s ± 69765.484op/s 165690133.572op/s 165813509.496op/s 165904118.772op/s 165942618.747op/s 0.19% -2.686 7.906 0.22% 26245.301op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.912µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [255599674.160op/s; 255650737.231op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [77.421µs; 77.549µs] or [-0.083%; +0.083%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12895619.085op/s; 12916832.126op/s] or [-0.082%; +0.082%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [71.315µs; 71.390µs] or [-0.053%; +0.053%] None None None
credit_card/is_card_number/ 378282246310005 throughput [14007738.812op/s; 14022461.012op/s] or [-0.053%; +0.053%] None None None
credit_card/is_card_number/37828224631 execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631 throughput [255495934.371op/s; 255544539.156op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [67.709µs; 67.815µs] or [-0.078%; +0.078%] None None None
credit_card/is_card_number/378282246310005 throughput [14746545.892op/s; 14769427.014op/s] or [-0.078%; +0.078%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [51.840µs; 51.848µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19286969.668op/s; 19290071.445op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.042µs; 6.045µs] or [-0.026%; +0.026%] None None None
credit_card/is_card_number/x371413321323331 throughput [165434481.693op/s; 165520658.830op/s] or [-0.026%; +0.026%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.913µs; 3.915µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/ throughput [255459469.403op/s; 255543528.622op/s] or [-0.016%; +0.016%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [66.250µs; 66.299µs] or [-0.037%; +0.037%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15083369.968op/s; 15094475.269op/s] or [-0.037%; +0.037%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [59.624µs; 59.637µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [16768251.217op/s; 16771879.729op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255508003.750op/s; 255558517.671op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [56.450µs; 56.477µs] or [-0.024%; +0.024%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [17706227.343op/s; 17714704.466op/s] or [-0.024%; +0.024%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [51.829µs; 51.839µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19290568.790op/s; 19294199.257op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.040µs; 6.044µs] or [-0.031%; +0.031%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165466637.327op/s; 165569517.015op/s] or [-0.031%; +0.031%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1b7f4d9 1744218030 sanchda/fix_crashtracker_test_for_186
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 31.937µs 32.746µs ± 1.093µs 32.069µs ± 0.072µs 34.271µs 34.377µs 35.052µs 36.269µs 13.10% 0.998 -0.723 3.33% 0.077µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [32.594µs; 32.897µs] or [-0.462%; +0.462%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1b7f4d9 1744218030 sanchda/fix_crashtracker_test_for_186
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.317µs 2.373µs ± 0.020µs 2.376µs ± 0.014µs 2.385µs 2.408µs 2.412µs 2.420µs 1.84% -0.076 -0.318 0.83% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.370µs; 2.375µs] or [-0.115%; +0.115%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1b7f4d9 1744218030 sanchda/fix_crashtracker_test_for_186
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.189µs 3.212µs ± 1.436µs 3.015µs ± 0.023µs 3.037µs 3.709µs 14.007µs 14.994µs 397.26% 7.399 55.643 44.62% 0.102µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.012µs; 3.411µs] or [-6.199%; +6.199%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1b7f4d9 1744218030 sanchda/fix_crashtracker_test_for_186
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 502.579µs 504.033µs ± 0.496µs 504.016µs ± 0.339µs 504.361µs 504.810µs 505.154µs 505.561µs 0.31% -0.011 0.154 0.10% 0.035µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1978001.329op/s 1983999.560op/s ± 1952.964op/s 1984062.248op/s ± 1337.125op/s 1985391.216op/s 1987238.364op/s 1988367.559op/s 1989738.916op/s 0.29% 0.017 0.153 0.10% 138.095op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 453.613µs 454.999µs ± 1.305µs 454.904µs ± 0.345µs 455.190µs 455.745µs 458.509µs 466.791µs 2.61% 7.324 62.824 0.29% 0.092µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2142288.671op/s 2197824.640op/s ± 6173.219op/s 2198266.853op/s ± 1665.837op/s 2200048.121op/s 2202484.329op/s 2204096.983op/s 2204521.142op/s 0.28% -7.228 61.675 0.28% 436.512op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 177.331µs 177.756µs ± 0.170µs 177.731µs ± 0.089µs 177.861µs 178.092µs 178.196µs 178.368µs 0.36% 0.602 0.895 0.10% 0.012µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5606374.530op/s 5625683.747op/s ± 5367.321op/s 5626472.362op/s ± 2805.137op/s 5629015.543op/s 5633048.444op/s 5637730.621op/s 5639182.803op/s 0.23% -0.595 0.885 0.10% 379.527op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.588µs 37.675µs ± 0.046µs 37.669µs ± 0.028µs 37.699µs 37.754µs 37.777µs 37.997µs 0.87% 2.010 10.638 0.12% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26317823.911op/s 26542615.179op/s ± 32346.602op/s 26546705.739op/s ± 19884.394op/s 26564841.817op/s 26580341.189op/s 26592678.825op/s 26604360.062op/s 0.22% -1.979 10.366 0.12% 2287.250op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.190µs 48.313µs ± 0.052µs 48.309µs ± 0.033µs 48.343µs 48.399µs 48.443µs 48.514µs 0.43% 0.467 0.879 0.11% 0.004µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20612582.252op/s 20698506.739op/s ± 22325.219op/s 20700256.363op/s ± 14007.527op/s 20713610.059op/s 20730740.989op/s 20749132.796op/s 20751158.547op/s 0.25% -0.458 0.863 0.11% 1578.631op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [503.964µs; 504.102µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1983728.898op/s; 1984270.222op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [454.818µs; 455.180µs] or [-0.040%; +0.040%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2196969.091op/s; 2198680.189op/s] or [-0.039%; +0.039%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [177.733µs; 177.780µs] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5624939.888op/s; 5626427.606op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.669µs; 37.682µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26538132.251op/s; 26547098.107op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [48.305µs; 48.320µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20695412.678op/s; 20701600.800op/s] or [-0.015%; +0.015%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1b7f4d9 1744218030 sanchda/fix_crashtracker_test_for_186
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 208.704µs 209.102µs ± 0.447µs 209.057µs ± 0.095µs 209.162µs 209.383µs 209.538µs 214.979µs 2.83% 11.453 147.878 0.21% 0.032µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4651622.544op/s 4782381.728op/s ± 9982.325op/s 4783379.033op/s ± 2180.976op/s 4785458.587op/s 4788142.868op/s 4789389.574op/s 4791464.804op/s 0.17% -11.333 145.756 0.21% 705.857op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.631µs 18.688µs ± 0.033µs 18.681µs ± 0.021µs 18.709µs 18.752µs 18.767µs 18.790µs 0.58% 0.501 -0.212 0.18% 0.002µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 53220572.435op/s 53511144.366op/s ± 94701.387op/s 53529455.538op/s ± 59671.144op/s 53572931.025op/s 53649752.543op/s 53665882.007op/s 53674846.040op/s 0.27% -0.492 -0.224 0.18% 6696.399op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.858µs 10.950µs ± 0.050µs 10.943µs ± 0.039µs 10.990µs 11.030µs 11.055µs 11.078µs 1.23% 0.306 -0.794 0.46% 0.004µs 1 200
normalization/normalize_name/normalize_name/good throughput 90270402.169op/s 91325377.422op/s ± 420248.455op/s 91384347.964op/s ± 323079.579op/s 91693023.939op/s 91966305.685op/s 92067545.853op/s 92097462.139op/s 0.78% -0.291 -0.804 0.46% 29716.053op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [209.040µs; 209.164µs] or [-0.030%; +0.030%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4780998.273op/s; 4783765.182op/s] or [-0.029%; +0.029%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.683µs; 18.692µs] or [-0.025%; +0.025%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53498019.665op/s; 53524269.067op/s] or [-0.025%; +0.025%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.943µs; 10.957µs] or [-0.064%; +0.064%] None None None
normalization/normalize_name/normalize_name/good throughput [91267135.028op/s; 91383619.816op/s] or [-0.064%; +0.064%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 71.52%. Comparing base (f03ceab) to head (1b7f4d9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #999   +/-   ##
=======================================
  Coverage   71.51%   71.52%           
=======================================
  Files         337      337           
  Lines       50511    50516    +5     
=======================================
+ Hits        36124    36132    +8     
+ Misses      14387    14384    -3     
Components Coverage Δ
crashtracker 42.66% <ø> (ø)
crashtracker-ffi 6.30% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.93% <ø> (ø)
data-pipeline-ffi 90.35% <ø> (ø)
ddcommon 79.95% <ø> (ø)
ddcommon-ffi 66.37% <ø> (ø)
ddtelemetry 60.33% <ø> (+0.03%) ⬆️
ddtelemetry-ffi 21.43% <ø> (ø)
dogstatsd-client 82.57% <ø> (ø)
ipc 82.42% <ø> (ø)
profiling 77.58% <ø> (ø)
profiling-ffi 62.28% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 41.65% <ø> (ø)
sidecar-ffi 6.02% <ø> (ø)
spawn-worker 54.37% <ø> (ø)
tinybytes 91.59% <ø> (ø)
trace-mini-agent 73.82% <ø> (ø)
trace-normalization 98.24% <ø> (ø)
trace-obfuscation 96.00% <ø> (ø)
trace-protobuf 78.50% <ø> (ø)
trace-utils 92.88% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sanchda sanchda marked this pull request as ready for review April 4, 2025 13:28
@sanchda sanchda requested a review from a team as a code owner April 4, 2025 13:28
@sanchda sanchda requested review from danielsn and Copilot April 4, 2025 13:28
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

bin_tests/tests/crashtracker_bin_test.rs:336

  • The telemetry test now only supports SIGSEGV, which might cause test failures if any platform still produces SIGABRT. Verify that inline assembly reliably triggers SIGSEGV across all intended environments.
assert!(tags.contains("si_signo_human_readable:SIGSEGV"), "{tags:?}");

Copy link
Contributor

@taegyunkim taegyunkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for quickly updating this!

@sanchda sanchda changed the title chore: fix crashtracker segfault tests for 1.86.0 [crashtracker] fix segfault tests for 1.86.0 Apr 7, 2025
@sanchda sanchda enabled auto-merge (squash) April 7, 2025 19:06
@morrisonlevi morrisonlevi requested a review from a team as a code owner April 8, 2025 19:04
@morrisonlevi morrisonlevi changed the title [crashtracker] fix segfault tests for 1.86.0 test(crashtracker): fix segfault tests for 1.86.0 Apr 8, 2025
@morrisonlevi
Copy link
Contributor

Seems the assembly for ARM gets rejected:

error: invalid operand for instruction
  --> bin_tests/src/bin/crashtracker_bin_test.rs:39:30
   |
39 |             std::arch::asm!("ldr x0, [xzr]", options(nostack));
   |                              ^
   |
note: instantiated into assembly here
  --> <inline asm>:1:11
   |
1  |     ldr x0, [xzr]
   |              ^
error: could not compile `bin_tests` (bin "crashtracker_bin_test") due to 1 previous error

Copy link
Contributor

@morrisonlevi morrisonlevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my previous comment, meant it as my review.

@r1viollet
Copy link
Contributor

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.78 MB 7.78 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 77.61 MB 77.61 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 23.99 MB 23.99 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 7.71 MB 7.71 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 71.92 MB 71.92 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 22.58 MB 22.58 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 16.89 MB 16.89 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 61.83 KB 61.83 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 113.06 MB 113.06 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 631.14 MB 631.14 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 5.05 MB 5.05 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 61.83 KB 61.83 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 16.05 MB 16.05 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 26.71 MB 26.71 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 14.29 MB 14.29 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 62.78 KB 62.78 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 115.02 MB 115.04 MB +.01% (+16.00 KB) 🔍
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 623.12 MB 623.12 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 3.82 MB 3.82 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 62.78 KB 62.78 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 16.68 MB 16.68 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 24.61 MB 24.61 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 66.88 MB 66.88 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.24 MB 8.24 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 23.13 MB 23.13 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 67.82 MB 67.82 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 8.12 MB 8.12 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 20.77 MB 20.77 MB 0% (0 B) 👌

@sanchda sanchda requested a review from morrisonlevi April 9, 2025 17:25
@morrisonlevi morrisonlevi disabled auto-merge April 9, 2025 17:37
@morrisonlevi
Copy link
Contributor

I'm going to force merge because this is taking over 30 minutes again:

#77 exporting to GitHub Actions Cache
#77 preparing build cache for export

This takes like 6 minutes when it works, this is happening a lot, we should figure it out.

@morrisonlevi morrisonlevi merged commit e1678bf into main Apr 9, 2025
33 of 35 checks passed
@morrisonlevi morrisonlevi deleted the sanchda/fix_crashtracker_test_for_186 branch April 9, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants