Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libddwaf v2 #377

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

libddwaf v2 #377

wants to merge 8 commits into from

Conversation

Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Mar 4, 2025

This PR tracks the current progress for the v2-alpha release, all changes will be independently reviewed before merging them to this branch.

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 81.68007% with 205 lines in your changes missing coverage. Please review.

Project coverage is 84.90%. Comparing base (9c9d74e) to head (6f1e0d9).

Files with missing lines Patch % Lines
src/interface.cpp 61.08% 46 Missing and 40 partials ⚠️
src/object_view.hpp 75.71% 5 Missing and 29 partials ⚠️
src/object.hpp 86.20% 6 Missing and 14 partials ⚠️
src/ruleset_info.hpp 52.38% 1 Missing and 9 partials ⚠️
src/iterator.cpp 93.33% 0 Missing and 8 partials ⚠️
src/processor/base.hpp 45.45% 0 Missing and 6 partials ⚠️
src/iterator.hpp 77.27% 1 Missing and 4 partials ⚠️
src/condition/cmdi_detector.cpp 85.18% 0 Missing and 4 partials ⚠️
src/event.cpp 95.65% 1 Missing and 2 partials ⚠️
src/matcher/base.hpp 81.25% 2 Missing and 1 partial ⚠️
... and 14 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
- Coverage   85.08%   84.90%   -0.19%     
==========================================
  Files         164      166       +2     
  Lines        8274     8425     +151     
  Branches     3627     3595      -32     
==========================================
+ Hits         7040     7153     +113     
- Misses        471      495      +24     
- Partials      763      777      +14     
Flag Coverage Δ
waf_test 84.90% <81.68%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pr-commenter
Copy link

pr-commenter bot commented Mar 15, 2025

Benchmarks clang

Benchmark execution time: 2025-03-20 17:01:12

Comparing candidate commit 6f1e0d9 in PR branch anilm3/v2 with baseline commit 9c9d74e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@pr-commenter
Copy link

pr-commenter bot commented Mar 15, 2025

Benchmarks gcc

Benchmark execution time: 2025-03-20 17:03:16

Comparing candidate commit 6f1e0d9 in PR branch anilm3/v2 with baseline commit 9c9d74e in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 0 metrics, 0 unstable metrics.

scenario:global-benchmark.random.gcc

  • 🟩 execution_time [-11.214ms; -11.177ms] or [-3.925%; -3.912%]

@Anilm3 Anilm3 marked this pull request as ready for review March 16, 2025 16:54
@Anilm3 Anilm3 requested a review from a team as a code owner March 16, 2025 16:54
@DataDog DataDog deleted a comment from pr-commenter bot Mar 16, 2025
@pr-commenter
Copy link

pr-commenter bot commented Mar 19, 2025

Benchmarks clang-pgo

Benchmark execution time: 2025-03-20 17:15:56

Comparing candidate commit 6f1e0d9 in PR branch anilm3/v2 with baseline commit 9c9d74e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

…#378, #382)

- Writable objects: owned and borrowed object (#378)
- Remove object limits and defer truncation to the caller (#382)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants