fix(test): collect coverage without using bash #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent versions of `nginx:x-alpine` docker images does not have `bash` installed anymore making the collection of code coverage failing. This remove the dependency on bash.
dmehala
force-pushed
the
dmehala/fix/alpine-bash
branch
from
def55f8 to
c32eb05
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #189 +/- ##
=======================================
Coverage 70.26% 70.26%
=======================================
Files 47 47
Lines 6224 6224
Branches 882 882
=======================================
Hits 4373 4373
Misses 1423 1423
Partials 428 428 🚀 New features to boost your workflow:
|
dmehala
requested review from
cataphract,
dubloom and
pablomartinezbernardo
and removed request for
a team
cataphract
approved these changes
Apr 3, 2025
| "find", | ||
| "/tmp", | ||
| "-name", | ||
| "*.profraw", |
There was a problem hiding this comment.
I think it would be simpler to just avoid process substitution and pass the files to tar on the command line:
tar_command = docker_compose_command(
"exec",
"-T",
"--",
"nginx",
"sh",
"-c",
"find /tmp -maxdepth 1 -name '*.profraw' | xargs tar --transform='s@tmp/@@' -czf -",
)There was a problem hiding this comment.
That's a possibility. It's clever, however, I am afraid not everyone can understand this command line, whereas python code is much more expressive.
EDIT: I did try using xargs but got piping issues IIRC or I probably did it wrong :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recent versions of
nginx:<VERSION>-alpinedocker images does not havebashinstalled anymore making the collection of code coverage failing... and test failing. This remove the dependency on bash.