Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(join/function): Add tests to signature-contains #582

Conversation

kakkoyun
Copy link
Member

@kakkoyun kakkoyun commented Mar 25, 2025

Adds flexible function signature matching to support partial and order-independent type matching.

This enables simpler instrumentation configuration when targeting functions that share common types (e.g. context.Context or error) regardless of their position or other parameters.

The change simplifies instrumentation configuration by reducing the need for multiple matchers when targeting related function groups

Changes

  • Added SignatureContains matcher that checks for presence of types anywhere in function signatures
  • Supports matching on partial argument/return types without requiring exact matches
  • Added tests

@kakkoyun kakkoyun changed the base branch from main to eliottness/signature-contains March 25, 2025 09:47
@kakkoyun kakkoyun changed the base branch from eliottness/signature-contains to main March 25, 2025 09:48
@kakkoyun kakkoyun requested a review from eliottness March 25, 2025 09:49
@kakkoyun kakkoyun changed the base branch from main to eliottness/signature-contains March 25, 2025 12:02
@kakkoyun kakkoyun changed the title join/function: Add tests to signature-contains chore(join/function): Add tests to signature-contains Mar 26, 2025
@kakkoyun kakkoyun force-pushed the kakkoyun/add-tests-to-signature-contains branch from 3b58b7c to 4306ec3 Compare March 26, 2025 10:34
@kakkoyun kakkoyun marked this pull request as ready for review March 26, 2025 10:34
@kakkoyun kakkoyun requested a review from a team as a code owner March 26, 2025 10:34
@kakkoyun kakkoyun force-pushed the kakkoyun/add-tests-to-signature-contains branch from 4306ec3 to 509ae00 Compare March 26, 2025 10:38
@eliottness eliottness force-pushed the eliottness/signature-contains branch from 264d584 to 27e160a Compare March 26, 2025 10:57
@kakkoyun kakkoyun merged commit 78c8234 into eliottness/signature-contains Mar 26, 2025
46 checks passed
@kakkoyun kakkoyun deleted the kakkoyun/add-tests-to-signature-contains branch March 26, 2025 14:14
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (eliottness/signature-contains@27e160a). Learn more about missing BASE report.
Report is 1 commits behind head on eliottness/signature-contains.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             eliottness/signature-contains     #582   +/-   ##
================================================================
  Coverage                                 ?   70.00%           
================================================================
  Files                                    ?      108           
  Lines                                    ?     7310           
  Branches                                 ?        0           
================================================================
  Hits                                     ?     5117           
  Misses                                   ?     1682           
  Partials                                 ?      511           
Components Coverage Δ
Generators 80.24% <ø> (?)
Instruments ∅ <ø> (?)
Go Driver 76.51% <ø> (?)
Toolexec Driver 70.99% <ø> (?)
Aspects 77.55% <100.00%> (?)
Injector 76.78% <100.00%> (?)
Job Server 69.18% <ø> (?)
Other 70.00% <100.00%> (?)
Files with missing lines Coverage Δ
internal/injector/aspect/join/function.go 73.23% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants