-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] Add tests for database sources in springboot #3742
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing for spring-boot variants 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TestSqlRow is also used in nodejs. Could impact your changes on nodejs? We are only testing this change for java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! BTW is there any reason to not implement the endpoints on the other variants?
@Mariovido when the test logic is modified, you should not use title prefix. I understand that it was easier to have a quicker CI for the merge commit, but it happen too often to have issues, we really prefer to not take any risk. Thanks you 🙏 |
Motivation
Add new test for java to check that SQL Injection with database sources is supported.
Changes
Workflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present