Skip to content

Conversation

@mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Jan 7, 2025

Motivation

Enable distributed tracing tests for the cpp tracer

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mabdinur mabdinur changed the title Munir/enable cpp tests parametric: enable XPassing tests [cpp] Jan 21, 2025
@mabdinur mabdinur force-pushed the munir/enable-cpp-tests branch from b2fd300 to e51c3f7 Compare January 23, 2025 17:41
@mabdinur mabdinur marked this pull request as ready for review January 23, 2025 17:41
@mabdinur mabdinur requested a review from a team as a code owner January 23, 2025 17:41
@mabdinur mabdinur requested review from pablomartinezbernardo and removed request for a team January 23, 2025 17:41
@mabdinur mabdinur merged commit 3d705e2 into main Jan 27, 2025
433 checks passed
@mabdinur mabdinur deleted the munir/enable-cpp-tests branch January 27, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants