Skip to content

Conversation

@zacharycmontoya
Copy link
Contributor

Motivation

Fix a known issue where remote config payloads get rejected by the C++ tracer

Changes

Runs the associated test, the feature work is implemented in DataDog/dd-trace-cpp#177

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@zacharycmontoya zacharycmontoya force-pushed the zach.montoya/remote-config-cpp-fix branch from 8bb25cf to c51a074 Compare April 4, 2025 17:38
@zacharycmontoya zacharycmontoya marked this pull request as ready for review April 4, 2025 17:56
@zacharycmontoya zacharycmontoya requested a review from a team as a code owner April 4, 2025 17:56
@zacharycmontoya zacharycmontoya requested review from pablomartinezbernardo and removed request for a team April 4, 2025 17:56
@zacharycmontoya zacharycmontoya merged commit 858b194 into main Apr 4, 2025
26 checks passed
@zacharycmontoya zacharycmontoya deleted the zach.montoya/remote-config-cpp-fix branch April 4, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants