Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[golang] enable go system test for asm standalone v2 #4198

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

genesor
Copy link
Member

@genesor genesor commented Feb 26, 2025

Motivation

APPSEC-56328

Changes

  • Enable Test_AppSecStandalone_UpstreamPropagation_V2 for Go
  • Mark Test_AppSecStandalone_UpstreamPropagation as irrelevant for Go > 1.72.1

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@eliottness eliottness changed the title feat: enable go system test for asm standalone v2 [golang] enable go system test for asm standalone v2 Feb 26, 2025
@genesor genesor marked this pull request as ready for review February 27, 2025 13:35
@genesor genesor requested review from a team as code owners February 27, 2025 13:35
@genesor genesor requested a review from eliottness February 27, 2025 13:35
Copy link
Contributor

@eliottness eliottness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for dd-trace-go PR to be merged before merging this

@genesor genesor force-pushed the ben.db/APPSEC-56328-enable-go-system-test branch from 3d77f86 to cb2e5a2 Compare February 28, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants