Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating log injection tests and creating logs/library weblog endpoint for Java #4229

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mhlidd
Copy link
Contributor

@mhlidd mhlidd commented Feb 28, 2025

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mhlidd mhlidd marked this pull request as ready for review February 28, 2025 20:42
@mhlidd mhlidd requested review from a team as code owners February 28, 2025 20:42
@mhlidd mhlidd requested review from smola, jandro996, cbeauchesne, a team, vpellan, zacharycmontoya and mtoffl01 and removed request for a team and vpellan February 28, 2025 20:42
Comment on lines +525 to +526
if context.library.library == "java":
required_fields = ["dd.service", "dd.version", "dd.env"]
Copy link
Contributor

@mtoffl01 mtoffl01 Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because java applies dd_tags to logs? If so, maybe this isn't the right test to check for it, since "applying dd_tags to injected logs" is not "in scope" for dd_logs_injection, I'd consider that under scope of dd_tags instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants