-
Notifications
You must be signed in to change notification settings - Fork 13
[python] update python weblogs for ato sdk v2 #4565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
avara1986
merged 10 commits into
main
from
christophe-papazian/use_ato_sdk_v2_for_django
May 5, 2025
Merged
[python] update python weblogs for ato sdk v2 #4565
avara1986
merged 10 commits into
main
from
christophe-papazian/use_ato_sdk_v2_for_django
May 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
christophe-papazian
added a commit
to DataDog/dd-trace-py
that referenced
this pull request
Apr 30, 2025
A new public SDK for ATO/user events for AAP. Available with ```python from ddtrace.appsec import track_user_sdk # to track successful login attempts track_user_sdk.track_login_success(login, user_id:optional, metadata:optional) # to track failed login attempts track_user_sdk.track_login_failure(login, exists, user_id:optional, metadata:optional) # to track any custom event track_user_sdk.track_custom_event(event, metatada) # to track signup events track_user_sdk.track_signup(login, user_id:optional, success:optional, metadata:optional) # to track authentified user (usually in middleware, using auth token) track_user_sdk.track_user(login, user_id, session_id:optional, metadata:optional) ``` Also: - minor fixes and improvements in current ATO support. - threat tests added for sdk (span tags and telemetry unit tests) This will be validated in system tests with DataDog/system-tests#4565 The documentation page to be updated is https://docs.datadoghq.com/security/application_security/threats/add-user-info/?tab=loginsuccess&code-lang=python APPSEC-56663 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
…b.com:DataDog/system-tests into christophe-papazian/use_ato_sdk_v2_for_django
avara1986
approved these changes
May 5, 2025
7 tasks
brettlangdon
pushed a commit
to DataDog/dd-trace-py
that referenced
this pull request
May 6, 2025
A new public SDK for ATO/user events for AAP. Available with ```python from ddtrace.appsec import track_user_sdk # to track successful login attempts track_user_sdk.track_login_success(login, user_id:optional, metadata:optional) # to track failed login attempts track_user_sdk.track_login_failure(login, exists, user_id:optional, metadata:optional) # to track any custom event track_user_sdk.track_custom_event(event, metatada) # to track signup events track_user_sdk.track_signup(login, user_id:optional, success:optional, metadata:optional) # to track authentified user (usually in middleware, using auth token) track_user_sdk.track_user(login, user_id, session_id:optional, metadata:optional) ``` Also: - minor fixes and improvements in current ATO support. - threat tests added for sdk (span tags and telemetry unit tests) This will be validated in system tests with DataDog/system-tests#4565 The documentation page to be updated is https://docs.datadoghq.com/security/application_security/threats/add-user-info/?tab=loginsuccess&code-lang=python APPSEC-56663 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged after DataDog/dd-trace-py#13251
APPSEC-56663
Workflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present