Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_rum_metric] Add support for the resource. #2643

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

hemeryar
Copy link

@hemeryar hemeryar commented Nov 4, 2024

Adds terraform support for RUM custom metrics. Leverages this public API:
https://docs.datadoghq.com/api/latest/rum-metrics/

https://datadoghq.atlassian.net/browse/RUM-5984

@hemeryar hemeryar changed the base branch from arthur.hemery/version-bump to master November 6, 2024 15:12
@hemeryar hemeryar force-pushed the arthur.hemery/rum-metrics branch 2 times, most recently from 0fa4fb4 to 7b17160 Compare November 6, 2024 15:58
@hemeryar hemeryar changed the title [rum_metric] Add support [datadog-rum-metrics] Add support for datadog_rum_metric resource Nov 6, 2024
@hemeryar hemeryar changed the title [datadog-rum-metrics] Add support for datadog_rum_metric resource [datadog-rum-metrics] Add support for datadog_rum_metric resource Nov 6, 2024
@DataDog DataDog deleted a comment from github-actions bot Nov 6, 2024
@hemeryar hemeryar marked this pull request as ready for review November 14, 2024 08:06
@hemeryar hemeryar requested review from a team as code owners November 14, 2024 08:06
@hemeryar hemeryar changed the title [datadog-rum-metrics] Add support for datadog_rum_metric resource [datadog_rum_metric] Add support for the resource. Nov 14, 2024
### Required

- `event_type` (String) The type of RUM events to filter on.
- `name` (String) The name of the rum-based metric. This field can't be updated after creation.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `name` (String) The name of the rum-based metric. This field can't be updated after creation.
- `name` (String) The name of the RUM-based metric. This field can't be updated after creation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Optional:

- `include_percentiles` (Boolean) Toggle to include or exclude percentile aggregations for distribution metrics. Only present when `aggregation_type` is `distribution`.
- `path` (String) The path to the value the rum-based metric will aggregate on. Only present when `aggregation_type` is `distribution`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `path` (String) The path to the value the rum-based metric will aggregate on. Only present when `aggregation_type` is `distribution`.
- `path` (String) The path to the value the RUM-based metric will aggregate on. Only present when `aggregation_type` is `distribution`.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


Optional:

- `query` (String) The search query - following the RUM search syntax.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `query` (String) The search query - following the RUM search syntax.
- `query` (String) The search query. Follows RUM search syntax.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


Optional:

- `path` (String) The path to the value the rum-based metric will be aggregated over.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `path` (String) The path to the value the rum-based metric will be aggregated over.
- `path` (String) The path to the value the RUM-based metric will be aggregated over.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Optional:

- `path` (String) The path to the value the rum-based metric will be aggregated over.
- `tag_name` (String) Eventual name of the tag that gets created. By default, `path` is used as the tag name.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `tag_name` (String) Eventual name of the tag that gets created. By default, `path` is used as the tag name.
- `tag_name` (String) Name of the tag that gets created. By default, `path` is used as the tag name.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants