Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_synthetics_test] Add always_execute and exit_if_succeed to browser steps #2647

Conversation

Drarig29
Copy link
Contributor

@Drarig29 Drarig29 commented Nov 6, 2024

This PR adds always_execute and exit_if_succeed after https://github.com/DataDog/datadog-api-spec/pull/3266

Note: Redo of #2645, because it was merged into another PR 😅

@Drarig29 Drarig29 changed the title Corentin.girard/synth 16831/add always execute and exit if succeed [datadog_synthetics_test] Add always_execute and exit_if_succeed to browser steps Nov 6, 2024
@skarimo skarimo force-pushed the jack-edmonds-dd/bump-version branch from 3b750ce to d5184ff Compare November 6, 2024 14:24
Base automatically changed from jack-edmonds-dd/bump-version to master November 6, 2024 15:04
@Drarig29 Drarig29 force-pushed the corentin.girard/SYNTH-16831/add-alwaysExecute-and-exitIfSucceed branch from 1b72078 to 89d5b43 Compare November 6, 2024 15:43
@Drarig29 Drarig29 marked this pull request as ready for review November 6, 2024 15:43
@Drarig29 Drarig29 requested review from a team as code owners November 6, 2024 15:43
@Drarig29
Copy link
Contributor Author

Drarig29 commented Nov 6, 2024

@jack-edmonds-dd sorry for the double PR. The original one was based on another PR by someone else, and we agreed to "unmerge" my PR from his 😅

@Drarig29 Drarig29 removed the do-not-merge/WIP Do not merge this PR label Nov 6, 2024
@Drarig29 Drarig29 requested a review from a team as a code owner November 6, 2024 16:05
@Drarig29 Drarig29 marked this pull request as draft November 6, 2024 16:38
@Drarig29 Drarig29 marked this pull request as ready for review November 14, 2024 13:01
@amaskara-dd amaskara-dd merged commit df830af into master Nov 14, 2024
14 checks passed
@amaskara-dd amaskara-dd deleted the corentin.girard/SYNTH-16831/add-alwaysExecute-and-exitIfSucceed branch November 14, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants