Make recommended keywords an opt-out option in terraform #2667
+308
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HantingZhang2
approved these changes
Nov 13, 2024
fuchsnj
approved these changes
Nov 13, 2024
michaelcretzman
approved these changes
Nov 13, 2024
amaskara-dd
added a commit
that referenced
this pull request
Nov 14, 2024
…)" This reverts commit 91276c1.
amaskara-dd
added a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make recommended keywords an opt-out option from terraform.
See the full explanation of what we are doing at https://datadoghq.atlassian.net/wiki/spaces/SDS/pages/4373446920/Use+opt-out+strategy+for+keyword+config+in+Terraform
We decided to go for option 1, option where we don't expose the new field called
use_recommended_keywordsin terraform directly, but depending on what the user decides to do, let's make the field true, or false, or leave it empty