Repository navigation
Extract Add metadata values with a regular expression - #20
Merged
Merged
Conversation
Bridge dialogs now resolve active states and callbacks while the Python call that opened them is pending. Assisted-by: Claude Opus 5.5
Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the DataLab desktop improvements of Edit > Metadata > Add metadata… (DataLab-Platform/DataLab#379), so users can set the metadata expected by application plugins from object titles.
DataSet.edit_async(macros, plugins, Add metadata) could not updateactivestates or run display callbacks while open, because their resolvers were queued behind the pending Python call.resolveBridgeActiveand the newresolveBridgeCallbacksnow bypass the Pyodide call queue;DialogBridgewires the callbacks.Tests: pytest
test_metadata.py, VitestDialogBridge.test.tsx, Playwrightadd_metadata_bridge.spec.ts(new permanent spec covering the bridge fix).Assisted-by: Claude Opus 5.5