persist-preferredLanguage #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
Hi @PedroMarianoAlmeida , thanks for the work! The only reason why I didn't do this myself is because I consider that changing the language in the component page should instantly be reflected in the header as well and I didn't allocate time to implement this. Would you be interested in this challenge as part of your PR? |
It is that? Yep, I can take care of it on this MR =D
|
|
Yep that's it :) |
Screen.Recording.2025-04-01.at.10.26.25.PM.movNote: I was also considering persisting the Default/Tailwind option too (because I always need to click for the Tailwind option). Can I do it in a separate MR? |
DavidHDev
approved these changes
Apr 3, 2025
|
Thanks! I don't really want to do the same for the styling choice, so I'd say just leave it as is. |
AthalarBlizz
pushed a commit
to EventHorizon-Forge/ehfcreact-bits
that referenced
this pull request
May 4, 2025
…ferredLanguage persist-preferredLanguage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
Screen.Recording.2025-03-30.at.1.08.42.AM.mov
After:
Screen.Recording.2025-03-30.at.1.09.56.AM.mov
Note: The
localStorage.getItem('preferredLanguage') || 'JS';was already on the code, so I just added the SET when the user updates the option