Hash helper {{#form-for model as |f|}}

[diogomafra]

The future is here! 🎆

Please, don't merge this PR!!

This is a test using the new hash helper available on Ember 2.3. As you can see, it is very simple to support the new syntax.

{{#form-for model as |f|}}
  {{f.input "firstName"}}
  {{f.input "lastName"}}
   <input type="submit">
 {{/form-for}}

[diogomafra]

For the record, there is an issue related to positional params on Ember 2.3: emberjs/ember.js#12762

We get this error:

Assertion Failed: You cannot specify both a positional param (at position 0) 
and the hash argument `propertyName`.

[bcardarella]

@diogomafra as long as the pre-existing API is not affected then I'm 👍 on this for 1-0-stable. I would prefer to maintain semver compatibility and not break backwards compatibility. It seems from the change in the test this might not be the case?

FWIW, this syntax is the direction I've had in mind for about two years for easy-form 2.0.

[diogomafra]

@bcardarella It's possible to support both APIs. I just changed the test to demonstrate that the scoped helper is working.

To finish this PR we need:

• to fix this issue Component helper with positionalParams broken emberjs/ember.js#12762
• make it work with previous versions of Ember that don't have the hash helper
• test the new api
• update the documentation

I'm going to keep this PR here until Ember 2.3 lands, with the issue fixed.

[jcope2013]

"make it work with previous versions of Ember that don't have the hash helper"

this might help https://github.com/cibernox/ember-hash-helper-polyfill

[diogomafra]

@jcope2013 this is very nice. Thank you for pointing this addon.

[Serabe]

@diogomafra: I think this is not what is causing your problem. I think your problem is in these lines. You can see that knownProperties are copied to the options causing the positional param to already be there.

[Serabe]

Sorry, I thought I was writing last comment in emberjs/ember.js#12762

The first this refers to that issue.

Sorry again.

[diogomafra]

@Serabe the test that is failing does not use this handlebar's keyword, but it has a similar code: https://github.com/diogomafra/ember-easy-form/blob/hash-helper/addon/components/internal-input-for.js#L96

In that code, all "known properties" are removed, "propertyName" among them, so, it's not including this value twice.

I will try to create a failing test on Ember's repo to demonstrate the problem. Then we can be sure it's on Ember and it will be easier to fix.

Thank you!

[Serabe]

If you are in the Ember community Slack, ping me to take a deeper look at this, please.

[Serabe]

@diogomafra I updated the other issue, but I think this test will pass in 2.3 beta 4 / 2.3.0. There was a fix for the same issue added a day after beta 3 was released.

[diogomafra]

@Serabe using the canary build instead of beta, it works. Thank you very much for your help.

[Serabe]

You're welcome! 👍

[bcardarella]

Closing in favor of #229