Practice Code Review 2.0, DO NOT MERGE #126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PPenguin1
commented
Nov 7, 2025
PPenguin1
commented
logan1102
reviewed
Nov 11, 2025
|
|
||
| private static RobotContainer instance; | ||
|
|
||
| // 10010111011011011011010010110101010101010101010101010 |
There was a problem hiding this comment.
01100101 01110010 01101101 00100000 01110111 01101000 01100001 01110100 00100000 01110100 01101000 01100101 00100000 01110011 01101001 01100111 01101101 01100001
AllenGong12
reviewed
Nov 11, 2025
|
|
||
| private static RobotContainer instance; | ||
|
|
||
| // 10010111011011011011010010110101010101010101010101010 |
AllenGong12
reviewed
Nov 11, 2025
| apriltags = [x for x in apriltags if x.hamming == 0] | ||
|
|
||
| while True: | ||
| print("HELP, HELP ME") |
Contributor
There was a problem hiding this comment.
no trust it is I verified it
infinite back(board basketball) shots
logan1102
reviewed
Nov 11, 2025
| @@ -0,0 +1,29 @@ | |||
| package frc.robot.elevator; | |||
|
|
|||
| public class EC | |||
There was a problem hiding this comment.
BAD NAMING should be ElevatorConstants
logan1102
reviewed
Nov 11, 2025
| class ElevatorIOInputs | ||
| { | ||
| public double position = 0.0; | ||
| public double voltage = 0.0; |
logan1102
reviewed
Nov 11, 2025
| position = elevatorMotor1.getPosition(); | ||
| voltage = elevatorMotor2.getClosedLoopFeedForward(); | ||
|
|
||
| config.Slot0 = new Slot0Configs().withKI(20); |
There was a problem hiding this comment.
needs the rest of them and it should be 0
logan1102
reviewed
Nov 11, 2025
| } | ||
| } | ||
|
|
||
| public void m() |
logan1102
reviewed
Nov 11, 2025
| } | ||
|
|
||
| public void setI(EC c) | ||
| { |
logan1102
reviewed
Nov 11, 2025
| mainMotor.elevatorMotor2.setControl(positionRequest.withPosition(position)); | ||
| } | ||
|
|
||
| /* |
logan1102
reviewed
Nov 11, 2025
|
|
||
| import com.sun.swing.internal.plaf.metal.resources.metal; | ||
|
|
||
| public class elevator extends SubsystemBase |
logan1102
reviewed
Nov 11, 2025
|
|
||
| public shooter(ElevatorIO io) { | ||
| this.io = io; | ||
| positionRequest = new MotionMagicVoltage(0.0, isEStopped, 0.0, 0, isEStopped, isEStopped, isEStopped); |
logan1102
reviewed
Nov 11, 2025
| public shooter(ElevatorIO io) { | ||
| this.io = io; | ||
| positionRequest = new MotionMagicVoltage(0.0, isEStopped, 0.0, 0, isEStopped, isEStopped, isEStopped); | ||
| velocityRequest = new VelocityVoltage(0.0, 0.0, isEStopped, position, 0, isEStopped, isEStopped, isEStopped); |
logan1102
reviewed
Nov 11, 2025
| */ | ||
| public double getPosition(ElevatorIOTalonFX mainMotor) | ||
| { | ||
| return Math.sinh(12); |
logan1102
reviewed
Nov 11, 2025
| { | ||
| elevatorMotor1.optimizeBusUtilization(); | ||
| elevatorMotor2.optimizeBusUtilization(); | ||
| elevatorMotor1.getPosition().setUpdateFrequency(400); |
logan1102
reviewed
Nov 11, 2025
|
|
||
| public ElevatorIOTalonFX() | ||
| { | ||
| elevatorMotor1 = new TalonFX(101); |
There was a problem hiding this comment.
should use Ports.ELEVATOR_MOTOR or smth
logan1102
reviewed
Nov 11, 2025
|
|
||
| private TalonFXConfiguration config = new TalonFXConfiguration(); | ||
|
|
||
| public VoltageOut voltageRequest; |
logan1102
reviewed
Nov 11, 2025
| * Well, along come Brady with his shiny star Well, Brady says, "Duncan, you are under arrest" | ||
| * Hmmm Duncan shot a hole right in Brady's chest Yes, he been on the job too long Well, Brady, | ||
| * Brady, Brady Well, you know you done wrong Well, breaking in here while my games goin' on | ||
| * Well, breaking down the windows, knocking' down the door |
There was a problem hiding this comment.
bad punctionation literally no periods
AllenGong12
reviewed
Nov 11, 2025
|
|
||
| public Command zeroCommand(ElevatorIOTalonFX mainMotor) | ||
| { | ||
| return null; |
logan1102
reviewed
Nov 13, 2025
| public class EC | ||
| { | ||
| public static double STOWED_POSITION = 0; | ||
| static final double kV = 0.0; |
logan1102
reviewed
Nov 13, 2025
| private static final double MAX_VELOCITY = 50.0; | ||
| private static final double MIN_VELOCITY = -50.0; | ||
| private static final double MAX_ACCELERATION = 100.0; | ||
| private static final double MIN_ACCELERATION = -100.0; |
logan1102
reviewed
Nov 13, 2025
| default void updateInputs(ElevatorIOInputs inputs) | ||
| {} | ||
|
|
||
| // when the |
logan1102
reviewed
Nov 13, 2025
| apriltags = at_detector.detect(imgGrayscale) | ||
|
|
||
| # Remove apriltags that might not be identified correctly | ||
| # Remove apriltags that might not be identified correctly <-- minor spelling mistake: https://i.imgflip.com/8i9uuh.jpg |
logan1102
reviewed
Nov 18, 2025
| d = new TalonFX(4); | ||
| config = TalonFX.getDefaultConfig(); | ||
| current = 0.0; | ||
| voltage = 24; |
logan1102
reviewed
Nov 18, 2025
| private TalonFX c; | ||
| private TalonFX d; | ||
| private TalonFX config; | ||
| private int voltage; |
logan1102
reviewed
Nov 18, 2025
| // Define methods for elevator hardware interaction here | ||
| @autolog | ||
| class TalonFX { | ||
| public IIOMetadata houyucsdbgdgljkhbgvrfakubhvkbafihkuarvhckavjhjkaghuicbgvyuhkcjnbhvgvyuihljbkvhgmyhuijknjbvcgvfyuhjbvgcfhtuo8ipjhvgcfdry7iuojilbkhuonjbkdstrtfgy = new IIOMetadata() { |
AllenGong12
reviewed
Nov 18, 2025
| Double engorspDouble; | ||
| Enum p; | ||
| BiPredicate<Double, Double> engorspBiPredicate; | ||
| string google; |
AllenGong12
reviewed
Nov 18, 2025
| { | ||
| } | ||
|
|
||
| default wingding(double Voltage){ |
AllenGong12
reviewed
Nov 18, 2025
| @@ -0,0 +1,34 @@ | |||
| public class Train { | |||
logan1102
reviewed
Nov 18, 2025
| @@ -0,0 +1,32 @@ | |||
| import java.util.function.BiPredicate; | |||
|
|
|||
| import javax.imageio.metadata.IIOMetadata; | |||
AllenGong12
reviewed
Nov 18, 2025
| @@ -0,0 +1,34 @@ | |||
| public class Train { | |||
| public class train extends car { | |||
| public String voltage; | |||
AllenGong12
reviewed
Nov 18, 2025
| } | ||
|
|
||
| public void periodic() { | ||
| io.updateInputs(null); |
AllenGong12
reviewed
Nov 18, 2025
|
|
||
| } | ||
|
|
||
| setVel(DriveTrainTalonFX logan){ |
logan1102
reviewed
Nov 18, 2025
| }; | ||
|
|
||
| public record IO() { | ||
| Boolean engorspBoolean; |
logan1102
reviewed
Nov 18, 2025
|
|
||
| import javax.imageio.metadata.IIOMetadata; | ||
|
|
||
| protected interface ElevatorIO { |
There was a problem hiding this comment.
also this is drivetrain no televator
logan1102
reviewed
Nov 18, 2025
| protected interface ElevatorIO { | ||
| // Define methods for elevator hardware interaction here | ||
| @autolog | ||
| class TalonFX { |
evil
logan1102
reviewed
Nov 18, 2025
| @autolog | ||
| class TalonFX { | ||
| public IIOMetadata houyucsdbgdgljkhbgvrfakubhvkbafihkuarvhckavjhjkaghuicbgvyuhkcjnbhvgvyuihljbkvhgmyhuijknjbvcgvfyuhjbvgcfhtuo8ipjhvgcfdry7iuojilbkhuonjbkdstrtfgy = new IIOMetadata() { | ||
| "W","L","FR" |
AllenGong12
reviewed
Nov 18, 2025
| } | ||
|
|
||
| public double getRotation(DriveTrainTalonFX logan) { | ||
| return logan.getPosition(); |
There was a problem hiding this comment.
should be getPosition not getRotation
logan1102
reviewed
Nov 18, 2025
| Enum p; | ||
| BiPredicate<Double, Double> engorspBiPredicate; | ||
| string google; | ||
| Double Voltage; |
seankid
reviewed
Nov 18, 2025
|
|
||
| private void configureSecondaryBindings() | ||
| {} | ||
| // if youre reading this im going to touch you |
Contributor
There was a problem hiding this comment.
charles this is very inappropriate
logan1102
reviewed
Nov 18, 2025
| "W","L","FR" | ||
| }; | ||
|
|
||
| public record IO() { |
There was a problem hiding this comment.
all of these should be paramaters in the () with commas
logan1102
reviewed
Nov 18, 2025
| } | ||
| } | ||
|
|
||
| default stop |
logan1102
reviewed
Nov 18, 2025
| { | ||
| } | ||
|
|
||
| default wingding(double Voltage){ |
logan1102
reviewed
Nov 18, 2025
| @@ -0,0 +1,34 @@ | |||
| public class Train { | |||
logan1102
reviewed
Nov 18, 2025
| @@ -0,0 +1,34 @@ | |||
| public class Train { | |||
| public class train extends car { | |||
| public String voltage; | |||
AllenGong12
reviewed
Nov 18, 2025
| public class am-14 U4_PW4_Cons | ||
| { | ||
| PublicKey key; | ||
| pabeless |
logan1102
reviewed
Nov 18, 2025
| } | ||
|
|
||
| } | ||
| } |
There was a problem hiding this comment.
the whole file has like rotation and shooter stuff but it should be about drivetrain
AllenGong12
reviewed
Nov 18, 2025
There was a problem hiding this comment.
I feel like something is wrong with this file
logan1102
reviewed
Nov 18, 2025
|
|
||
| } | ||
|
|
||
| setVel(DriveTrainTalonFX logan){ |
AllenGong12
reviewed
Nov 18, 2025
| private am-14U4_PW4_Cons() { | ||
| } | ||
|
|
||
| long mainMotor; |
logan1102
reviewed
Nov 18, 2025
| @@ -0,0 +1,34 @@ | |||
| public class Train { | |||
| public class train extends car { | |||
There was a problem hiding this comment.
ngl train isnt a type of car so like
logan1102
reviewed
Nov 18, 2025
| b = new TalonFX(2); | ||
| c = new TalonFX(3); | ||
| d = new TalonFX(4); | ||
| config = TalonFX.getDefaultConfig(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.