Skip to content

Update naming pattern for Log Analytics workspace #290

Merged
KevyVo merged 2 commits into
mainfrom
kevin/operations
Jun 16, 2026
Merged

Update naming pattern for Log Analytics workspace #290
KevyVo merged 2 commits into
mainfrom
kevin/operations

Conversation

@KevyVo

@KevyVo KevyVo commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Somehow my other PR was force closed. Anyway this PR does fix it as well by dropping name in the naming pattern. Since the project and name are identical and are repeated.

Defang-golang-rest-api-production-golang-rest-api-d9f68a0
         └─ project ─┘ └─stack┘    └─ name ──┘

Summary by CodeRabbit

Summary by CodeRabbit

  • Documentation
    • Added inline documentation clarifying Log Analytics workspace naming constraints and the reasoning behind the naming pattern used.

@KevyVo KevyVo requested a review from lionello June 15, 2026 20:32
@KevyVo KevyVo self-assigned this Jun 15, 2026
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b01985ce-3389-479f-ac75-a53a381d0039

📥 Commits

Reviewing files that changed from the base of the PR and between 0bd5647 and 4d96860.

📒 Files selected for processing (1)
  • cd/cd_main.go
✅ Files skipped from review due to trivial changes (1)
  • cd/cd_main.go

📝 Walkthrough

Walkthrough

In cd/cd_main.go, five comment lines are added to the Pulumi project configuration for the Azure operationalinsights:Workspace resource, documenting the Log Analytics workspace naming length constraints and explaining why the naming pattern omits ${name}. No logic changes are made.

Changes

Log Analytics Workspace Naming Documentation

Layer / File(s) Summary
Workspace naming constraint comments
cd/cd_main.go
Added inline comments explaining Azure Log Analytics workspace name length/character limits and the rationale for the naming pattern that omits ${name}.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hopped by the Azure cloud one day,
And found the workspace names had rules to obey.
"Too long!" cried the portal, "trim it down tight!"
So comments were added to shed some light.
Now devs read the code and nod—"Ah, just right!" 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title mentions updating the naming pattern for Log Analytics workspace, which aligns with the primary objective of removing the name field from the naming convention to eliminate redundancy.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch kevin/operations

Comment @coderabbitai help to get the list of available commands and usage tips.

@KevyVo KevyVo linked an issue Jun 15, 2026 that may be closed by this pull request
@KevyVo KevyVo temporarily deployed to defang-staging June 15, 2026 20:34 — with GitHub Actions Inactive
@KevyVo KevyVo requested a review from jordanstephens June 15, 2026 20:34
@KevyVo KevyVo deployed to defang-staging June 15, 2026 20:42 — with GitHub Actions Active
@KevyVo KevyVo merged commit a3aefa3 into main Jun 16, 2026
12 checks passed
@KevyVo KevyVo deleted the kevin/operations branch June 16, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Character length issue on azure-native:operationalinsights:Workspace

2 participants