471 472 473 474 frontend fixes#487
Merged
Dev-AdeTutu merged 5 commits intoJun 28, 2026
Merged
Conversation
- Added null/undefined checks before destructuring response data - Clear error state and reset records/pagination on error - Prevents TypeError when API returns error responses
…t being installed - Added check for window.freighter before calling wallet API - Prevents ReferenceError when extension is not present - Shows user-friendly error message when wallet is not installed
…er add/remove - Implemented missing handleAddSubmit and handleRemove functions - Added onRefresh callback to reload collaborator list after mutations - Added toast notifications for user feedback on add/remove operations - Accepts both onAdd and onRemove callbacks from parent component
…ntStore - Removed zustand persist middleware to prevent meterId leaking to localStorage - Sensitive meter ID data no longer persists across sessions - Prevents unauthorized access to previous user's meter ID on shared devices
|
@Able-faz-system Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix four frontend security and UX issues across payment store, wallet connection, payment history, and collaborator management.
Changes
Issue #471: Handle 502 RPC errors in history page
File:
frontend/src/app/history/page.tsxpaymentsfrom responseTypeError: Cannot destructure property 'payments' of undefinedIssue #472: Guard against Freighter extension not being installed
File:
frontend/src/store/walletStore.tswindow.freighterpresence check before calling wallet APIReferenceErrorcrash when callingkit.openModal()on systems without Freighter installedIssue #473: CollaboratorTable refreshes data after add/remove
File:
frontend/src/components/CollaboratorTable.tsxhandleAddSubmit()andhandleRemove()functionsonRefreshcallback prop to reload collaborator list after mutationsIssue #474: Remove persist middleware from paymentStore
File:
frontend/src/store/paymentStore.tszustand/middlewarepersist importmeterIdwas persisting tolocalStorageindefinitely, allowing a subsequent user on a shared device to see the previous user's meter ID pre-filled in the payment formTesting Checklist
Closes
Closes #471
Closes #472
Closes #473
Closes #474