Diagram Demos - Fix typeExpr implementation #31890
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markallenramirez
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the itemTypeExpr implementation across all framework variants (jQuery, Vue, React, ReactJs, Angular) of the Diagram "CustomShapesWithTemplatesWithEditing" demo. The change converts the function from a simple getter (return 'employee') to a bidirectional getter/setter pattern that can both read and write the type property of diagram nodes.
Key Changes:
- Added two-parameter signature
(obj, value)to support both getting and setting operations - Added setter logic to assign
valuetoobj.typewhen a value is provided - Returns
nullfor setter operations and'employee'for getter operations
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/demos/Demos/Diagram/CustomShapesWithTemplatesWithEditing/jQuery/index.js | Updated typeExpr from simple getter to getter/setter with conditional logic |
| apps/demos/Demos/Diagram/CustomShapesWithTemplatesWithEditing/Vue/App.vue | Updated itemTypeExpr arrow function from simple getter to getter/setter |
| apps/demos/Demos/Diagram/CustomShapesWithTemplatesWithEditing/ReactJs/App.js | Updated itemTypeExpr function from simple getter to getter/setter |
| apps/demos/Demos/Diagram/CustomShapesWithTemplatesWithEditing/React/App.tsx | Updated itemTypeExpr function from simple getter to getter/setter |
| apps/demos/Demos/Diagram/CustomShapesWithTemplatesWithEditing/Angular/app/app.component.ts | Updated itemTypeExpr method from simple getter to getter/setter |
apps/demos/Demos/Diagram/CustomShapesWithTemplatesWithEditing/jQuery/index.js
Outdated
Show resolved
Hide resolved
apps/demos/Demos/Diagram/CustomShapesWithTemplatesWithEditing/Vue/App.vue
Outdated
Show resolved
Hide resolved
apps/demos/Demos/Diagram/CustomShapesWithTemplatesWithEditing/ReactJs/App.js
Outdated
Show resolved
Hide resolved
apps/demos/Demos/Diagram/CustomShapesWithTemplatesWithEditing/React/App.tsx
Outdated
Show resolved
Hide resolved
apps/demos/Demos/Diagram/CustomShapesWithTemplatesWithEditing/Angular/app/app.component.ts
Outdated
Show resolved
Hide resolved
markallenramirez
force-pushed
the
fix_demo_diagram/25_2
branch
from
e027eb1 to
62bb9bb
Compare
apps/demos/Demos/Diagram/CustomShapesWithTemplates/Angular/app/app.component.ts
Show resolved
Hide resolved
markallenramirez
force-pushed
the
fix_demo_diagram/25_2
branch
from
cf11760 to
0c3c229
Compare
apps/demos/Demos/Diagram/CustomShapesWithTemplates/Angular/app/app.component.ts
Show resolved
Hide resolved
markallenramirez
force-pushed
the
fix_demo_diagram/25_2
branch
from
0c3c229 to
7813d15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.