✨AI Column: Cover leftovers and write e2e tests #31945
Open
+1,013
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive end-to-end TestCafe tests for the AI Column feature in both DataGrid and TreeList components. The changes include new TestCafe page object models for AI-related UI elements, consolidation of HTML test fixtures, and extensive functional tests covering AI column operations.
Key changes:
- Added TestCafe models for AI-specific UI components (
getAIHeaderButton()in HeaderCell, new AIPromptEditor model with methods for interacting with the prompt editor dialog) - Consolidated test HTML files by creating a shared
container-ai-integration.htmlfixture and updating test file imports - Added 6 functional tests for DataGrid AI column covering: displaying AI results, regenerating requests via dropdown and prompt editor, clearing data, aborting requests, and changing prompts
- Added 6 equivalent functional tests for TreeList AI column to ensure feature parity between DataGrid and TreeList
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/testcafe-models/dataGrid/headers/cell.ts | Added getAIHeaderButton() method to HeaderCell model for accessing the AI header button |
| packages/testcafe-models/dataGrid/aiPromptEditor.ts | New TestCafe model for AI Prompt Editor with methods to access textarea and control buttons (regenerate, stop, apply) |
| e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/virtualScrolling.functional.ts | Updated to use consolidated HTML fixture path |
| e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/pages/containerWithAIIntegration.html | Deleted duplicate HTML fixture in favor of consolidated version |
| e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/functional.ts | Added 6 comprehensive e2e tests for AI column functionality and updated fixture path |
| e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/adaptivity.functional.ts | Updated to use consolidated HTML fixture path |
| e2e/testcafe-devextreme/tests/container-ai-integration.html | New consolidated HTML test fixture with AI integration support, replacing per-test duplicates |
| e2e/testcafe-devextreme/tests/common/treeList/aiColumn/functional.ts | New file with 6 comprehensive e2e tests for TreeList AI column functionality, mirroring DataGrid tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.